Ok, here is my alternative approach to hotkey configuration.

Downside: It does *not* allow to freely choose any keys for hotkeys.
Hotkeys are restricted to be one normal key combined with up to three
modifiers (no modifiers is fine too).

Upside:  The code is simpler.  We don't have to keep back events because
they might be part of a hotkey.  The code also supports multiple
hotkeys.

While being at it have the code also track all key state, so user
interfaces don't have to do that on their own any more.

The sdl2 ui is used to show this in action.  No command line option
parsing added yet, so hotkeys are not actually configurable for now.
The groundwork to change them at runtime is there though.

Gerd Hoffmann (5):
  kbd-state: add keyboard state tracker
  kbd-state: add hotkey registry
  kbd-state: use state tracker for sdl2
  kbd-state: register sdl2 hotkeys
  sdl2: use only QKeyCode in sdl2_process_key()

 include/ui/kbd-state.h |  49 ++++++++++++++++
 include/ui/sdl2.h      |   2 +
 ui/kbd-state.c         | 152 +++++++++++++++++++++++++++++++++++++++++++++++++
 ui/sdl2-input.c        |  54 ++----------------
 ui/sdl2.c              | 114 ++++++++++++++++++++-----------------
 ui/Makefile.objs       |   2 +-
 6 files changed, 270 insertions(+), 103 deletions(-)
 create mode 100644 include/ui/kbd-state.h
 create mode 100644 ui/kbd-state.c

-- 
2.9.3

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20180221170820.15365-1-kraxel@redhat.com
Subject: [Qemu-devel] [RFC PATCH 0/5] ui: add keyboard state and hotkey tracker

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/20180220225904.16129-1-bsd@redhat.com -> patchew/20180220225904.16129-1-bsd@redhat.com
 * [new tag]               patchew/cover.1519036465.git.balaton@eik.bme.hu -> patchew/cover.1519036465.git.balaton@eik.bme.hu
Switched to a new branch 'test'
9065fbc367 sdl2: use only QKeyCode in sdl2_process_key()
0c65c8c6bb kbd-state: register sdl2 hotkeys
67a2d8cd4a kbd-state: use state tracker for sdl2
a389e7e994 kbd-state: add hotkey registry
d14a0b4fd8 kbd-state: add keyboard state tracker

=== OUTPUT BEGIN ===
Checking PATCH 1/5: kbd-state: add keyboard state tracker...
ERROR: space required after that ',' (ctx:BxV)
#86: FILE: ui/kbd-state.c:22:
+    QTAILQ_HEAD(,KbdHotkey) hotkeys;
                 ^

total: 1 errors, 0 warnings, 149 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/5: kbd-state: add hotkey registry...
Checking PATCH 3/5: kbd-state: use state tracker for sdl2...
Checking PATCH 4/5: kbd-state: register sdl2 hotkeys...
Checking PATCH 5/5: sdl2: use only QKeyCode in sdl2_process_key()...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org