[Qemu-devel] [PATCH v2] docs: pcie: Spell out machine type needs for PCIe features

Kashyap Chamarthy posted 1 patch 7 years, 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180219163131.31153-1-kchamart@redhat.com
Test checkpatch passed
Test docker-build@min-glib passed
Test docker-mingw@fedora passed
Test docker-quick@centos6 passed
Test ppcbe passed
Test ppcle passed
Test s390x failed
docs/pcie.txt | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
[Qemu-devel] [PATCH v2] docs: pcie: Spell out machine type needs for PCIe features
Posted by Kashyap Chamarthy 7 years, 8 months ago
PCIe features are available only via the 'q35' machine type for x86 and
the 'virt' machine type for AArch64 architecture.

Mention that explicitly.

Thanks: Daniel Berrangé

Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com>
---
 docs/pcie.txt | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/docs/pcie.txt b/docs/pcie.txt
index 8d3694970e..89e3502075 100644
--- a/docs/pcie.txt
+++ b/docs/pcie.txt
@@ -3,8 +3,13 @@ PCI EXPRESS GUIDELINES
 
 1. Introduction
 ================
-The doc proposes best practices on how to use PCI Express/PCI device
-in PCI Express based machines and explains the reasoning behind them.
+The doc proposes best practices on how to use PCI Express (PCIe) / PCI
+devices in PCI Express based machines and explains the reasoning behind
+them.
+
+Note that the PCIe features are available only when using the 'q35'
+machine type on x86 architecture and the 'virt' machine type on AArch64.
+Other machine types do not use PCIe at this time.
 
 The following presentations accompany this document:
  (1) Q35 overview.
-- 
2.13.6


Re: [Qemu-devel] [PATCH v2] docs: pcie: Spell out machine type needs for PCIe features
Posted by Daniel P. Berrangé 7 years, 8 months ago
On Mon, Feb 19, 2018 at 05:31:31PM +0100, Kashyap Chamarthy wrote:
> PCIe features are available only via the 'q35' machine type for x86 and
> the 'virt' machine type for AArch64 architecture.
> 
> Mention that explicitly.
> 
> Thanks: Daniel Berrangé
> 
> Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com>
> ---
>  docs/pcie.txt | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/docs/pcie.txt b/docs/pcie.txt
> index 8d3694970e..89e3502075 100644
> --- a/docs/pcie.txt
> +++ b/docs/pcie.txt
> @@ -3,8 +3,13 @@ PCI EXPRESS GUIDELINES
>  
>  1. Introduction
>  ================
> -The doc proposes best practices on how to use PCI Express/PCI device
> -in PCI Express based machines and explains the reasoning behind them.
> +The doc proposes best practices on how to use PCI Express (PCIe) / PCI
> +devices in PCI Express based machines and explains the reasoning behind
> +them.
> +
> +Note that the PCIe features are available only when using the 'q35'
> +machine type on x86 architecture and the 'virt' machine type on AArch64.
> +Other machine types do not use PCIe at this time.
>  
>  The following presentations accompany this document:
>   (1) Q35 overview.

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [Qemu-devel] [PATCH v2] docs: pcie: Spell out machine type needs for PCIe features
Posted by Marcel Apfelbaum 7 years, 8 months ago
On 19/02/2018 18:31, Kashyap Chamarthy wrote:
> PCIe features are available only via the 'q35' machine type for x86 and
> the 'virt' machine type for AArch64 architecture.
> 
> Mention that explicitly.

Thanks for the improvement

Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>

Thanks,
Marcel

> 
> Thanks: Daniel Berrangé
> 
> Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com>
> ---
>  docs/pcie.txt | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/docs/pcie.txt b/docs/pcie.txt
> index 8d3694970e..89e3502075 100644
> --- a/docs/pcie.txt
> +++ b/docs/pcie.txt
> @@ -3,8 +3,13 @@ PCI EXPRESS GUIDELINES
>  
>  1. Introduction
>  ================
> -The doc proposes best practices on how to use PCI Express/PCI device
> -in PCI Express based machines and explains the reasoning behind them.
> +The doc proposes best practices on how to use PCI Express (PCIe) / PCI
> +devices in PCI Express based machines and explains the reasoning behind
> +them.
> +
> +Note that the PCIe features are available only when using the 'q35'
> +machine type on x86 architecture and the 'virt' machine type on AArch64.
> +Other machine types do not use PCIe at this time.
>  
>  The following presentations accompany this document:
>   (1) Q35 overview.
>