[Qemu-devel] [PATCH 4/5] tricore: fixed wrong mask of PCXI_PIE

David Brenken posted 5 patches 7 years, 8 months ago
There is a newer version of this series
[Qemu-devel] [PATCH 4/5] tricore: fixed wrong mask of PCXI_PIE
Posted by David Brenken 7 years, 8 months ago
From: David Brenken <david.brenken@efs-auto.de>

Signed-off-by: David Brenken <david.brenken@efs-auto.de>
Signed-off-by: Georg Hofstetter <georg.hofstetter@efs-auto.de>
Signed-off-by: Florian Artmeier <florian.artmeier@efs-auto.de>
---
 target/tricore/cpu.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/tricore/cpu.h b/target/tricore/cpu.h
index 6ed474c..3f8c029 100644
--- a/target/tricore/cpu.h
+++ b/target/tricore/cpu.h
@@ -230,7 +230,7 @@ void tricore_cpu_dump_state(CPUState *cpu, FILE *f,
 
 
 #define MASK_PCXI_PCPN 0xff000000
-#define MASK_PCXI_PIE  0x00800000
+#define MASK_PCXI_PIE  0x00200000
 #define MASK_PCXI_UL   0x00400000
 #define MASK_PCXI_PCXS 0x000f0000
 #define MASK_PCXI_PCXO 0x0000ffff
-- 
2.7.4


Re: [Qemu-devel] [PATCH 4/5] tricore: fixed wrong mask of PCXI_PIE
Posted by Bastian Koppelmann 7 years, 8 months ago
On 02/19/2018 07:18 AM, David Brenken wrote:
> From: David Brenken <david.brenken@efs-auto.de>
> 
> Signed-off-by: David Brenken <david.brenken@efs-auto.de>
> Signed-off-by: Georg Hofstetter <georg.hofstetter@efs-auto.de>
> Signed-off-by: Florian Artmeier <florian.artmeier@efs-auto.de>
> ---
>  target/tricore/cpu.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/tricore/cpu.h b/target/tricore/cpu.h
> index 6ed474c..3f8c029 100644
> --- a/target/tricore/cpu.h
> +++ b/target/tricore/cpu.h
> @@ -230,7 +230,7 @@ void tricore_cpu_dump_state(CPUState *cpu, FILE *f,
>  
>  
>  #define MASK_PCXI_PCPN 0xff000000
> -#define MASK_PCXI_PIE  0x00800000
> +#define MASK_PCXI_PIE  0x00200000
>  #define MASK_PCXI_UL   0x00400000
>  #define MASK_PCXI_PCXS 0x000f0000
>  #define MASK_PCXI_PCXO 0x0000ffff
> 

This is the same architecture problem as in patch 03/05.
Also, please squash patch 04 and 05 together.

Cheer,
Bastian