[Qemu-devel] [PATCH 0/5] tricore: added small features + fixed wrong masks

David Brenken posted 5 patches 7 years, 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180219061827.2112-1-david.brenken@efs-auto.org
Test checkpatch passed
Test docker-build@min-glib passed
Test docker-mingw@fedora passed
Test docker-quick@centos6 passed
Test ppcbe passed
Test ppcle passed
Test s390x failed
There is a newer version of this series
target/tricore/cpu.h             |  5 +++--
target/tricore/csfr.def          |  1 +
target/tricore/op_helper.c       |  3 ++-
target/tricore/translate.c       | 22 ++++++++++++++++++++++
target/tricore/tricore-opcodes.h |  4 ++++
5 files changed, 32 insertions(+), 3 deletions(-)
[Qemu-devel] [PATCH 0/5] tricore: added small features + fixed wrong masks
Posted by David Brenken 7 years, 8 months ago
From: David Brenken <david.brenken@efs-auto.de>

Hello,

this is my first commit of a patch set for QEMU. 

This patch series contains a few updates for the target tricore:
- adding a few additional, previously missing cpu instructions
- adding CORE_ID
- fixing some masks
- fixing a wrong shift (context PCXI PIE)


David Brenken (5):
  tricore: added some missing cpu instructions
  tricore: added CORE_ID
  tricore: fixed wrong masking of IE
  tricore: fixed wrong mask of PCXI_PIE
  tricore: fixed wrong shifting of PCXI PIE

 target/tricore/cpu.h             |  5 +++--
 target/tricore/csfr.def          |  1 +
 target/tricore/op_helper.c       |  3 ++-
 target/tricore/translate.c       | 22 ++++++++++++++++++++++
 target/tricore/tricore-opcodes.h |  4 ++++
 5 files changed, 32 insertions(+), 3 deletions(-)

-- 
2.7.4


Re: [Qemu-devel] [PATCH 0/5] tricore: added small features + fixed wrong masks
Posted by Bastian Koppelmann 7 years, 8 months ago
Hi David,

On 02/19/2018 07:18 AM, David Brenken wrote:
> From: David Brenken <david.brenken@efs-auto.de>
> 
> Hello,
> 
> this is my first commit of a patch set for QEMU. 

welcome aboard and thanks for your first patchset. So far it looks good
to me and I will definitively accept it. However, I still have some
comments regarding some of the patches, which you need to address. I in
lined the comments into the mail containing the patch.

Cheers,
Bastian