[v3] SDHCI: convert legacy devices to the SDBus API (part 6)

[Qemu-devel] [PATCH v3 0/7] SDHCI: convert legacy devices to the SDBus API (part 6)

Philippe Mathieu-Daudé posted 7 patches 7 years, 8 months ago

Diff against v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180216022933.10945-1-f4bug@amsat.org

Test checkpatch passed

Test docker-build@min-glib passed

Test docker-mingw@fedora passed

Test docker-quick@centos6 passed

Test ppcbe passed

Test ppcle passed

Test s390x passed

include/hw/sd/sd.h            | 17 ---------
include/hw/sd/sdcard_legacy.h | 50 ++++++++++++++++++++++++++
hw/sd/milkymist-memcard.c     | 81 ++++++++++++++++++++++++-------------------
hw/sd/omap_mmc.c              |  2 +-
hw/sd/pl181.c                 | 59 +++++++++++++++++++++++--------
hw/sd/sd.c                    |  3 +-
hw/sd/ssi-sd.c                | 32 ++++++++++-------
7 files changed, 162 insertions(+), 82 deletions(-)
create mode 100644 include/hw/sd/sdcard_legacy.h

Expand all Fold all

[Qemu-devel] [PATCH v3 0/7] SDHCI: convert legacy devices to the SDBus API (part 6)

Posted by Philippe Mathieu-Daudé 7 years, 8 months ago

Hi,

Since v2:
- pl181: remove legacy sd_set_cb() (Peter)

Since v1:
- rebased on /master (Peter sdcard reset() patches)
- fix milkymist-mmc from previous seris using instance_init (Michael Walle)

This series convert 3 devices using the legacy SDCard API to the SDBus API:
- milkymist-mmc
- pl181
- ssi-sd

Then move the legacy API to a separate header "sdcard_legacy.h".

Now the OMAP MMC is the last device using the legacy API, but need to get
QOM'ified first.

Having a common sdbus interface simplify qtesting (next series)

This series is not related to the previous set (4/5) and can be applied
independently.

Regards,

Phil.

$ git backport-diff
001/7:[----] [--] 'hw/sd/milkymist-memcard: use qemu_log_mask()'
002/7:[----] [--] 'hw/sd/milkymist-memcard: split realize() out of SysBusDevice init()'
003/7:[----] [--] 'hw/sd/milkymist-memcard: expose a SDBus and connect the SDCard to it'
004/7:[----] [--] 'hw/sd/ssi-sd: use the SDBus API, connect the SDCard to the bus'
005/7:[0034] [FC] 'hw/sd/pl181: expose a SDBus and connect the SDCard to it'
006/7:[down] 'hw/sd: make sd_data_ready() static'
007/7:[0003] [FC] 'hw/sd: move sdcard legacy API to "hw/sd/sdcard_legacy.h"'

Philippe Mathieu-Daudé (7):
  hw/sd/milkymist-memcard: use qemu_log_mask()
  hw/sd/milkymist-memcard: split realize() out of SysBusDevice init()
  hw/sd/milkymist-memcard: expose a SDBus and connect the SDCard to it
  hw/sd/ssi-sd: use the SDBus API, connect the SDCard to the bus
  hw/sd/pl181: expose a SDBus and connect the SDCard to it
  hw/sd: make sd_data_ready() static
  hw/sd: move sdcard legacy API to "hw/sd/sdcard_legacy.h"

 include/hw/sd/sd.h            | 17 ---------
 include/hw/sd/sdcard_legacy.h | 50 ++++++++++++++++++++++++++
 hw/sd/milkymist-memcard.c     | 81 ++++++++++++++++++++++++-------------------
 hw/sd/omap_mmc.c              |  2 +-
 hw/sd/pl181.c                 | 59 +++++++++++++++++++++++--------
 hw/sd/sd.c                    |  3 +-
 hw/sd/ssi-sd.c                | 32 ++++++++++-------
 7 files changed, 162 insertions(+), 82 deletions(-)
 create mode 100644 include/hw/sd/sdcard_legacy.h

-- 
2.16.1

Re: [Qemu-devel] [PATCH v3 0/7] SDHCI: convert legacy devices to the SDBus API (part 6)

Posted by Peter Maydell 7 years, 8 months ago

On 16 February 2018 at 02:29, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> Hi,
>
> Since v2:
> - pl181: remove legacy sd_set_cb() (Peter)
>
> Since v1:
> - rebased on /master (Peter sdcard reset() patches)
> - fix milkymist-mmc from previous seris using instance_init (Michael Walle)
>
> This series convert 3 devices using the legacy SDCard API to the SDBus API:
> - milkymist-mmc
> - pl181
> - ssi-sd
>
> Then move the legacy API to a separate header "sdcard_legacy.h".
>
> Now the OMAP MMC is the last device using the legacy API, but need to get
> QOM'ified first.
>
> Having a common sdbus interface simplify qtesting (next series)
>
> This series is not related to the previous set (4/5) and can be applied
> independently.
>
> Regards,
>
> Phil.
>
> $ git backport-diff
> 001/7:[----] [--] 'hw/sd/milkymist-memcard: use qemu_log_mask()'
> 002/7:[----] [--] 'hw/sd/milkymist-memcard: split realize() out of SysBusDevice init()'
> 003/7:[----] [--] 'hw/sd/milkymist-memcard: expose a SDBus and connect the SDCard to it'
> 004/7:[----] [--] 'hw/sd/ssi-sd: use the SDBus API, connect the SDCard to the bus'
> 005/7:[0034] [FC] 'hw/sd/pl181: expose a SDBus and connect the SDCard to it'
> 006/7:[down] 'hw/sd: make sd_data_ready() static'
> 007/7:[0003] [FC] 'hw/sd: move sdcard legacy API to "hw/sd/sdcard_legacy.h"'

I've applied patches 1-4 to target-arm.next; I had a review comment on 5
and 6,7 depend on that one.

thanks
-- PMM