[Qemu-devel] [PULL 4/7] io: Don't call close multiple times in QIOChannelFile

Daniel P. Berrangé posted 7 patches 7 years, 8 months ago
There is a newer version of this series
[Qemu-devel] [PULL 4/7] io: Don't call close multiple times in QIOChannelFile
Posted by Daniel P. Berrangé 7 years, 8 months ago
From: Ross Lagerwall <ross.lagerwall@citrix.com>

If the file descriptor underlying QIOChannelFile is closed in the
io_close() method, don't close it again in the finalize() method since
the file descriptor number may have been reused in the meantime.

Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
 io/channel-file.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/io/channel-file.c b/io/channel-file.c
index 16bf7ed270..1f2f710bf9 100644
--- a/io/channel-file.c
+++ b/io/channel-file.c
@@ -178,6 +178,7 @@ static int qio_channel_file_close(QIOChannel *ioc,
                          "Unable to close file");
         return -1;
     }
+    fioc->fd = -1;
     return 0;
 }
 
-- 
2.14.3