[PATCH 13/30] hw/xtensa: use the BYTE-based definitions

Philippe Mathieu-Daudé posted 30 patches 7 years, 8 months ago
There is a newer version of this series
[PATCH 13/30] hw/xtensa: use the BYTE-based definitions
Posted by Philippe Mathieu-Daudé 7 years, 8 months ago
It ease code review, unit is explicit.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 hw/xtensa/xtfpga.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/xtensa/xtfpga.c b/hw/xtensa/xtfpga.c
index 70686a2eb1..922417af15 100644
--- a/hw/xtensa/xtfpga.c
+++ b/hw/xtensa/xtfpga.c
@@ -230,7 +230,7 @@ static void xtfpga_init(const XtfpgaBoardDesc *board, MachineState *machine)
     const char *kernel_cmdline = qemu_opt_get(machine_opts, "append");
     const char *dtb_filename = qemu_opt_get(machine_opts, "dtb");
     const char *initrd_filename = qemu_opt_get(machine_opts, "initrd");
-    const unsigned system_io_size = 224 * 1024 * 1024;
+    const unsigned system_io_size = 224 * M_BYTE;
     int n;
 
     for (n = 0; n < smp_cpus; n++) {
-- 
2.16.1

Re: [Qemu-devel] [PATCH 13/30] hw/xtensa: use the BYTE-based definitions
Posted by Max Filippov 7 years, 8 months ago
On Wed, Feb 14, 2018 at 8:28 PM, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> It ease code review, unit is explicit.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  hw/xtensa/xtfpga.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Max Filippov <jcmvbkbc@gmail.com>

Michael, could you please take it into the qemu-trivial?

-- 
Thanks.
-- Max