[Qemu-devel] [QEMU-PPC] [PATCH V5 0/7] target/ppc: Rework spapr_caps

Suraj Jitindar Singh posted 7 patches 6 years, 3 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180119050005.29392-1-sjitindarsingh@gmail.com
Test checkpatch failed
Test docker-build@min-glib passed
Test docker-mingw@fedora passed
Test docker-quick@centos6 passed
Test ppc passed
Test s390x passed
hw/ppc/spapr.c                  |   6 ++
hw/ppc/spapr_caps.c             | 202 +++++++++++++++++++++++++++++-----------
hw/ppc/spapr_hcall.c            |  58 ++++++++++++
include/hw/ppc/spapr.h          |  28 +++++-
linux-headers/asm-powerpc/kvm.h |   8 ++
linux-headers/linux/kvm.h       |   3 +
target/ppc/kvm.c                |  58 ++++++++++++
target/ppc/kvm_ppc.h            |  18 ++++
8 files changed, 326 insertions(+), 55 deletions(-)
[Qemu-devel] [QEMU-PPC] [PATCH V5 0/7] target/ppc: Rework spapr_caps
Posted by Suraj Jitindar Singh 6 years, 3 months ago
The following patch series adds 3 new tristate capabilities and their
associated handling.

A new H-Call is implemented which a guest will use to query the 
requirement for and availability of workarounds for certain cpu 
behaviours.

Applies on top of David's tree: ppc-for-2.12

The main changes to V5 are:
- Add patch 2/7 to series to introduce macros to generate migration fields
- Fix bisect breakage in 3/7 due to unused function
- Use assert in 7/7 for invalid cap values

Suraj Jitindar Singh (7):
  target/ppc/kvm: Add cap_ppc_safe_[cache/bounds_check/indirect_branch]
  target/ppc/spapr_caps: Add macro to generate spapr_caps migration
    vmstate
  target/ppc/spapr_caps: Add support for tristate spapr_capabilities
  target/ppc/spapr_caps: Add new tristate cap safe_cache
  target/ppc/spapr_caps: Add new tristate cap safe_bounds_check
  target/ppc/spapr_caps: Add new tristate cap safe_indirect_branch
  target/ppc/spapr: Add H-Call H_GET_CPU_CHARACTERISTICS

 hw/ppc/spapr.c                  |   6 ++
 hw/ppc/spapr_caps.c             | 202 +++++++++++++++++++++++++++++-----------
 hw/ppc/spapr_hcall.c            |  58 ++++++++++++
 include/hw/ppc/spapr.h          |  28 +++++-
 linux-headers/asm-powerpc/kvm.h |   8 ++
 linux-headers/linux/kvm.h       |   3 +
 target/ppc/kvm.c                |  58 ++++++++++++
 target/ppc/kvm_ppc.h            |  18 ++++
 8 files changed, 326 insertions(+), 55 deletions(-)

-- 
2.13.6


Re: [Qemu-devel] [QEMU-PPC] [PATCH V5 0/7] target/ppc: Rework spapr_caps
Posted by no-reply@patchew.org 6 years, 3 months ago
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20180119050005.29392-1-sjitindarsingh@gmail.com
Subject: [Qemu-devel] [QEMU-PPC] [PATCH V5 0/7] target/ppc: Rework spapr_caps

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
dc317bcbc5 target/ppc/spapr: Add H-Call H_GET_CPU_CHARACTERISTICS
09c0dbcab4 target/ppc/spapr_caps: Add new tristate cap safe_indirect_branch
1145f7696a target/ppc/spapr_caps: Add new tristate cap safe_bounds_check
37c3445619 target/ppc/spapr_caps: Add new tristate cap safe_cache
0a8ff160dc target/ppc/spapr_caps: Add support for tristate spapr_capabilities
8aef783b9e target/ppc/spapr_caps: Add macro to generate spapr_caps migration vmstate
09ad7f2093 target/ppc/kvm: Add cap_ppc_safe_[cache/bounds_check/indirect_branch]

=== OUTPUT BEGIN ===
Checking PATCH 1/7: target/ppc/kvm: Add cap_ppc_safe_[cache/bounds_check/indirect_branch]...
Checking PATCH 2/7: target/ppc/spapr_caps: Add macro to generate spapr_caps migration vmstate...
Checking PATCH 3/7: target/ppc/spapr_caps: Add support for tristate spapr_capabilities...
Checking PATCH 4/7: target/ppc/spapr_caps: Add new tristate cap safe_cache...
ERROR: line over 90 characters
#75: FILE: hw/ppc/spapr_caps.c:188:
+        error_setg(errp, "Requested safe cache capability level not supported by tcg, try a different value for cap-cfpc");

ERROR: line over 90 characters
#77: FILE: hw/ppc/spapr_caps.c:190:
+        error_setg(errp, "Requested safe cache capability level not supported by kvm, try a different value for cap-cfpc");

total: 2 errors, 0 warnings, 98 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/7: target/ppc/spapr_caps: Add new tristate cap safe_bounds_check...
ERROR: line over 90 characters
#47: FILE: hw/ppc/spapr_caps.c:199:
+        error_setg(errp, "Requested safe bounds check capability level not supported by tcg, try a different value for cap-sbbc");

ERROR: line over 90 characters
#49: FILE: hw/ppc/spapr_caps.c:201:
+        error_setg(errp, "Requested safe bounds check capability level not supported by kvm, try a different value for cap-sbbc");

WARNING: line over 80 characters
#62: FILE: hw/ppc/spapr_caps.c:246:
+        .description = "Speculation Barrier Bounds Checking" VALUE_DESC_TRISTATE,

total: 2 errors, 1 warnings, 71 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 6/7: target/ppc/spapr_caps: Add new tristate cap safe_indirect_branch...
ERROR: line over 90 characters
#48: FILE: hw/ppc/spapr_caps.c:210:
+        error_setg(errp, "Requested safe indirect branch capability level not supported by tcg, try a different value for cap-ibs");

ERROR: line over 90 characters
#50: FILE: hw/ppc/spapr_caps.c:212:
+        error_setg(errp, "Requested safe indirect branch capability level not supported by kvm, try a different value for cap-ibs");

total: 2 errors, 0 warnings, 71 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 7/7: target/ppc/spapr: Add H-Call H_GET_CPU_CHARACTERISTICS...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
Re: [Qemu-devel] [QEMU-PPC] [PATCH V5 0/7] target/ppc: Rework spapr_caps
Posted by David Gibson 6 years, 2 months ago
On Fri, Jan 19, 2018 at 03:59:58PM +1100, Suraj Jitindar Singh wrote:
> The following patch series adds 3 new tristate capabilities and their
> associated handling.
> 
> A new H-Call is implemented which a guest will use to query the 
> requirement for and availability of workarounds for certain cpu 
> behaviours.
> 
> Applies on top of David's tree: ppc-for-2.12

Applied to ppc-for-2.12 (except that the kernel header updates from
1/7 were dropped, since they were already included by Cornelia's
general update in 9cbb6362.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson