sm501: Add missing break to case

[Qemu-devel] [PATCH] sm501: Add missing break to case

BALATON Zoltan posted 1 patch 7 years, 9 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180119014313.445517456CD@zero.eik.bme.hu

Test checkpatch passed

Test docker-build@min-glib passed

Test docker-mingw@fedora passed

Test docker-quick@centos6 passed

Test ppc passed

Test s390x passed

hw/display/sm501.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[Qemu-devel] [PATCH] sm501: Add missing break to case

Posted by BALATON Zoltan 7 years, 9 months ago

Noticed by Coverity, forgotten in 5690d9ece

Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
 hw/display/sm501.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/display/sm501.c b/hw/display/sm501.c
index 4f7dc59b2..134cbed 100644
--- a/hw/display/sm501.c
+++ b/hw/display/sm501.c
@@ -797,6 +797,7 @@ static uint64_t sm501_system_config_read(void *opaque, hwaddr addr,
         break;
     case SM501_COMMAND_LIST_STATUS:
         ret = 0x00180002; /* FIFOs are empty, everything idle */
+        break;
     case SM501_IRQ_MASK:
         ret = s->irq_mask;
         break;
-- 
2.7.6

Re: [Qemu-devel] [PATCH] sm501: Add missing break to case

Posted by David Gibson 7 years, 9 months ago

On Thu, Jan 18, 2018 at 07:01:19PM +0100, BALATON Zoltan wrote:
> Noticed by Coverity, forgotten in 5690d9ece
> 
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>

Applied to ppc-for-2.12, thanks.

> ---
>  hw/display/sm501.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/display/sm501.c b/hw/display/sm501.c
> index 4f7dc59b2..134cbed 100644
> --- a/hw/display/sm501.c
> +++ b/hw/display/sm501.c
> @@ -797,6 +797,7 @@ static uint64_t sm501_system_config_read(void *opaque, hwaddr addr,
>          break;
>      case SM501_COMMAND_LIST_STATUS:
>          ret = 0x00180002; /* FIFOs are empty, everything idle */
> +        break;
>      case SM501_IRQ_MASK:
>          ret = s->irq_mask;
>          break;

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson