We want to provide more hw features to guests, namely the new bpb
control as well as other transparent facilities that might be
introduced by firmware updates (e.g. the stfle facility 81).

See the kernel discussion for the KVM side
https://www.spinics.net/lists/kernel/msg2700551.html

Christian Borntraeger (2):
  header sync
  s390x/kvm: Handle bpb feature

Halil Pasic (1):
  s390x/cpumodel: fix transparency for non-hyp STFL features

 linux-headers/asm-s390/kvm.h    |   9 ++--
 linux-headers/linux/kvm.h       |   5 +-
 target/s390x/cpu.c              |   1 +
 target/s390x/cpu.h              |   1 +
 target/s390x/cpu_features.c     |  55 +++++++++++++++++++++
 target/s390x/cpu_features_def.h |  55 +++++++++++++++++++++
 target/s390x/gen-features.c     | 104 ++++++++++++++++++++++++++++++++++++++++
 target/s390x/kvm.c              |  16 +++++++
 target/s390x/machine.c          |  17 +++++++
 9 files changed, 256 insertions(+), 7 deletions(-)

-- 
2.9.4

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20180117141849.65757-1-borntraeger@de.ibm.com
Subject: [Qemu-devel] [PATCH/RFC 0/3] s390x/kvm: implement new hardware/firmware features

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20180117114430.19110-1-marcandre.lureau@redhat.com -> patchew/20180117114430.19110-1-marcandre.lureau@redhat.com
 t [tag update]            patchew/20180117135015.15051-1-mreitz@redhat.com -> patchew/20180117135015.15051-1-mreitz@redhat.com
 * [new tag]               patchew/20180117141849.65757-1-borntraeger@de.ibm.com -> patchew/20180117141849.65757-1-borntraeger@de.ibm.com
Switched to a new branch 'test'
1c939adbf1 s390x/cpumodel: fix transparency for non-hyp STFL features
ff8e68c658 s390x/kvm: Handle bpb feature
aceb38e1c3 header sync

=== OUTPUT BEGIN ===
Checking PATCH 1/3: header sync...
Checking PATCH 2/3: s390x/kvm: Handle bpb feature...
ERROR: suspect code indent for conditional statements (4, 7)
#82: FILE: target/s390x/kvm.c:493:
+    if (can_sync_regs(cs, KVM_SYNC_BPBC)) {
+       cs->kvm_run->s.regs.bpbc = env->bpbc;

ERROR: suspect code indent for conditional statements (4, 7)
#94: FILE: target/s390x/kvm.c:608:
+    if (can_sync_regs(cs, KVM_SYNC_BPBC)) {
+       env->bpbc = cs->kvm_run->s.regs.bpbc;

total: 2 errors, 0 warnings, 98 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/3: s390x/cpumodel: fix transparency for non-hyp STFL features...
ERROR: line over 90 characters
#49: FILE: target/s390x/cpu_features.c:54:
+    FEAT_INIT("stfle29", S390_FEAT_TYPE_STFL, 29, "Facility that is provided by STFLE facility 29"),

ERROR: line over 90 characters
#57: FILE: target/s390x/cpu_features.c:64:
+    FEAT_INIT("stfle39", S390_FEAT_TYPE_STFL, 39, "Facility that is provided by STFLE facility 39"),

ERROR: line over 90 characters
#64: FILE: target/s390x/cpu_features.c:71:
+    FEAT_INIT("stfle46", S390_FEAT_TYPE_STFL, 46, "Facility that is provided by STFLE facility 46"),

ERROR: line over 90 characters
#72: FILE: target/s390x/cpu_features.c:80:
+    FEAT_INIT("stfle55", S390_FEAT_TYPE_STFL, 55, "Facility that is provided by STFLE facility 55"),

ERROR: line over 90 characters
#73: FILE: target/s390x/cpu_features.c:81:
+    FEAT_INIT("stfle56", S390_FEAT_TYPE_STFL, 56, "Facility that is provided by STFLE facility 56"),

ERROR: line over 90 characters
#78: FILE: target/s390x/cpu_features.c:86:
+    FEAT_INIT("stfle61", S390_FEAT_TYPE_STFL, 61, "Facility that is provided by STFLE facility 61"),

ERROR: line over 90 characters
#79: FILE: target/s390x/cpu_features.c:87:
+    FEAT_INIT("stfle62", S390_FEAT_TYPE_STFL, 62, "Facility that is provided by STFLE facility 62"),

ERROR: line over 90 characters
#80: FILE: target/s390x/cpu_features.c:88:
+    FEAT_INIT("stfle63", S390_FEAT_TYPE_STFL, 63, "Facility that is provided by STFLE facility 63"),

ERROR: line over 90 characters
#88: FILE: target/s390x/cpu_features.c:100:
+    FEAT_INIT("stfle81", S390_FEAT_TYPE_STFL, 81, "Facility that is provided by STFLE facility 81"),

ERROR: line over 90 characters
#90: FILE: target/s390x/cpu_features.c:102:
+    FEAT_INIT("stfle83", S390_FEAT_TYPE_STFL, 83, "Facility that is provided by STFLE facility 83"),

ERROR: line over 90 characters
#91: FILE: target/s390x/cpu_features.c:103:
+    FEAT_INIT("stfle84", S390_FEAT_TYPE_STFL, 84, "Facility that is provided by STFLE facility 84"),

ERROR: line over 90 characters
#92: FILE: target/s390x/cpu_features.c:104:
+    FEAT_INIT("stfle85", S390_FEAT_TYPE_STFL, 85, "Facility that is provided by STFLE facility 85"),

ERROR: line over 90 characters
#93: FILE: target/s390x/cpu_features.c:105:
+    FEAT_INIT("stfle86", S390_FEAT_TYPE_STFL, 86, "Facility that is provided by STFLE facility 86"),

ERROR: line over 90 characters
#94: FILE: target/s390x/cpu_features.c:106:
+    FEAT_INIT("stfle87", S390_FEAT_TYPE_STFL, 87, "Facility that is provided by STFLE facility 87"),

ERROR: line over 90 characters
#95: FILE: target/s390x/cpu_features.c:107:
+    FEAT_INIT("stfle88", S390_FEAT_TYPE_STFL, 88, "Facility that is provided by STFLE facility 88"),

ERROR: line over 90 characters
#96: FILE: target/s390x/cpu_features.c:108:
+    FEAT_INIT("stfle89", S390_FEAT_TYPE_STFL, 89, "Facility that is provided by STFLE facility 89"),

ERROR: line over 90 characters
#97: FILE: target/s390x/cpu_features.c:109:
+    FEAT_INIT("stfle90", S390_FEAT_TYPE_STFL, 90, "Facility that is provided by STFLE facility 90"),

ERROR: line over 90 characters
#98: FILE: target/s390x/cpu_features.c:110:
+    FEAT_INIT("stfle91", S390_FEAT_TYPE_STFL, 91, "Facility that is provided by STFLE facility 91"),

ERROR: line over 90 characters
#99: FILE: target/s390x/cpu_features.c:111:
+    FEAT_INIT("stfle92", S390_FEAT_TYPE_STFL, 92, "Facility that is provided by STFLE facility 92"),

ERROR: line over 90 characters
#100: FILE: target/s390x/cpu_features.c:112:
+    FEAT_INIT("stfle93", S390_FEAT_TYPE_STFL, 93, "Facility that is provided by STFLE facility 93"),

ERROR: line over 90 characters
#101: FILE: target/s390x/cpu_features.c:113:
+    FEAT_INIT("stfle94", S390_FEAT_TYPE_STFL, 94, "Facility that is provided by STFLE facility 94"),

ERROR: line over 90 characters
#102: FILE: target/s390x/cpu_features.c:114:
+    FEAT_INIT("stfle95", S390_FEAT_TYPE_STFL, 95, "Facility that is provided by STFLE facility 95"),

ERROR: line over 90 characters
#103: FILE: target/s390x/cpu_features.c:115:
+    FEAT_INIT("stfle96", S390_FEAT_TYPE_STFL, 96, "Facility that is provided by STFLE facility 96"),

ERROR: line over 90 characters
#104: FILE: target/s390x/cpu_features.c:116:
+    FEAT_INIT("stfle97", S390_FEAT_TYPE_STFL, 97, "Facility that is provided by STFLE facility 97"),

ERROR: line over 90 characters
#105: FILE: target/s390x/cpu_features.c:117:
+    FEAT_INIT("stfle98", S390_FEAT_TYPE_STFL, 98, "Facility that is provided by STFLE facility 98"),

ERROR: line over 90 characters
#106: FILE: target/s390x/cpu_features.c:118:
+    FEAT_INIT("stfle99", S390_FEAT_TYPE_STFL, 99, "Facility that is provided by STFLE facility 99"),

ERROR: line over 90 characters
#107: FILE: target/s390x/cpu_features.c:119:
+    FEAT_INIT("stfle100", S390_FEAT_TYPE_STFL, 100, "Facility that is provided by STFLE facility 100"),

ERROR: line over 90 characters
#108: FILE: target/s390x/cpu_features.c:120:
+    FEAT_INIT("stfle101", S390_FEAT_TYPE_STFL, 101, "Facility that is provided by STFLE facility 101"),

ERROR: line over 90 characters
#109: FILE: target/s390x/cpu_features.c:121:
+    FEAT_INIT("stfle102", S390_FEAT_TYPE_STFL, 102, "Facility that is provided by STFLE facility 102"),

ERROR: line over 90 characters
#110: FILE: target/s390x/cpu_features.c:122:
+    FEAT_INIT("stfle103", S390_FEAT_TYPE_STFL, 103, "Facility that is provided by STFLE facility 103"),

ERROR: line over 90 characters
#111: FILE: target/s390x/cpu_features.c:123:
+    FEAT_INIT("stfle104", S390_FEAT_TYPE_STFL, 104, "Facility that is provided by STFLE facility 104"),

ERROR: line over 90 characters
#112: FILE: target/s390x/cpu_features.c:124:
+    FEAT_INIT("stfle105", S390_FEAT_TYPE_STFL, 105, "Facility that is provided by STFLE facility 105"),

ERROR: line over 90 characters
#113: FILE: target/s390x/cpu_features.c:125:
+    FEAT_INIT("stfle106", S390_FEAT_TYPE_STFL, 106, "Facility that is provided by STFLE facility 106"),

ERROR: line over 90 characters
#114: FILE: target/s390x/cpu_features.c:126:
+    FEAT_INIT("stfle107", S390_FEAT_TYPE_STFL, 107, "Facility that is provided by STFLE facility 107"),

ERROR: line over 90 characters
#115: FILE: target/s390x/cpu_features.c:127:
+    FEAT_INIT("stfle108", S390_FEAT_TYPE_STFL, 108, "Facility that is provided by STFLE facility 108"),

ERROR: line over 90 characters
#116: FILE: target/s390x/cpu_features.c:128:
+    FEAT_INIT("stfle109", S390_FEAT_TYPE_STFL, 109, "Facility that is provided by STFLE facility 109"),

ERROR: line over 90 characters
#117: FILE: target/s390x/cpu_features.c:129:
+    FEAT_INIT("stfle110", S390_FEAT_TYPE_STFL, 110, "Facility that is provided by STFLE facility 110"),

ERROR: line over 90 characters
#118: FILE: target/s390x/cpu_features.c:130:
+    FEAT_INIT("stfle111", S390_FEAT_TYPE_STFL, 111, "Facility that is provided by STFLE facility 111"),

ERROR: line over 90 characters
#119: FILE: target/s390x/cpu_features.c:131:
+    FEAT_INIT("stfle112", S390_FEAT_TYPE_STFL, 112, "Facility that is provided by STFLE facility 112"),

ERROR: line over 90 characters
#120: FILE: target/s390x/cpu_features.c:132:
+    FEAT_INIT("stfle113", S390_FEAT_TYPE_STFL, 113, "Facility that is provided by STFLE facility 113"),

ERROR: line over 90 characters
#121: FILE: target/s390x/cpu_features.c:133:
+    FEAT_INIT("stfle114", S390_FEAT_TYPE_STFL, 114, "Facility that is provided by STFLE facility 114"),

ERROR: line over 90 characters
#122: FILE: target/s390x/cpu_features.c:134:
+    FEAT_INIT("stfle115", S390_FEAT_TYPE_STFL, 115, "Facility that is provided by STFLE facility 115"),

ERROR: line over 90 characters
#123: FILE: target/s390x/cpu_features.c:135:
+    FEAT_INIT("stfle116", S390_FEAT_TYPE_STFL, 116, "Facility that is provided by STFLE facility 116"),

ERROR: line over 90 characters
#124: FILE: target/s390x/cpu_features.c:136:
+    FEAT_INIT("stfle117", S390_FEAT_TYPE_STFL, 117, "Facility that is provided by STFLE facility 117"),

ERROR: line over 90 characters
#125: FILE: target/s390x/cpu_features.c:137:
+    FEAT_INIT("stfle118", S390_FEAT_TYPE_STFL, 118, "Facility that is provided by STFLE facility 118"),

ERROR: line over 90 characters
#126: FILE: target/s390x/cpu_features.c:138:
+    FEAT_INIT("stfle119", S390_FEAT_TYPE_STFL, 119, "Facility that is provided by STFLE facility 119"),

ERROR: line over 90 characters
#127: FILE: target/s390x/cpu_features.c:139:
+    FEAT_INIT("stfle120", S390_FEAT_TYPE_STFL, 120, "Facility that is provided by STFLE facility 120"),

ERROR: line over 90 characters
#128: FILE: target/s390x/cpu_features.c:140:
+    FEAT_INIT("stfle121", S390_FEAT_TYPE_STFL, 121, "Facility that is provided by STFLE facility 121"),

ERROR: line over 90 characters
#129: FILE: target/s390x/cpu_features.c:141:
+    FEAT_INIT("stfle122", S390_FEAT_TYPE_STFL, 122, "Facility that is provided by STFLE facility 122"),

ERROR: line over 90 characters
#130: FILE: target/s390x/cpu_features.c:142:
+    FEAT_INIT("stfle123", S390_FEAT_TYPE_STFL, 123, "Facility that is provided by STFLE facility 123"),

ERROR: line over 90 characters
#131: FILE: target/s390x/cpu_features.c:143:
+    FEAT_INIT("stfle124", S390_FEAT_TYPE_STFL, 124, "Facility that is provided by STFLE facility 124"),

ERROR: line over 90 characters
#132: FILE: target/s390x/cpu_features.c:144:
+    FEAT_INIT("stfle125", S390_FEAT_TYPE_STFL, 125, "Facility that is provided by STFLE facility 125"),

ERROR: line over 90 characters
#133: FILE: target/s390x/cpu_features.c:145:
+    FEAT_INIT("stfle126", S390_FEAT_TYPE_STFL, 126, "Facility that is provided by STFLE facility 126"),

ERROR: line over 90 characters
#134: FILE: target/s390x/cpu_features.c:146:
+    FEAT_INIT("stfle127", S390_FEAT_TYPE_STFL, 127, "Facility that is provided by STFLE facility 127"),

total: 54 errors, 0 warnings, 294 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org