Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
CC: Michael S. Tsirkin <mst@redhat.com>
CC: Marcel Apfelbaum <marcel@redhat.com>
---
 Makefile.objs            | 1 +
 hw/pci-host/trace-events | 1 +
 2 files changed, 2 insertions(+)
 create mode 100644 hw/pci-host/trace-events

diff --git a/Makefile.objs b/Makefile.objs
index c8b1bba593..6aa793ce4f 100644
--- a/Makefile.objs
+++ b/Makefile.objs
@@ -149,6 +149,7 @@ trace-events-subdirs += hw/i386/xen
 trace-events-subdirs += hw/9pfs
 trace-events-subdirs += hw/ppc
 trace-events-subdirs += hw/pci
+trace-events-subdirs += hw/pci-host
 trace-events-subdirs += hw/s390x
 trace-events-subdirs += hw/vfio
 trace-events-subdirs += hw/acpi
diff --git a/hw/pci-host/trace-events b/hw/pci-host/trace-events
new file mode 100644
index 0000000000..9284b1fbad
--- /dev/null
+++ b/hw/pci-host/trace-events
@@ -0,0 +1 @@
+# See docs/devel/tracing.txt for syntax documentation.
-- 
2.11.0

On 01/14/2018 07:47 AM, Mark Cave-Ayland wrote:
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

Not sure this is worth a separate commit (I'd squash it in the next
patch), still:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> CC: Michael S. Tsirkin <mst@redhat.com>
> CC: Marcel Apfelbaum <marcel@redhat.com>
> ---
>  Makefile.objs            | 1 +
>  hw/pci-host/trace-events | 1 +
>  2 files changed, 2 insertions(+)
>  create mode 100644 hw/pci-host/trace-events
> 
> diff --git a/Makefile.objs b/Makefile.objs
> index c8b1bba593..6aa793ce4f 100644
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -149,6 +149,7 @@ trace-events-subdirs += hw/i386/xen
>  trace-events-subdirs += hw/9pfs
>  trace-events-subdirs += hw/ppc
>  trace-events-subdirs += hw/pci
> +trace-events-subdirs += hw/pci-host
>  trace-events-subdirs += hw/s390x
>  trace-events-subdirs += hw/vfio
>  trace-events-subdirs += hw/acpi
> diff --git a/hw/pci-host/trace-events b/hw/pci-host/trace-events
> new file mode 100644
> index 0000000000..9284b1fbad
> --- /dev/null
> +++ b/hw/pci-host/trace-events
> @@ -0,0 +1 @@
> +# See docs/devel/tracing.txt for syntax documentation.
> 

On 14/01/2018 15:32, Philippe Mathieu-Daudé wrote:
> On 01/14/2018 07:47 AM, Mark Cave-Ayland wrote:
>> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Not sure this is worth a separate commit (I'd squash it in the next
> patch), still:

I agree, no need to add a new directory to the trace list
while we don't have a trace events file.

Thanks,
Marcel

> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> CC: Michael S. Tsirkin <mst@redhat.com>
>> CC: Marcel Apfelbaum <marcel@redhat.com>
>> ---
>>   Makefile.objs            | 1 +
>>   hw/pci-host/trace-events | 1 +
>>   2 files changed, 2 insertions(+)
>>   create mode 100644 hw/pci-host/trace-events
>>
>> diff --git a/Makefile.objs b/Makefile.objs
>> index c8b1bba593..6aa793ce4f 100644
>> --- a/Makefile.objs
>> +++ b/Makefile.objs
>> @@ -149,6 +149,7 @@ trace-events-subdirs += hw/i386/xen
>>   trace-events-subdirs += hw/9pfs
>>   trace-events-subdirs += hw/ppc
>>   trace-events-subdirs += hw/pci
>> +trace-events-subdirs += hw/pci-host
>>   trace-events-subdirs += hw/s390x
>>   trace-events-subdirs += hw/vfio
>>   trace-events-subdirs += hw/acpi
>> diff --git a/hw/pci-host/trace-events b/hw/pci-host/trace-events
>> new file mode 100644
>> index 0000000000..9284b1fbad
>> --- /dev/null
>> +++ b/hw/pci-host/trace-events
>> @@ -0,0 +1 @@
>> +# See docs/devel/tracing.txt for syntax documentation.
>>

On 14/01/18 16:27, Marcel Apfelbaum wrote:

> On 14/01/2018 15:32, Philippe Mathieu-Daudé wrote:
>> On 01/14/2018 07:47 AM, Mark Cave-Ayland wrote:
>>> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>> Not sure this is worth a separate commit (I'd squash it in the next
>> patch), still:
> 
> I agree, no need to add a new directory to the trace list
> while we don't have a trace events file.

Hi Marcel,

The basic skeleton of the file is there with the just the default 
comments, but other than that it's empty. The only reason I placed it 
into a separate patch was so it could get an Ack from someone on the PCI 
side, but I'm happy to squash it based upon your comment above.


ATB,

Mark.

On Sun, Jan 14, 2018 at 10:47:49AM +0000, Mark Cave-Ayland wrote:
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> CC: Michael S. Tsirkin <mst@redhat.com>
> CC: Marcel Apfelbaum <marcel@redhat.com>

Seems harmless so why not.

Acked-by: Michael S. Tsirkin <mst@redhat.com>



> ---
>  Makefile.objs            | 1 +
>  hw/pci-host/trace-events | 1 +
>  2 files changed, 2 insertions(+)
>  create mode 100644 hw/pci-host/trace-events
> 
> diff --git a/Makefile.objs b/Makefile.objs
> index c8b1bba593..6aa793ce4f 100644
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -149,6 +149,7 @@ trace-events-subdirs += hw/i386/xen
>  trace-events-subdirs += hw/9pfs
>  trace-events-subdirs += hw/ppc
>  trace-events-subdirs += hw/pci
> +trace-events-subdirs += hw/pci-host
>  trace-events-subdirs += hw/s390x
>  trace-events-subdirs += hw/vfio
>  trace-events-subdirs += hw/acpi
> diff --git a/hw/pci-host/trace-events b/hw/pci-host/trace-events
> new file mode 100644
> index 0000000000..9284b1fbad
> --- /dev/null
> +++ b/hw/pci-host/trace-events
> @@ -0,0 +1 @@
> +# See docs/devel/tracing.txt for syntax documentation.
> -- 
> 2.11.0