[v1] qga: unset frozen state if no mount points are frozen

[Qemu-devel] [resend][PATCH] qga: unset frozen state if no mount points are frozen

Chen Hanxiao posted 1 patch 6 years, 3 months ago

Diff against v1 v1 v2 v2 v2
Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180112024745.7609-1-chen_han_xiao@126.com

Test checkpatch passed

Test docker passed

Test ppc passed

Test s390x passed

There is a newer version of this series

qga/commands-posix.c | 6 ++++++
1 file changed, 6 insertions(+)

Expand all Fold all

[Qemu-devel] [resend][PATCH] qga: unset frozen state if no mount points are frozen

Posted by Chen Hanxiao 6 years, 3 months ago

From: Chen Hanxiao <chenhanxiao@gmail.com>

If we set mountpoints to qmp_guest_fsfreeze_freeze_list,
we may got nothing to freeze as all mountpoints are
not valid.
Call ga_unset_frozen in this senario.

Cc: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
---
Rebase on master

 qga/commands-posix.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index e809e382eb..9fd51f1d7a 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -1273,6 +1273,12 @@ int64_t qmp_guest_fsfreeze_freeze_list(bool has_mountpoints,
     }
 
     free_fs_mount_list(&mounts);
+    /* We may not issue any FIFREEZE here when had mountpoints.
+     * Just unset ga_state here and ready for the next call.
+     */
+    if (has_mountpoints && i == 0) {
+        ga_unset_frozen(ga_state);
+    }
     return i;
 
 error:
-- 
2.14.3