add HOST_SUPPORTS_UNALIGNED_ACCESS, reduce slirp warnings

[Qemu-devel] [PATCH 06/12] slirp: remove unused header

Posted by Philippe Mathieu-Daudé 7 years, 9 months ago

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 slirp/slirp.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/slirp/slirp.h b/slirp/slirp.h
index 9a7287e7cc..447dc045a8 100644
--- a/slirp/slirp.h
+++ b/slirp/slirp.h
@@ -1,7 +1,6 @@
 #ifndef SLIRP_H
 #define SLIRP_H
 
-#include "qemu/host-utils.h"
 #include "slirp_config.h"
 
 #ifdef _WIN32
-- 
2.15.1

Re: [Qemu-devel] [PATCH 06/12] slirp: remove unused header

Posted by Thomas Huth 7 years, 9 months ago

On 08.01.2018 18:28, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  slirp/slirp.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/slirp/slirp.h b/slirp/slirp.h
> index 9a7287e7cc..447dc045a8 100644
> --- a/slirp/slirp.h
> +++ b/slirp/slirp.h
> @@ -1,7 +1,6 @@
>  #ifndef SLIRP_H
>  #define SLIRP_H
>  
> -#include "qemu/host-utils.h"

This had been added by commit 87776ab72b02e3c99a042ab7a0a378bc457cc069
which stated "There are some inclusions of qemu/host-utils.h in headers,
but they are all necessary." ... I wonder why it is not necessary
anymore today...?

Anyway, seems like it compiles now fine without this:

Tested-by: Thomas Huth <thuth@redhat.com>

Re: [Qemu-devel] [PATCH 06/12] slirp: remove unused header

Posted by Samuel Thibault 7 years, 9 months ago

Thomas Huth, on lun. 08 janv. 2018 19:54:27 +0100, wrote:
> On 08.01.2018 18:28, Philippe Mathieu-Daudé wrote:
> > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > ---
> >  slirp/slirp.h | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/slirp/slirp.h b/slirp/slirp.h
> > index 9a7287e7cc..447dc045a8 100644
> > --- a/slirp/slirp.h
> > +++ b/slirp/slirp.h
> > @@ -1,7 +1,6 @@
> >  #ifndef SLIRP_H
> >  #define SLIRP_H
> >  
> > -#include "qemu/host-utils.h"
> 
> This had been added by commit 87776ab72b02e3c99a042ab7a0a378bc457cc069
> which stated "There are some inclusions of qemu/host-utils.h in headers,
> but they are all necessary." ... I wonder why it is not necessary
> anymore today...?
> 
> Anyway, seems like it compiles now fine without this:
> 
> Tested-by: Thomas Huth <thuth@redhat.com>

Applied to my tree, thanks!

Samuel