[Qemu-devel] [PATCH v2 0/2] qemu-img: Let "info" warn and go ahead without -U

Fam Zheng posted 2 patches 7 years, 9 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180108075935.23690-1-famz@redhat.com
Test checkpatch passed
Test docker passed
Test ppc passed
Test s390x passed
qemu-img.c                 | 129 +++++++++++++++++++++++++++++----------------
tests/qemu-iotests/043.out |   6 +--
tests/qemu-iotests/153.out |   3 +-
3 files changed, 88 insertions(+), 50 deletions(-)
[Qemu-devel] [PATCH v2 0/2] qemu-img: Let "info" warn and go ahead without -U
Posted by Fam Zheng 7 years, 9 months ago
v2: Add Eric's r-b lines after making suggested tweaks to commit logs and error
    messages.

Management and users are accustomed to "qemu-img info" to query status of
images even when they are used by guests. Since image locking was added, the -U
(--force-share) option is needed for that to work. The reason has been that due
to possible race with image header update, the output can be misleading.

But what are likely to happen after we emit the error are that, for interactive
users, '-U' will be used and the command retried; for management (nova, RHV,
etc.), the operation is broken with no knob to workaround this.

This series changes that error to a warning so that it doesn't get in the way.

Fam

Fam Zheng (2):
  qemu-img: Move img_open error reporting to callers
  qemu-img: info: try -U automatically

 qemu-img.c                 | 129 +++++++++++++++++++++++++++++----------------
 tests/qemu-iotests/043.out |   6 +--
 tests/qemu-iotests/153.out |   3 +-
 3 files changed, 88 insertions(+), 50 deletions(-)

-- 
2.14.3