[Qemu-devel] [PATCH v2 12/13] migration: remove some block_cleanup_parameters()

Peter Xu posted 13 patches 7 years, 9 months ago
[Qemu-devel] [PATCH v2 12/13] migration: remove some block_cleanup_parameters()
Posted by Peter Xu 7 years, 9 months ago
Keep the one in migrate_fd_cancel() would be enough.  Removing the other
two.

Signed-off-by: Peter Xu <peterx@redhat.com>
---
 migration/migration.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/migration/migration.c b/migration/migration.c
index 16eb24c8b3..fbb41b8887 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -1130,7 +1130,6 @@ void migrate_fd_error(MigrationState *s, const Error *error)
                       MIGRATION_STATUS_FAILED);
     migrate_set_error(s, error);
     notifier_list_notify(&migration_state_notifiers, s);
-    block_cleanup_parameters(s);
 }
 
 static void migrate_fd_cancel(MigrationState *s)
@@ -1176,7 +1175,6 @@ static void migrate_fd_cancel(MigrationState *s)
             s->block_inactive = false;
         }
     }
-    block_cleanup_parameters(s);
 }
 
 void add_migration_state_change_notifier(Notifier *notify)
-- 
2.14.3


Re: [Qemu-devel] [PATCH v2 12/13] migration: remove some block_cleanup_parameters()
Posted by Juan Quintela 7 years, 9 months ago
Peter Xu <peterx@redhat.com> wrote:
> Keep the one in migrate_fd_cancel() would be enough.  Removing the other

                          ^^^^^^^

s/cancel/cleanup/

> two.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>

No need to respin for this one.  I can just change it when pulling.

Later, Juan.