[Qemu-devel] [PULL 00/10] Command line patches for 2017-12-18

Markus Armbruster posted 10 patches 7 years, 10 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20171218173023.21417-1-armbru@redhat.com
Test checkpatch passed
Test docker passed
Test ppc passed
Test s390x passed
There is a newer version of this series
include/qemu/option.h  |   5 -
qemu-doc.texi          | 217 +++++++++++++++++++++++++++++++++++
qemu-options-wrapper.h |   2 +-
qemu-options.hx        | 306 ++++++++-----------------------------------------
scripts/hxtool         |   3 +-
util/qemu-option.c     |  36 +-----
6 files changed, 268 insertions(+), 301 deletions(-)
[Qemu-devel] [PULL 00/10] Command line patches for 2017-12-18
Posted by Markus Armbruster 7 years, 10 months ago
The following changes since commit 411ad78115ebeb3411cf4b7622784b93dfabe259:

  Merge remote-tracking branch 'remotes/stefanberger/tags/pull-tpm-2017-12-15-1' into staging (2017-12-17 15:27:41 +0000)

are available in the git repository at:

  git://repo.or.cz/qemu/armbru.git tags/pull-cmdline-2017-12-18

for you to fetch changes up to aa088732820dc26f8881fb7c82bfd75724d18594:

  option: Drop unused get_param_value(), get_next_param_value() (2017-12-18 18:16:28 +0100)

----------------------------------------------------------------
Command line patches for 2017-12-18

----------------------------------------------------------------
Dr. David Alan Gilbert (1):
      option: Remove shadowing opt decl from qemu_opt_print()

Markus Armbruster (9):
      qemu-options: Remove stray colons from output of --help
      qemu-options: Fix markup of -netdev l2tpv3
      qemu-options qemu-doc: Move "Device URL Syntax" to qemu-doc
      qemu-options: Move -iscsi under "Block device options"
      qemu-options: Add missing -iscsi Texinfo documentation
      qemu-options: Polish section "TPM device options"
      qemu-options: Polish section "Character device options"
      qemu-options: Belatedly document --watchdog-action inject-nmi
      option: Drop unused get_param_value(), get_next_param_value()

 include/qemu/option.h  |   5 -
 qemu-doc.texi          | 217 +++++++++++++++++++++++++++++++++++
 qemu-options-wrapper.h |   2 +-
 qemu-options.hx        | 306 ++++++++-----------------------------------------
 scripts/hxtool         |   3 +-
 util/qemu-option.c     |  36 +-----
 6 files changed, 268 insertions(+), 301 deletions(-)

-- 
2.13.6


Re: [Qemu-devel] [PULL 00/10] Command line patches for 2017-12-18
Posted by Peter Maydell 7 years, 10 months ago
On 18 December 2017 at 17:30, Markus Armbruster <armbru@redhat.com> wrote:
> The following changes since commit 411ad78115ebeb3411cf4b7622784b93dfabe259:
>
>   Merge remote-tracking branch 'remotes/stefanberger/tags/pull-tpm-2017-12-15-1' into staging (2017-12-17 15:27:41 +0000)
>
> are available in the git repository at:
>
>   git://repo.or.cz/qemu/armbru.git tags/pull-cmdline-2017-12-18
>
> for you to fetch changes up to aa088732820dc26f8881fb7c82bfd75724d18594:
>
>   option: Drop unused get_param_value(), get_next_param_value() (2017-12-18 18:16:28 +0100)
>
> ----------------------------------------------------------------
> Command line patches for 2017-12-18
>
> ----------------------------------------------------------------
> Dr. David Alan Gilbert (1):
>       option: Remove shadowing opt decl from qemu_opt_print()
>
> Markus Armbruster (9):
>       qemu-options: Remove stray colons from output of --help
>       qemu-options: Fix markup of -netdev l2tpv3
>       qemu-options qemu-doc: Move "Device URL Syntax" to qemu-doc
>       qemu-options: Move -iscsi under "Block device options"
>       qemu-options: Add missing -iscsi Texinfo documentation
>       qemu-options: Polish section "TPM device options"
>       qemu-options: Polish section "Character device options"
>       qemu-options: Belatedly document --watchdog-action inject-nmi
>       option: Drop unused get_param_value(), get_next_param_value()
>
>  include/qemu/option.h  |   5 -
>  qemu-doc.texi          | 217 +++++++++++++++++++++++++++++++++++
>  qemu-options-wrapper.h |   2 +-
>  qemu-options.hx        | 306 ++++++++-----------------------------------------
>  scripts/hxtool         |   3 +-
>  util/qemu-option.c     |  36 +-----
>  6 files changed, 268 insertions(+), 301 deletions(-)

This failed to build on PPC and aarch64 linux:

/home/pm215/qemu/qemu-doc.texi:231: node `sec_invocation' lacks menu
item for `device_url' despite being its Up target
make: *** [qemu-doc.txt] Error 1
make: *** Waiting for unfinished jobs....
/home/pm215/qemu/qemu-doc.texi:231: node `sec_invocation' lacks menu
item for `device_url' despite being its Up target
make: *** [qemu-doc.html] Error 1

and with slightly different errors on openbsd/netbsd/osx:
  GEN     qemu-doc.txt
/root/qemu/qemu-doc.texi:8: warning: unrecognized encoding name `UTF-8'.
/root/qemu/qemu-doc.texi:248: `device_url' has no Up field (perhaps
incorrect sectioning?).
/root/qemu/qemu-doc.texi:248: warning: unreferenced node `device_url'.
makeinfo: Removing output file `qemu-doc.txt' due to errors; use
--force to preserve.
Makefile:774: recipe for target 'qemu-doc.txt' failed

thanks
-- PMM

Re: [Qemu-devel] [PULL 00/10] Command line patches for 2017-12-18
Posted by Markus Armbruster 7 years, 10 months ago
Peter Maydell <peter.maydell@linaro.org> writes:

> On 18 December 2017 at 17:30, Markus Armbruster <armbru@redhat.com> wrote:
>> The following changes since commit 411ad78115ebeb3411cf4b7622784b93dfabe259:
>>
>>   Merge remote-tracking branch 'remotes/stefanberger/tags/pull-tpm-2017-12-15-1' into staging (2017-12-17 15:27:41 +0000)
>>
>> are available in the git repository at:
>>
>>   git://repo.or.cz/qemu/armbru.git tags/pull-cmdline-2017-12-18
>>
>> for you to fetch changes up to aa088732820dc26f8881fb7c82bfd75724d18594:
>>
>>   option: Drop unused get_param_value(), get_next_param_value() (2017-12-18 18:16:28 +0100)
>>
>> ----------------------------------------------------------------
>> Command line patches for 2017-12-18
>>
>> ----------------------------------------------------------------
>> Dr. David Alan Gilbert (1):
>>       option: Remove shadowing opt decl from qemu_opt_print()
>>
>> Markus Armbruster (9):
>>       qemu-options: Remove stray colons from output of --help
>>       qemu-options: Fix markup of -netdev l2tpv3
>>       qemu-options qemu-doc: Move "Device URL Syntax" to qemu-doc
>>       qemu-options: Move -iscsi under "Block device options"
>>       qemu-options: Add missing -iscsi Texinfo documentation
>>       qemu-options: Polish section "TPM device options"
>>       qemu-options: Polish section "Character device options"
>>       qemu-options: Belatedly document --watchdog-action inject-nmi
>>       option: Drop unused get_param_value(), get_next_param_value()
>>
>>  include/qemu/option.h  |   5 -
>>  qemu-doc.texi          | 217 +++++++++++++++++++++++++++++++++++
>>  qemu-options-wrapper.h |   2 +-
>>  qemu-options.hx        | 306 ++++++++-----------------------------------------
>>  scripts/hxtool         |   3 +-
>>  util/qemu-option.c     |  36 +-----
>>  6 files changed, 268 insertions(+), 301 deletions(-)
>
> This failed to build on PPC and aarch64 linux:
>
> /home/pm215/qemu/qemu-doc.texi:231: node `sec_invocation' lacks menu
> item for `device_url' despite being its Up target
> make: *** [qemu-doc.txt] Error 1
> make: *** Waiting for unfinished jobs....
> /home/pm215/qemu/qemu-doc.texi:231: node `sec_invocation' lacks menu
> item for `device_url' despite being its Up target
> make: *** [qemu-doc.html] Error 1
>
> and with slightly different errors on openbsd/netbsd/osx:
>   GEN     qemu-doc.txt
> /root/qemu/qemu-doc.texi:8: warning: unrecognized encoding name `UTF-8'.
> /root/qemu/qemu-doc.texi:248: `device_url' has no Up field (perhaps
> incorrect sectioning?).
> /root/qemu/qemu-doc.texi:248: warning: unreferenced node `device_url'.
> makeinfo: Removing output file `qemu-doc.txt' due to errors; use
> --force to preserve.
> Makefile:774: recipe for target 'qemu-doc.txt' failed

Hmm.  Looks like the culprit is a @node we don't actually want.  v2
sent.  Thanks!