1. Patchew
  2. QEMU
  3. View series

[Qemu-devel] [PATCH v2 0/2] Enable full IPv4/IPv6 dual stack for NBD server

Daniel P. Berrange posted 2 patches 7 years, 10 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20171218101643.20360-1-berrange@redhat.com
Test checkpatch passed
Test docker passed
Test ppc passed
Test s390x passed
blockdev-nbd.c | 50 +++++++++++++++--------------------------------
qemu-nbd.c     | 61 +++++++++++++++++++++++-----------------------------------
2 files changed, 40 insertions(+), 71 deletions(-)
[Qemu-devel] [PATCH v2 0/2] Enable full IPv4/IPv6 dual stack for NBD server
Posted by Daniel P. Berrange 7 years, 10 months ago 
These patches were previously posted as part of a larger series:

  https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02064.html

These patches port the NBD server to use QIONetListener, which allows for
easy setup of multiple listening sockets. This enables full support for
IPv4/IPv6 dual stack, by fully honouring all addresses returned from a
DNS lookup.

There has been no change since v1, except for trivial rebase.

Daniel P. Berrange (2):
  blockdev: convert internal NBD server to QIONetListener
  blockdev: convert qemu-nbd server to QIONetListener

 blockdev-nbd.c | 50 +++++++++++++++--------------------------------
 qemu-nbd.c     | 61 +++++++++++++++++++++++-----------------------------------
 2 files changed, 40 insertions(+), 71 deletions(-)

-- 
2.14.3
Re: [Qemu-devel] [PATCH v2 0/2] Enable full IPv4/IPv6 dual stack for NBD server
Posted by Paolo Bonzini 7 years, 10 months ago 
On 18/12/2017 11:16, Daniel P. Berrange wrote:
> These patches were previously posted as part of a larger series:
> 
>   https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02064.html
> 
> These patches port the NBD server to use QIONetListener, which allows for
> easy setup of multiple listening sockets. This enables full support for
> IPv4/IPv6 dual stack, by fully honouring all addresses returned from a
> DNS lookup.
> 
> There has been no change since v1, except for trivial rebase.
> 
> Daniel P. Berrange (2):
>   blockdev: convert internal NBD server to QIONetListener
>   blockdev: convert qemu-nbd server to QIONetListener
> 
>  blockdev-nbd.c | 50 +++++++++++++++--------------------------------
>  qemu-nbd.c     | 61 +++++++++++++++++++++++-----------------------------------
>  2 files changed, 40 insertions(+), 71 deletions(-)
> 

Looks good, thanks!

Paolo
Re: [Qemu-devel] [PATCH v2 0/2] Enable full IPv4/IPv6 dual stack for NBD server
Posted by Eric Blake 7 years, 10 months ago 
On 12/18/2017 05:48 AM, Paolo Bonzini wrote:
> On 18/12/2017 11:16, Daniel P. Berrange wrote:
>> These patches were previously posted as part of a larger series:
>>
>>    https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02064.html
>>
>> These patches port the NBD server to use QIONetListener, which allows for
>> easy setup of multiple listening sockets. This enables full support for
>> IPv4/IPv6 dual stack, by fully honouring all addresses returned from a
>> DNS lookup.
>>
>> There has been no change since v1, except for trivial rebase.
>>
>> Daniel P. Berrange (2):
>>    blockdev: convert internal NBD server to QIONetListener
>>    blockdev: convert qemu-nbd server to QIONetListener
>>
>>   blockdev-nbd.c | 50 +++++++++++++++--------------------------------
>>   qemu-nbd.c     | 61 +++++++++++++++++++++++-----------------------------------
>>   2 files changed, 40 insertions(+), 71 deletions(-)
>>
> 
> Looks good, thanks!

I see these were included in Paolo's pull request, but that it failed 
for other reasons.  If needed, I can take it through the NBD tree.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org
Re: [Qemu-devel] [PATCH v2 0/2] Enable full IPv4/IPv6 dual stack for NBD server
Posted by Paolo Bonzini 7 years, 10 months ago 
On 21/12/2017 00:16, Eric Blake wrote:
> On 12/18/2017 05:48 AM, Paolo Bonzini wrote:
>> On 18/12/2017 11:16, Daniel P. Berrange wrote:
>>> These patches were previously posted as part of a larger series:
>>>
>>>    https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02064.html
>>>
>>> These patches port the NBD server to use QIONetListener, which allows
>>> for
>>> easy setup of multiple listening sockets. This enables full support for
>>> IPv4/IPv6 dual stack, by fully honouring all addresses returned from a
>>> DNS lookup.
>>>
>>> There has been no change since v1, except for trivial rebase.
>>>
>>> Daniel P. Berrange (2):
>>>    blockdev: convert internal NBD server to QIONetListener
>>>    blockdev: convert qemu-nbd server to QIONetListener
>>>
>>>   blockdev-nbd.c | 50 +++++++++++++++--------------------------------
>>>   qemu-nbd.c     | 61
>>> +++++++++++++++++++++++-----------------------------------
>>>   2 files changed, 40 insertions(+), 71 deletions(-)
>>>
>>
>> Looks good, thanks!
> 
> I see these were included in Paolo's pull request, but that it failed
> for other reasons.  If needed, I can take it through the NBD tree.

I'll respin tomorrow.

Paolo

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.