[Qemu-devel] [PATCH v2 00/13] Various build-sys and ASAN related fixes

Marc-André Lureau posted 13 patches 44 weeks ago
Failed in applying to current master (apply log)
Test checkpatch passed
Test docker passed
Test ppc passed
Test s390x passed
include/qemu/compiler.h     |  4 ++++
include/qemu/readline.h     |  1 +
crypto/ivgen-essiv.c        |  2 +-
monitor.c                   |  2 +-
tests/check-qobject.c       |  2 ++
tests/migration-test.c      |  3 ++-
tests/qmp-test.c            |  3 ++-
tests/test-coroutine.c      |  1 -
util/coroutine-ucontext.c   | 46 +++++++++++++++++++++++++++++++++++++++++++++
util/qemu-config.c          |  3 ++-
util/readline.c             | 18 +++++++++++++++++-
vl.c                        |  9 ++++++---
Makefile                    |  7 +++++--
configure                   |  6 ++++++
docs/devel/build-system.txt | 13 +++++++++++++
rules.mak                   |  2 ++
16 files changed, 110 insertions(+), 12 deletions(-)

[Qemu-devel] [PATCH v2 00/13] Various build-sys and ASAN related fixes

Posted by Marc-André Lureau 44 weeks ago
Hi,

This is a small series that improves a bit the build system, and
introduce ASAN by default when --enable-debug. Them it fixes a few
leaks that occur during make check: common and x86_64 target tests are
leak free after this series, the other targets will need some
work. Finally, the last patch should help ASAN and remove some
false-positive, unfortunately it crashes ASAN and may be
incorrect. Help welcome!

v2:
- simplify "build-sys: silence make by default or V=0": make it a
  oneliner MAKEFLAGS, use --quiet.
- document print-VAR rule in docs/devel/build-system.txt
- fix ASAN coroutine instrumentation failure
- should fix builds on gcc 4.4.7 (centos 6)
- new coroutine test leak fix
- add some r-b tags

Marc-André Lureau (13):
  build-sys: fix qemu-ga -pthread linking
  build-sys: silence make by default or V=0
  build-sys: add a rule to print a variable
  build-sys: add AddressSanitizer when --enable-debug if possible
  tests: fix check-qobject leak:
  vl: fix direct firmware directories leak
  readline: add a free function
  tests: fix migration-test leak
  crypto: fix stack-buffer-overflow error
  qemu-config: fix leak in query-command-line-options
  tests: fix qmp-test leak
  ucontext: annotate coroutine stack for ASAN
  tests: fix coroutine leak in /basic/entered

 include/qemu/compiler.h     |  4 ++++
 include/qemu/readline.h     |  1 +
 crypto/ivgen-essiv.c        |  2 +-
 monitor.c                   |  2 +-
 tests/check-qobject.c       |  2 ++
 tests/migration-test.c      |  3 ++-
 tests/qmp-test.c            |  3 ++-
 tests/test-coroutine.c      |  1 -
 util/coroutine-ucontext.c   | 46 +++++++++++++++++++++++++++++++++++++++++++++
 util/qemu-config.c          |  3 ++-
 util/readline.c             | 18 +++++++++++++++++-
 vl.c                        |  9 ++++++---
 Makefile                    |  7 +++++--
 configure                   |  6 ++++++
 docs/devel/build-system.txt | 13 +++++++++++++
 rules.mak                   |  2 ++
 16 files changed, 110 insertions(+), 12 deletions(-)

-- 
2.15.1.355.g36791d7216


Re: [Qemu-devel] [PATCH v2 00/13] Various build-sys and ASAN related fixes

Posted by Marc-André Lureau 44 weeks ago
Hi

On Fri, Dec 15, 2017 at 4:06 PM, Marc-André Lureau
<marcandre.lureau@redhat.com> wrote:
> work. Finally, the last patch should help ASAN and remove some
> false-positive, unfortunately it crashes ASAN and may be
> incorrect. Help welcome!
>

I forgot to update the cover letter: this is no longer true!

thanks

> v2:
> - simplify "build-sys: silence make by default or V=0": make it a
>   oneliner MAKEFLAGS, use --quiet.
> - document print-VAR rule in docs/devel/build-system.txt
> - fix ASAN coroutine instrumentation failure
> - should fix builds on gcc 4.4.7 (centos 6)
> - new coroutine test leak fix
> - add some r-b tags
>
> Marc-André Lureau (13):
>   build-sys: fix qemu-ga -pthread linking
>   build-sys: silence make by default or V=0
>   build-sys: add a rule to print a variable
>   build-sys: add AddressSanitizer when --enable-debug if possible
>   tests: fix check-qobject leak:
>   vl: fix direct firmware directories leak
>   readline: add a free function
>   tests: fix migration-test leak
>   crypto: fix stack-buffer-overflow error
>   qemu-config: fix leak in query-command-line-options
>   tests: fix qmp-test leak
>   ucontext: annotate coroutine stack for ASAN
>   tests: fix coroutine leak in /basic/entered
>
>  include/qemu/compiler.h     |  4 ++++
>  include/qemu/readline.h     |  1 +
>  crypto/ivgen-essiv.c        |  2 +-
>  monitor.c                   |  2 +-
>  tests/check-qobject.c       |  2 ++
>  tests/migration-test.c      |  3 ++-
>  tests/qmp-test.c            |  3 ++-
>  tests/test-coroutine.c      |  1 -
>  util/coroutine-ucontext.c   | 46 +++++++++++++++++++++++++++++++++++++++++++++
>  util/qemu-config.c          |  3 ++-
>  util/readline.c             | 18 +++++++++++++++++-
>  vl.c                        |  9 ++++++---
>  Makefile                    |  7 +++++--
>  configure                   |  6 ++++++
>  docs/devel/build-system.txt | 13 +++++++++++++
>  rules.mak                   |  2 ++
>  16 files changed, 110 insertions(+), 12 deletions(-)
>
> --
> 2.15.1.355.g36791d7216
>
>



-- 
Marc-André Lureau