[v4] remove i386/pc dependency from non-PC world (part 1)

[Qemu-devel] [PATCH v4 04/43] MAINTAINERS: add an entry for the i82378 (superio)

Posted by Philippe Mathieu-Daudé 8 years, 1 month ago

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Hervé Poussineau <hpoussin@reactos.org>
Reviewed-by: Hervé Poussineau <hpoussin@reactos.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 31c673d60a..4618f9b4db 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -732,6 +732,7 @@ F: hw/ppc/prep.c
 F: hw/ppc/prep_systemio.c
 F: hw/ppc/rs6000_mc.c
 F: hw/pci-host/prep.[hc]
+F: hw/isa/i82378.c
 F: hw/isa/pc87312.[hc]
 F: hw/dma/i82374.c
 F: pc-bios/ppc_rom.bin
-- 
2.15.1

Re: [Qemu-devel] [PATCH v4 04/43] MAINTAINERS: add an entry for the i82378 (superio)

Posted by Thomas Huth 8 years, 1 month ago

On 15.12.2017 04:29, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Reviewed-by: Hervé Poussineau <hpoussin@reactos.org>
> Reviewed-by: Hervé Poussineau <hpoussin@reactos.org>

Remove the doubled Reviewed-by, or replace the second line with:

Reviewed-by: Thomas Huth <thuth@redhat.com>

> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 31c673d60a..4618f9b4db 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -732,6 +732,7 @@ F: hw/ppc/prep.c
>  F: hw/ppc/prep_systemio.c
>  F: hw/ppc/rs6000_mc.c
>  F: hw/pci-host/prep.[hc]
> +F: hw/isa/i82378.c
>  F: hw/isa/pc87312.[hc]
>  F: hw/dma/i82374.c
>  F: pc-bios/ppc_rom.bin
>

Re: [Qemu-devel] [PATCH v4 04/43] MAINTAINERS: add an entry for the i82378 (superio)

Posted by Philippe Mathieu-Daudé 8 years, 1 month ago

On 12/15/2017 07:17 AM, Thomas Huth wrote:
> On 15.12.2017 04:29, Philippe Mathieu-Daudé wrote:
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> Reviewed-by: Hervé Poussineau <hpoussin@reactos.org>
>> Reviewed-by: Hervé Poussineau <hpoussin@reactos.org>
> 
> Remove the doubled Reviewed-by, or replace the second line with:
> 
> Reviewed-by: Thomas Huth <thuth@redhat.com>

Haha ok, thanks :)

I applied this series from a patchwork bundle and didn't notice it would
keep enqueueing R-b from the same reviewer.

> 
>> ---
>>  MAINTAINERS | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 31c673d60a..4618f9b4db 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -732,6 +732,7 @@ F: hw/ppc/prep.c
>>  F: hw/ppc/prep_systemio.c
>>  F: hw/ppc/rs6000_mc.c
>>  F: hw/pci-host/prep.[hc]
>> +F: hw/isa/i82378.c
>>  F: hw/isa/pc87312.[hc]
>>  F: hw/dma/i82374.c
>>  F: pc-bios/ppc_rom.bin