[Qemu-devel] [PATCH 00/14] SDHCI housekeeping

Philippe Mathieu-Daudé posted 14 patches 44 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20171213195852.30439-1-f4bug@amsat.org
Test checkpatch passed
Test docker passed
Test ppc passed
Test s390x passed
include/hw/sd/sd.h        |  95 ++-----------------
include/hw/sd/sdhci.h     |   6 +-
hw/sd/sd-internal.h       | 119 +++++++++++++++++++++++
hw/sd/sdhci-internal.h    |   5 +-
hw/sd/core.c              |   3 +-
hw/sd/milkymist-memcard.c |   2 +-
hw/sd/omap_mmc.c          |   1 +
hw/sd/pl181.c             |   2 +-
hw/sd/pxa2xx_mmci.c       |   1 +
hw/sd/sd.c                |   6 +-
hw/sd/sdhci.c             | 235 ++++++++++++++++++++++++----------------------
hw/sd/ssi-sd.c            |   2 +-
hw/sd/trace-events        |  15 +++
13 files changed, 276 insertions(+), 216 deletions(-)
create mode 100644 hw/sd/sd-internal.h

[Qemu-devel] [PATCH 00/14] SDHCI housekeeping

Posted by Philippe Mathieu-Daudé 44 weeks ago
Hi,

This series refactor the SDHCI codebase to ease further development/series.

- 1: we restrict part of "sd/sd.h" into local "sd-internal.h",
- 2-5,13: we somehow beautiful the code, no logical changes,
- 6-9: we refactor the common sysbus/pci qdev code,
- 10-12: we add plenty of trace events which will result useful later,
- 14: we finally expose a "dma-memory" property.

Regards,

Phil.

Based-on: 20171213051736.17755-5-f4bug@amsat.org
          (Trivial changes in "registerfields.h")

Philippe Mathieu-Daudé (14):
  sd: split "sd-internal.h" of "hw/sd/sd.h"
  sdhci: clean up includes
  sdhci: use the ldst_le_dma API
  sdhci: use deposit64()
  sdhci: move MASK_TRNMOD with other SDHC_TRN* defines in "sd-internal.h"
  sdhci: refactor same sysbus/pci properties into a common one
  sdhci: refactor common sysbus/pci realize() into sdhci_realizefn()
  sdhci: refactor common sysbus/pci class_init() into sdhci_class_init()
  sdhci: refactor common sysbus/pci unrealize() into sdhci_unrealizefn()
  sdhci: use qemu_log_mask(UNIMP) instead of fprintf()
  sdhci: convert the DPRINT() calls into trace events
  sdhci: add a trace event for the LED control
  sdhci: add sdhci_init_capareg() to initialize the CAPAB register
  sdhci: add a "dma-memory" property

 include/hw/sd/sd.h        |  95 ++-----------------
 include/hw/sd/sdhci.h     |   6 +-
 hw/sd/sd-internal.h       | 119 +++++++++++++++++++++++
 hw/sd/sdhci-internal.h    |   5 +-
 hw/sd/core.c              |   3 +-
 hw/sd/milkymist-memcard.c |   2 +-
 hw/sd/omap_mmc.c          |   1 +
 hw/sd/pl181.c             |   2 +-
 hw/sd/pxa2xx_mmci.c       |   1 +
 hw/sd/sd.c                |   6 +-
 hw/sd/sdhci.c             | 235 ++++++++++++++++++++++++----------------------
 hw/sd/ssi-sd.c            |   2 +-
 hw/sd/trace-events        |  15 +++
 13 files changed, 276 insertions(+), 216 deletions(-)
 create mode 100644 hw/sd/sd-internal.h

-- 
2.15.1