blockdev: Mark BD-{remove, insert}-medium stable

[Qemu-devel] [PATCH for-2.12 0/4] blockdev: Mark BD-{remove, insert}-medium stable

Posted by Max Reitz 6 years, 5 months ago

Berto's "Test I/O limits with removable media" patch proves that
throttling survives a blockdev-remove-medium/blockdev-insert-medium pair
now, so let's mark them stable (because that was the reason they were
considered experimental, see commit
6e0abc251dd4f8eba1f53656dfede12e5840e83b for more).

But before we do that, let's use the chance and drop the @device
parameter.


Based-on: <cover.1510339534.git.berto@igalia.com>
("Fix throttling crashes in BlockBackend with no BlockDriverState",
 because of the test case added there)


Max Reitz (4):
  iotests: Make BD-{remove,insert}-medium use @id
  tests/ahci: Switch tray and medium commands to @id
  blockdev: Drop BD-{remove,insert}-medium's @device
  blockdev: Mark BD-{remove,insert}-medium stable

 qapi/block-core.json   |  42 ++++-------
 blockdev.c             |  30 ++++++--
 tests/ahci-test.c      |  16 ++---
 tests/qemu-iotests/093 |   6 +-
 tests/qemu-iotests/118 | 184 +++++++++++++++++++++++--------------------------
 tests/qemu-iotests/139 |   2 +-
 tests/qemu-iotests/155 |  60 ++++++++--------
 7 files changed, 163 insertions(+), 177 deletions(-)

-- 
2.13.6

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.12 0/4] blockdev: Mark BD-{remove, insert}-medium stable

Posted by Alberto Garcia 6 years, 5 months ago

On Fri 10 Nov 2017 11:42:58 PM CET, Max Reitz wrote:
> Berto's "Test I/O limits with removable media" patch proves that
> throttling survives a blockdev-remove-medium/blockdev-insert-medium pair
> now, so let's mark them stable (because that was the reason they were
> considered experimental, see commit
> 6e0abc251dd4f8eba1f53656dfede12e5840e83b for more).
>
> But before we do that, let's use the chance and drop the @device
> parameter.
>
>
> Based-on: <cover.1510339534.git.berto@igalia.com>
> ("Fix throttling crashes in BlockBackend with no BlockDriverState",
>  because of the test case added there)
>
>
> Max Reitz (4):
>   iotests: Make BD-{remove,insert}-medium use @id
>   tests/ahci: Switch tray and medium commands to @id
>   blockdev: Drop BD-{remove,insert}-medium's @device
>   blockdev: Mark BD-{remove,insert}-medium stable

This series,

Reviewed-by: Alberto Garcia <berto@igalia.com>

Berto

Re: [Qemu-devel] [PATCH for-2.12 0/4] blockdev: Mark BD-{remove, insert}-medium stable

Posted by Max Reitz 6 years, 3 months ago

On 2017-11-10 23:42, Max Reitz wrote:
> Berto's "Test I/O limits with removable media" patch proves that
> throttling survives a blockdev-remove-medium/blockdev-insert-medium pair
> now, so let's mark them stable (because that was the reason they were
> considered experimental, see commit
> 6e0abc251dd4f8eba1f53656dfede12e5840e83b for more).
> 
> But before we do that, let's use the chance and drop the @device
> parameter.
> 
> 
> Based-on: <cover.1510339534.git.berto@igalia.com>
> ("Fix throttling crashes in BlockBackend with no BlockDriverState",
>  because of the test case added there)
> 
> 
> Max Reitz (4):
>   iotests: Make BD-{remove,insert}-medium use @id
>   tests/ahci: Switch tray and medium commands to @id
>   blockdev: Drop BD-{remove,insert}-medium's @device
>   blockdev: Mark BD-{remove,insert}-medium stable
> 
>  qapi/block-core.json   |  42 ++++-------
>  blockdev.c             |  30 ++++++--
>  tests/ahci-test.c      |  16 ++---
>  tests/qemu-iotests/093 |   6 +-
>  tests/qemu-iotests/118 | 184 +++++++++++++++++++++++--------------------------
>  tests/qemu-iotests/139 |   2 +-
>  tests/qemu-iotests/155 |  60 ++++++++--------
>  7 files changed, 163 insertions(+), 177 deletions(-)

Applied to my block branch.

Max