[Qemu-devel] [PATCH v2 0/5] iotests: Make some tests less flaky

Max Reitz posted 5 patches 6 years, 5 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20171109203025.27493-1-mreitz@redhat.com
Test checkpatch passed
Test docker passed
Test ppc passed
Test s390x passed
tests/qemu-iotests/030 |  8 ++++++--
tests/qemu-iotests/040 |  2 +-
tests/qemu-iotests/055 | 25 ++++++++++++++++---------
tests/qemu-iotests/083 |  4 +++-
tests/qemu-iotests/136 | 14 +++++++++++++-
5 files changed, 39 insertions(+), 14 deletions(-)
[Qemu-devel] [PATCH v2 0/5] iotests: Make some tests less flaky
Posted by Max Reitz 6 years, 5 months ago
There are a couple of tests that fail (on my machine) from time to
time (and by that I mean that recently I've rarely ever had a test run
with both 083 and 136 working on first try).
This series should fix most (at least the issues I am aware of).

Notes:
- 083 might have another issue, but if so it occurs extremely rarely and
  so I was unable to debug it.

- 129 is flaky, too, because it tries to use block jobs with BB
  throttling -- however, block jobs ignore that these days.  Making it
  use a throttle filter node will require quite a bit of work.  See
  http://lists.nongnu.org/archive/html/qemu-block/2017-11/msg00111.html
  for more.

- 194 sometimes hangs because the source VM fails to drain its drive.
  This is probably not an issue with the test, but actually an issue in
  qemu.  See
  http://lists.nongnu.org/archive/html/qemu-block/2017-11/msg00256.html
  for more.


v2:
 - Spelling fixes [Eric]
 - Contract grep | sed to a single sed in 083 [Eric]


git-backport-diff against v1:

Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch
[down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively

001/5:[----] [--] 'iotests: Make 030 less flaky'
002/5:[----] [--] 'iotests: Add missing 'blkdebug::' in 040'
003/5:[----] [--] 'iotests: Make 055 less flaky'
004/5:[0003] [FC] 'iotests: Make 083 less flaky'
005/5:[----] [--] 'iotests: Make 136 less flaky'


Max Reitz (5):
  iotests: Make 030 less flaky
  iotests: Add missing 'blkdebug::' in 040
  iotests: Make 055 less flaky
  iotests: Make 083 less flaky
  iotests: Make 136 less flaky

 tests/qemu-iotests/030 |  8 ++++++--
 tests/qemu-iotests/040 |  2 +-
 tests/qemu-iotests/055 | 25 ++++++++++++++++---------
 tests/qemu-iotests/083 |  4 +++-
 tests/qemu-iotests/136 | 14 +++++++++++++-
 5 files changed, 39 insertions(+), 14 deletions(-)

-- 
2.13.6


Re: [Qemu-devel] [PATCH v2 0/5] iotests: Make some tests less flaky
Posted by Max Reitz 6 years, 5 months ago
On 2017-11-09 21:30, Max Reitz wrote:
> There are a couple of tests that fail (on my machine) from time to
> time (and by that I mean that recently I've rarely ever had a test run
> with both 083 and 136 working on first try).
> This series should fix most (at least the issues I am aware of).

Fixed the commit message in patch 4 as suggested by Eric and applied to
my block branch:

https://github.com/XanClic/qemu/commits/block

Max