Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PULL for-2.11 0/2] Capstone updates
Type: series
Message-id: 20171109075243.4794-1-richard.henderson@linaro.org
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20171109075243.4794-1-richard.henderson@linaro.org -> patchew/20171109075243.4794-1-richard.henderson@linaro.org
Switched to a new branch 'test'
7202d02907 Makefile: Capstone: Add support for cross compile ranlib
c6dc01dedb disas: Dump insn bytes along with capstone disassembly
=== OUTPUT BEGIN ===
Checking PATCH 1/2: disas: Dump insn bytes along with capstone disassembly...
ERROR: suspect code indent for conditional statements (8, 11)
#98: FILE: disas.c:315:
while (cs_disasm_iter(handle, &cbuf, &csize, &pc, insn)) {
+ cap_dump_insn(info, insn);
ERROR: suspect code indent for conditional statements (4, 7)
#110: FILE: disas.c:360:
while (cs_disasm_iter(handle, &cbuf, &size, &pc, insn)) {
+ cap_dump_insn(info, insn);
total: 2 errors, 0 warnings, 184 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/2: Makefile: Capstone: Add support for cross compile ranlib...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org