1. Patchew
  2. QEMU
  3. View series

[Qemu-devel] [PATCH] build-sys: restrict vmcoreinfo to fw_cfg+dma capable targets

Marc-André Lureau posted 1 patch 6 years, 5 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20171106115347.19873-1-marcandre.lureau@redhat.com
Test checkpatch passed
Test docker passed
Test ppc passed
Test s390x passed
default-configs/arm-softmmu.mak    | 2 ++
default-configs/i386-softmmu.mak   | 1 +
default-configs/x86_64-softmmu.mak | 1 +
hw/misc/Makefile.objs              | 2 +-
4 files changed, 5 insertions(+), 1 deletion(-)
[Qemu-devel] [PATCH] build-sys: restrict vmcoreinfo to fw_cfg+dma capable targets
Posted by Marc-André Lureau 6 years, 5 months ago 
vmcoreinfo is built for all targets. However, it requires fw_cfg with
DMA operations support (write operation). Restrict vmcoreinfo exposure
to architectures that are supporting FW_CFG_DMA, that is arm-virt and
x86 only atm.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 default-configs/arm-softmmu.mak    | 2 ++
 default-configs/i386-softmmu.mak   | 1 +
 default-configs/x86_64-softmmu.mak | 1 +
 hw/misc/Makefile.objs              | 2 +-
 4 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak
index 5059d134c8..d37edc4312 100644
--- a/default-configs/arm-softmmu.mak
+++ b/default-configs/arm-softmmu.mak
@@ -130,3 +130,5 @@ CONFIG_SMBIOS=y
 CONFIG_ASPEED_SOC=y
 CONFIG_GPIO_KEY=y
 CONFIG_MSF2=y
+
+CONFIG_FW_CFG_DMA=y
diff --git a/default-configs/i386-softmmu.mak b/default-configs/i386-softmmu.mak
index a685c439e7..95ac4b464a 100644
--- a/default-configs/i386-softmmu.mak
+++ b/default-configs/i386-softmmu.mak
@@ -60,3 +60,4 @@ CONFIG_SMBIOS=y
 CONFIG_HYPERV_TESTDEV=$(CONFIG_KVM)
 CONFIG_PXB=y
 CONFIG_ACPI_VMGENID=y
+CONFIG_FW_CFG_DMA=y
diff --git a/default-configs/x86_64-softmmu.mak b/default-configs/x86_64-softmmu.mak
index ea69e8289e..0221236825 100644
--- a/default-configs/x86_64-softmmu.mak
+++ b/default-configs/x86_64-softmmu.mak
@@ -60,3 +60,4 @@ CONFIG_SMBIOS=y
 CONFIG_HYPERV_TESTDEV=$(CONFIG_KVM)
 CONFIG_PXB=y
 CONFIG_ACPI_VMGENID=y
+CONFIG_FW_CFG_DMA=y
diff --git a/hw/misc/Makefile.objs b/hw/misc/Makefile.objs
index 19202d90cf..10c88a84b4 100644
--- a/hw/misc/Makefile.objs
+++ b/hw/misc/Makefile.objs
@@ -9,7 +9,7 @@ common-obj-$(CONFIG_PCI_TESTDEV) += pci-testdev.o
 common-obj-$(CONFIG_EDU) += edu.o
 
 common-obj-y += unimp.o
-common-obj-y += vmcoreinfo.o
+common-obj-$(CONFIG_FW_CFG_DMA) += vmcoreinfo.o
 
 obj-$(CONFIG_VMPORT) += vmport.o
 
-- 
2.15.0.rc0.40.gaefcc5f6f
Re: [Qemu-devel] [PATCH] build-sys: restrict vmcoreinfo to fw_cfg+dma capable targets
Posted by Thomas Huth 6 years, 5 months ago 
On 06.11.2017 12:53, Marc-André Lureau wrote:
> vmcoreinfo is built for all targets. However, it requires fw_cfg with
> DMA operations support (write operation). Restrict vmcoreinfo exposure
> to architectures that are supporting FW_CFG_DMA, that is arm-virt and
> x86 only atm.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  default-configs/arm-softmmu.mak    | 2 ++
>  default-configs/i386-softmmu.mak   | 1 +
>  default-configs/x86_64-softmmu.mak | 1 +
>  hw/misc/Makefile.objs              | 2 +-
>  4 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak
> index 5059d134c8..d37edc4312 100644
> --- a/default-configs/arm-softmmu.mak
> +++ b/default-configs/arm-softmmu.mak
> @@ -130,3 +130,5 @@ CONFIG_SMBIOS=y
>  CONFIG_ASPEED_SOC=y
>  CONFIG_GPIO_KEY=y
>  CONFIG_MSF2=y
> +
> +CONFIG_FW_CFG_DMA=y

Maybe remove the empty line?

Apart from that, patch looks good to me, so:

Reviewed-by: Thomas Huth <thuth@redhat.com>
Re: [Qemu-devel] [PATCH] build-sys: restrict vmcoreinfo to fw_cfg+dma capable targets
Posted by Marc-André Lureau 6 years, 5 months ago 
Hi

On Mon, Nov 6, 2017 at 12:58 PM, Thomas Huth <thuth@redhat.com> wrote:
> On 06.11.2017 12:53, Marc-André Lureau wrote:
>> vmcoreinfo is built for all targets. However, it requires fw_cfg with
>> DMA operations support (write operation). Restrict vmcoreinfo exposure
>> to architectures that are supporting FW_CFG_DMA, that is arm-virt and
>> x86 only atm.
>>
>> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>> ---
>>  default-configs/arm-softmmu.mak    | 2 ++
>>  default-configs/i386-softmmu.mak   | 1 +
>>  default-configs/x86_64-softmmu.mak | 1 +
>>  hw/misc/Makefile.objs              | 2 +-
>>  4 files changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak
>> index 5059d134c8..d37edc4312 100644
>> --- a/default-configs/arm-softmmu.mak
>> +++ b/default-configs/arm-softmmu.mak
>> @@ -130,3 +130,5 @@ CONFIG_SMBIOS=y
>>  CONFIG_ASPEED_SOC=y
>>  CONFIG_GPIO_KEY=y
>>  CONFIG_MSF2=y
>> +
>> +CONFIG_FW_CFG_DMA=y
>
> Maybe remove the empty line?
>

This file seems to be organized somehow, although it's hard to figure
out how for me at first glance ;) commenting sections would help.

> Apart from that, patch looks good to me, so:
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>

thanks


-- 
Marc-André Lureau
Re: [Qemu-devel] [PATCH] build-sys: restrict vmcoreinfo to fw_cfg+dma capable targets
Posted by Daniel Henrique Barboza 6 years, 5 months ago 

On 11/06/2017 09:53 AM, Marc-André Lureau wrote:
> vmcoreinfo is built for all targets. However, it requires fw_cfg with
> DMA operations support (write operation). Restrict vmcoreinfo exposure
> to architectures that are supporting FW_CFG_DMA, that is arm-virt and
> x86 only atm.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---

Reviewed-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com>
Tested-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com>

>   default-configs/arm-softmmu.mak    | 2 ++
>   default-configs/i386-softmmu.mak   | 1 +
>   default-configs/x86_64-softmmu.mak | 1 +
>   hw/misc/Makefile.objs              | 2 +-
>   4 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak
> index 5059d134c8..d37edc4312 100644
> --- a/default-configs/arm-softmmu.mak
> +++ b/default-configs/arm-softmmu.mak
> @@ -130,3 +130,5 @@ CONFIG_SMBIOS=y
>   CONFIG_ASPEED_SOC=y
>   CONFIG_GPIO_KEY=y
>   CONFIG_MSF2=y
> +
> +CONFIG_FW_CFG_DMA=y
> diff --git a/default-configs/i386-softmmu.mak b/default-configs/i386-softmmu.mak
> index a685c439e7..95ac4b464a 100644
> --- a/default-configs/i386-softmmu.mak
> +++ b/default-configs/i386-softmmu.mak
> @@ -60,3 +60,4 @@ CONFIG_SMBIOS=y
>   CONFIG_HYPERV_TESTDEV=$(CONFIG_KVM)
>   CONFIG_PXB=y
>   CONFIG_ACPI_VMGENID=y
> +CONFIG_FW_CFG_DMA=y
> diff --git a/default-configs/x86_64-softmmu.mak b/default-configs/x86_64-softmmu.mak
> index ea69e8289e..0221236825 100644
> --- a/default-configs/x86_64-softmmu.mak
> +++ b/default-configs/x86_64-softmmu.mak
> @@ -60,3 +60,4 @@ CONFIG_SMBIOS=y
>   CONFIG_HYPERV_TESTDEV=$(CONFIG_KVM)
>   CONFIG_PXB=y
>   CONFIG_ACPI_VMGENID=y
> +CONFIG_FW_CFG_DMA=y
> diff --git a/hw/misc/Makefile.objs b/hw/misc/Makefile.objs
> index 19202d90cf..10c88a84b4 100644
> --- a/hw/misc/Makefile.objs
> +++ b/hw/misc/Makefile.objs
> @@ -9,7 +9,7 @@ common-obj-$(CONFIG_PCI_TESTDEV) += pci-testdev.o
>   common-obj-$(CONFIG_EDU) += edu.o
>   
>   common-obj-y += unimp.o
> -common-obj-y += vmcoreinfo.o
> +common-obj-$(CONFIG_FW_CFG_DMA) += vmcoreinfo.o
>   
>   obj-$(CONFIG_VMPORT) += vmport.o
>
Re: [Qemu-devel] [PATCH] build-sys: restrict vmcoreinfo to fw_cfg+dma capable targets
Posted by Marc-André Lureau 6 years, 5 months ago 
Michael,

Could you pick this patch for 2.11 ?

thanks

On Mon, Nov 6, 2017 at 1:40 PM, Daniel Henrique Barboza
<danielhb@linux.vnet.ibm.com> wrote:
>
>
> On 11/06/2017 09:53 AM, Marc-André Lureau wrote:
>>
>> vmcoreinfo is built for all targets. However, it requires fw_cfg with
>> DMA operations support (write operation). Restrict vmcoreinfo exposure
>> to architectures that are supporting FW_CFG_DMA, that is arm-virt and
>> x86 only atm.
>>
>> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>> ---
>
>
> Reviewed-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com>
> Tested-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com>
>
>
>>   default-configs/arm-softmmu.mak    | 2 ++
>>   default-configs/i386-softmmu.mak   | 1 +
>>   default-configs/x86_64-softmmu.mak | 1 +
>>   hw/misc/Makefile.objs              | 2 +-
>>   4 files changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/default-configs/arm-softmmu.mak
>> b/default-configs/arm-softmmu.mak
>> index 5059d134c8..d37edc4312 100644
>> --- a/default-configs/arm-softmmu.mak
>> +++ b/default-configs/arm-softmmu.mak
>> @@ -130,3 +130,5 @@ CONFIG_SMBIOS=y
>>   CONFIG_ASPEED_SOC=y
>>   CONFIG_GPIO_KEY=y
>>   CONFIG_MSF2=y
>> +
>> +CONFIG_FW_CFG_DMA=y
>> diff --git a/default-configs/i386-softmmu.mak
>> b/default-configs/i386-softmmu.mak
>> index a685c439e7..95ac4b464a 100644
>> --- a/default-configs/i386-softmmu.mak
>> +++ b/default-configs/i386-softmmu.mak
>> @@ -60,3 +60,4 @@ CONFIG_SMBIOS=y
>>   CONFIG_HYPERV_TESTDEV=$(CONFIG_KVM)
>>   CONFIG_PXB=y
>>   CONFIG_ACPI_VMGENID=y
>> +CONFIG_FW_CFG_DMA=y
>> diff --git a/default-configs/x86_64-softmmu.mak
>> b/default-configs/x86_64-softmmu.mak
>> index ea69e8289e..0221236825 100644
>> --- a/default-configs/x86_64-softmmu.mak
>> +++ b/default-configs/x86_64-softmmu.mak
>> @@ -60,3 +60,4 @@ CONFIG_SMBIOS=y
>>   CONFIG_HYPERV_TESTDEV=$(CONFIG_KVM)
>>   CONFIG_PXB=y
>>   CONFIG_ACPI_VMGENID=y
>> +CONFIG_FW_CFG_DMA=y
>> diff --git a/hw/misc/Makefile.objs b/hw/misc/Makefile.objs
>> index 19202d90cf..10c88a84b4 100644
>> --- a/hw/misc/Makefile.objs
>> +++ b/hw/misc/Makefile.objs
>> @@ -9,7 +9,7 @@ common-obj-$(CONFIG_PCI_TESTDEV) += pci-testdev.o
>>   common-obj-$(CONFIG_EDU) += edu.o
>>     common-obj-y += unimp.o
>> -common-obj-y += vmcoreinfo.o
>> +common-obj-$(CONFIG_FW_CFG_DMA) += vmcoreinfo.o
>>     obj-$(CONFIG_VMPORT) += vmport.o
>>
>
>
>



-- 
Marc-André Lureau

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.