aio-posix: drop QEMU_AIO_POLL_MAX_NS env var

[Qemu-devel] [PATCH] aio-posix: drop QEMU_AIO_POLL_MAX_NS env var

Stefan Hajnoczi posted 1 patch 7 years, 12 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20171103154041.12617-1-stefanha@redhat.com

Test checkpatch passed

Test docker passed

Test ppc passed

Test s390x passed

util/aio-posix.c | 7 -------
1 file changed, 7 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH] aio-posix: drop QEMU_AIO_POLL_MAX_NS env var

Posted by Stefan Hajnoczi 7 years, 12 months ago

This hunk should not have been merged but I forgot to remove it.  Let's
remove it before it slips into a QEMU release.

¯\_(ツ)_/¯

Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 util/aio-posix.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/util/aio-posix.c b/util/aio-posix.c
index 5946ac09f0..1427f49b4a 100644
--- a/util/aio-posix.c
+++ b/util/aio-posix.c
@@ -701,13 +701,6 @@ bool aio_poll(AioContext *ctx, bool blocking)
 
 void aio_context_setup(AioContext *ctx)
 {
-    /* TODO remove this in final patch submission */
-    if (getenv("QEMU_AIO_POLL_MAX_NS")) {
-        fprintf(stderr, "The QEMU_AIO_POLL_MAX_NS environment variable has "
-                "been replaced with -object iothread,poll-max-ns=NUM\n");
-        exit(1);
-    }
-
 #ifdef CONFIG_EPOLL_CREATE1
     assert(!ctx->epollfd);
     ctx->epollfd = epoll_create1(EPOLL_CLOEXEC);
-- 
2.13.6

Re: [Qemu-devel] [PATCH] aio-posix: drop QEMU_AIO_POLL_MAX_NS env var

Posted by Stefan Hajnoczi 7 years, 11 months ago

On Fri, Nov 03, 2017 at 03:40:41PM +0000, Stefan Hajnoczi wrote:
> This hunk should not have been merged but I forgot to remove it.  Let's
> remove it before it slips into a QEMU release.
> 
> ¯\_(ツ)_/¯
> 
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  util/aio-posix.c | 7 -------
>  1 file changed, 7 deletions(-)

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan