Hi,

Here is a bug fix with the use of QIOChannelFile and 2 bug fixes and an
improvement to implementation of QIOChannelFile.

Regards,
Ross Lagerwall

Ross Lagerwall (4):
  migration: Don't leak IO channels
  io: Fix QIOChannelFile when creating and opening read-write
  io: Don't call close multiple times in QIOChannelFile
  io: Add /dev/fdset/ support to QIOChannelFile

 include/io/channel-file.h    |  2 +-
 io/channel-file.c            | 11 ++++-------
 migration/savevm.c           |  2 ++
 tests/test-io-channel-file.c | 29 +++++++++++++++++++++++++----
 4 files changed, 32 insertions(+), 12 deletions(-)

-- 
2.9.5

On 11/01/2017 02:25 PM, Ross Lagerwall wrote:
> Hi,
> 
> Here is a bug fix with the use of QIOChannelFile and 2 bug fixes and an
> improvement to implementation of QIOChannelFile.
> 
> Regards,
> Ross Lagerwall
> 
> Ross Lagerwall (4):
>    migration: Don't leak IO channels
>    io: Fix QIOChannelFile when creating and opening read-write
>    io: Don't call close multiple times in QIOChannelFile
>    io: Add /dev/fdset/ support to QIOChannelFile
> 
>   include/io/channel-file.h    |  2 +-
>   io/channel-file.c            | 11 ++++-------
>   migration/savevm.c           |  2 ++
>   tests/test-io-channel-file.c | 29 +++++++++++++++++++++++++----
>   4 files changed, 32 insertions(+), 12 deletions(-)
> 

Ping for reviews...

v1:
Got feedback from Daniel P. Berrange and Marc-André Lureau.

v2:
Patch 1: Unreviewed
Patch 2: Unreviewed
Patch 3: Reviewed by Marc-André Lureau
Patch 4: Reviewed by Marc-André Lureau

The patch series still applies cleanly on top of master.

Thanks,
-- 
Ross Lagerwall

On Thu, Jan 18, 2018 at 01:40:30PM +0000, Ross Lagerwall wrote:
> On 11/01/2017 02:25 PM, Ross Lagerwall wrote:
> > Hi,
> > 
> > Here is a bug fix with the use of QIOChannelFile and 2 bug fixes and an
> > improvement to implementation of QIOChannelFile.
> > 
> > Regards,
> > Ross Lagerwall
> > 
> > Ross Lagerwall (4):
> >    migration: Don't leak IO channels
> >    io: Fix QIOChannelFile when creating and opening read-write
> >    io: Don't call close multiple times in QIOChannelFile
> >    io: Add /dev/fdset/ support to QIOChannelFile
> > 
> >   include/io/channel-file.h    |  2 +-
> >   io/channel-file.c            | 11 ++++-------
> >   migration/savevm.c           |  2 ++
> >   tests/test-io-channel-file.c | 29 +++++++++++++++++++++++++----
> >   4 files changed, 32 insertions(+), 12 deletions(-)
> > 
> 
> Ping for reviews...
> 
> v1:
> Got feedback from Daniel P. Berrange and Marc-André Lureau.
> 
> v2:
> Patch 1: Unreviewed
> Patch 2: Unreviewed
> Patch 3: Reviewed by Marc-André Lureau
> Patch 4: Reviewed by Marc-André Lureau
> 
> The patch series still applies cleanly on top of master.

Sorry my bad for forgetting this. I'll review it now.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

On Wed, Nov 01, 2017 at 02:25:22PM +0000, Ross Lagerwall wrote:
> Hi,
> 
> Here is a bug fix with the use of QIOChannelFile and 2 bug fixes and an
> improvement to implementation of QIOChannelFile.
> 
> Regards,
> Ross Lagerwall
> 
> Ross Lagerwall (4):
>   migration: Don't leak IO channels
>   io: Fix QIOChannelFile when creating and opening read-write
>   io: Don't call close multiple times in QIOChannelFile
>   io: Add /dev/fdset/ support to QIOChannelFile

I've queued the 3 io patches, but will leave the migration one for
the migration maintainer's queue.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|