[Qemu-devel] [PATCH 3/5] target/s390x: tcg stubs

Philippe Mathieu-Daudé posted 5 patches 8 years ago
[Qemu-devel] [PATCH 3/5] target/s390x: tcg stubs
Posted by Philippe Mathieu-Daudé 8 years ago
missing since 55c3ceef61:

    LINK    s390x-softmmu/qemu-system-s390x
  target/s390x/cpu.o: In function `s390_cpu_class_init':
  target/s390x/cpu.c:500: undefined reference to `s390x_translate_init'

Suggested-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 target/s390x/tcg-stub.c    | 13 +++++++++++++
 target/s390x/Makefile.objs |  1 +
 2 files changed, 14 insertions(+)
 create mode 100644 target/s390x/tcg-stub.c

diff --git a/target/s390x/tcg-stub.c b/target/s390x/tcg-stub.c
new file mode 100644
index 0000000000..1e3ed46e89
--- /dev/null
+++ b/target/s390x/tcg-stub.c
@@ -0,0 +1,13 @@
+/*
+ * QEMU TCG support -- s390x specific function stubs.
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2 or later.
+ * See the COPYING file in the top-level directory.
+ */
+
+#include "qemu/osdep.h"
+#include "internal.h"
+
+void s390x_translate_init(void)
+{
+}
diff --git a/target/s390x/Makefile.objs b/target/s390x/Makefile.objs
index 31932de9cf..31dd498d01 100644
--- a/target/s390x/Makefile.objs
+++ b/target/s390x/Makefile.objs
@@ -1,6 +1,7 @@
 obj-y += cpu.o cpu_models.o cpu_features.o gdbstub.o interrupt.o helper.o
 obj-$(CONFIG_TCG) += translate.o cc_helper.o excp_helper.o fpu_helper.o
 obj-$(CONFIG_TCG) += int_helper.o mem_helper.o misc_helper.o crypto_helper.o
+obj-$(call lnot,$(CONFIG_TCG)) += tcg-stub.o
 obj-$(CONFIG_SOFTMMU) += machine.o ioinst.o arch_dump.o mmu_helper.o diag.o
 obj-$(CONFIG_SOFTMMU) += sigp.o
 obj-$(CONFIG_KVM) += kvm.o
-- 
2.15.0.rc2


Re: [Qemu-devel] [PATCH 3/5] target/s390x: tcg stubs
Posted by Thomas Huth 8 years ago
On 30.10.2017 04:05, Philippe Mathieu-Daudé wrote:
> missing since 55c3ceef61:
> 
>     LINK    s390x-softmmu/qemu-system-s390x
>   target/s390x/cpu.o: In function `s390_cpu_class_init':
>   target/s390x/cpu.c:500: undefined reference to `s390x_translate_init'
> 
> Suggested-by: Eduardo Habkost <ehabkost@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

This is fixed already by 74d7fc7f6385158b8a5c524c61baaef1b66f3dac
("tcg: Avoid setting tcg_initialize if !CONFIG_TCG"), so please drop
this patch.

 Thomas