On 10/27/2017 03:14 PM, Daniel P. Berrange wrote:
> I've sent a variety of improvements to submodule handling as separate patches
> and its getting slightly confusing. So here is a series with all patches added
> together. I've also included a fix that helps us go backwards in time across
> the introduction of a submodule.
>
> Daniel P. Berrange (4):
> build: allow setting a custom GIT binary for transparent proxying
> build: don't create temporary files in source dir
> build: allow automatic git submodule updates to be disabled
> build: don't fail if given a git submodule which does not exist
I have some minor comments on a couple of individual patches, but for
the series:
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> Makefile | 15 ++++++++++--
> configure | 14 +++++++++++-
> scripts/git-submodule.sh | 59 ++++++++++++++++++++++++++++++++++++++++--------
> 3 files changed, 76 insertions(+), 12 deletions(-)
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org