[Qemu-devel] [PATCH v2 0/4] tpm: add stubs to fix compiling with --disable-tpm

Philippe Mathieu-Daudé posted 4 patches 6 years, 6 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20171024122045.30072-1-f4bug@amsat.org
Test checkpatch passed
Test docker passed
Test s390x passed
Makefile.objs        |  2 +-
include/sysemu/tpm.h |  1 +
stubs/tpm.c          | 33 +++++++++++++++++++++++++++++++++
tpm.c                |  4 ----
vl.c                 |  2 --
MAINTAINERS          |  1 +
stubs/Makefile.objs  |  1 +
7 files changed, 37 insertions(+), 7 deletions(-)
create mode 100644 stubs/tpm.c
[Qemu-devel] [PATCH v2 0/4] tpm: add stubs to fix compiling with --disable-tpm
Posted by Philippe Mathieu-Daudé 6 years, 6 months ago
This fixes building with --disable-tpm as reported by Zoltan:
  http://lists.nongnu.org/archive/html/qemu-devel/2017-10/msg05369.html

Cc'ing Peter in case this enters as a build fix instead of via trivial.

v2:
- added Richard W.M. Jones Tested-by tag
- remove #ifdef CONFIG_TPM in tpm.c (Stefan Berger)

Regards,

Phil.

PD: I missed Amarnath Valluri in my first series, you might want to add yourself
    a R: tag in MAINTAINTERS.
    
Philippe Mathieu-Daudé (4):
  tpm: add missing include
  tpm: add stubs
  tpm: remove unnecessary #ifdef CONFIG_TPM
  vl: remove unnecessary #ifdef CONFIG_TPM

 Makefile.objs        |  2 +-
 include/sysemu/tpm.h |  1 +
 stubs/tpm.c          | 33 +++++++++++++++++++++++++++++++++
 tpm.c                |  4 ----
 vl.c                 |  2 --
 MAINTAINERS          |  1 +
 stubs/Makefile.objs  |  1 +
 7 files changed, 37 insertions(+), 7 deletions(-)
 create mode 100644 stubs/tpm.c

-- 
2.15.0.rc1


Re: [Qemu-devel] [PATCH v2 0/4] tpm: add stubs to fix compiling with --disable-tpm
Posted by Richard W.M. Jones 6 years, 6 months ago
On Tue, Oct 24, 2017 at 09:20:41AM -0300, Philippe Mathieu-Daudé wrote:
> This fixes building with --disable-tpm as reported by Zoltan:
>   http://lists.nongnu.org/archive/html/qemu-devel/2017-10/msg05369.html
> 
> Cc'ing Peter in case this enters as a build fix instead of via trivial.
> 
> v2:
> - added Richard W.M. Jones Tested-by tag
> - remove #ifdef CONFIG_TPM in tpm.c (Stefan Berger)

Can confirm v2 works as well.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/

Re: [Qemu-devel] [PATCH v2 0/4] tpm: add stubs to fix compiling with --disable-tpm
Posted by Philippe Mathieu-Daudé 6 years, 6 months ago
>> v2:
>> - added Richard W.M. Jones Tested-by tag
>> - remove #ifdef CONFIG_TPM in tpm.c (Stefan Berger)
> 
> Can confirm v2 works as well.

Thanks for testing!

Re: [Qemu-devel] [PATCH v2 0/4] tpm: add stubs to fix compiling with --disable-tpm
Posted by Amarnath Valluri 6 years, 6 months ago
On Tue, 2017-10-24 at 09:20 -0300, Philippe Mathieu-Daudé wrote:
> This fixes building with --disable-tpm as reported by Zoltan:
>   http://lists.nongnu.org/archive/html/qemu-devel/2017-10/msg05369.html
> 
> Cc'ing Peter in case this enters as a build fix instead of via trivial.
> 
> v2:
> - added Richard W.M. Jones Tested-by tag
> - remove #ifdef CONFIG_TPM in tpm.c (Stefan Berger)
> 
> Regards,
> 
> Phil.
> 
> PD: I missed Amarnath Valluri in my first series, you might want to add yourself
>     a R: tag in MAINTAINTERS.
>     
> Philippe Mathieu-Daudé (4):
>   tpm: add missing include
>   tpm: add stubs
>   tpm: remove unnecessary #ifdef CONFIG_TPM
>   vl: remove unnecessary #ifdef CONFIG_TPM
> 
>  Makefile.objs        |  2 +-
>  include/sysemu/tpm.h |  1 +
>  stubs/tpm.c          | 33 +++++++++++++++++++++++++++++++++
>  tpm.c                |  4 ----
>  vl.c                 |  2 --
>  MAINTAINERS          |  1 +
>  stubs/Makefile.objs  |  1 +
>  7 files changed, 37 insertions(+), 7 deletions(-)
>  create mode 100644 stubs/tpm.c
> 
+1, Nice cleanup in my opinion, now it looks much cleaner.

- Amarnath


Re: [Qemu-devel] [PATCH v2 0/4] tpm: add stubs to fix compiling with --disable-tpm
Posted by Philippe Mathieu-Daudé 6 years, 6 months ago
Hi Amarnath,

On 10/24/2017 03:19 PM, Amarnath Valluri wrote:
> On Tue, 2017-10-24 at 09:20 -0300, Philippe Mathieu-Daudé wrote:
>> This fixes building with --disable-tpm as reported by Zoltan:
>>   http://lists.nongnu.org/archive/html/qemu-devel/2017-10/msg05369.html
[...]
> +1, Nice cleanup in my opinion, now it looks much cleaner.

Thanks, however I'm not sure what a +1 means, is it equivalent to an
Acked-by or a Reviewed-by tag? If so it would be better to write them
explicitly.

Regards,

Phil.