[Qemu-devel] [PATCH v5 2/8] aspeed: remove ignore_memory_transaction_failures all boards

Cédric Le Goater posted 8 patches 8 years, 3 months ago
There is a newer version of this series
[Qemu-devel] [PATCH v5 2/8] aspeed: remove ignore_memory_transaction_failures all boards
Posted by Cédric Le Goater 8 years, 3 months ago
Now that we have a dummy ROM device catching the invalid writes, we
can remove this flag and work on fixing the current firwmares still
accessing unimplemented addresses.

Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 hw/arm/aspeed.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
index d88a8b5120b6..91c23968f685 100644
--- a/hw/arm/aspeed.c
+++ b/hw/arm/aspeed.c
@@ -288,7 +288,6 @@ static void palmetto_bmc_class_init(ObjectClass *oc, void *data)
     mc->no_floppy = 1;
     mc->no_cdrom = 1;
     mc->no_parallel = 1;
-    mc->ignore_memory_transaction_failures = true;
 }
 
 static const TypeInfo palmetto_bmc_type = {
@@ -321,7 +320,6 @@ static void ast2500_evb_class_init(ObjectClass *oc, void *data)
     mc->no_floppy = 1;
     mc->no_cdrom = 1;
     mc->no_parallel = 1;
-    mc->ignore_memory_transaction_failures = true;
 }
 
 static const TypeInfo ast2500_evb_type = {
@@ -346,7 +344,6 @@ static void romulus_bmc_class_init(ObjectClass *oc, void *data)
     mc->no_floppy = 1;
     mc->no_cdrom = 1;
     mc->no_parallel = 1;
-    mc->ignore_memory_transaction_failures = true;
 }
 
 static const TypeInfo romulus_bmc_type = {
-- 
2.13.6


Re: [Qemu-devel] [PATCH v5 2/8] aspeed: remove ignore_memory_transaction_failures all boards
Posted by Peter Maydell 8 years, 3 months ago
On 19 October 2017 at 16:12, Cédric Le Goater <clg@kaod.org> wrote:
> Now that we have a dummy ROM device catching the invalid writes, we
> can remove this flag and work on fixing the current firwmares still
> accessing unimplemented addresses.
>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM