use g_new() family of functions

[Qemu-devel] [PATCH 44/88] hw/core/loader: use g_new() family of functions

Posted by Philippe Mathieu-Daudé 8 years, 4 months ago

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 hw/core/loader.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/hw/core/loader.c b/hw/core/loader.c
index 4593061445..def4766dbb 100644
--- a/hw/core/loader.c
+++ b/hw/core/loader.c
@@ -899,7 +899,7 @@ int rom_add_file(const char *file, const char *fw_dir,
         return -1;
     }
 
-    rom = g_malloc0(sizeof(*rom));
+    rom = g_new0(Rom, 1);
     rom->name = g_strdup(file);
     rom->path = qemu_find_file(QEMU_FILE_TYPE_BIOS, rom->name);
     rom->as = as;
@@ -996,7 +996,7 @@ MemoryRegion *rom_add_blob(const char *name, const void *blob, size_t len,
     Rom *rom;
     MemoryRegion *mr = NULL;
 
-    rom           = g_malloc0(sizeof(*rom));
+    rom           = g_new0(Rom, 1);
     rom->name     = g_strdup(name);
     rom->as       = as;
     rom->addr     = addr;
@@ -1039,7 +1039,7 @@ int rom_add_elf_program(const char *name, void *data, size_t datasize,
 {
     Rom *rom;
 
-    rom           = g_malloc0(sizeof(*rom));
+    rom = g_new0(Rom, 1);
     rom->name     = g_strdup(name);
     rom->addr     = addr;
     rom->datasize = datasize;
-- 
2.14.2

Re: [Qemu-devel] [PATCH 44/88] hw/core/loader: use g_new() family of functions

Posted by Alistair Francis 8 years, 4 months ago

On Fri, Oct 6, 2017 at 4:49 PM, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Reviewed-by: Alistair Francis <alistair.francis@xilinx.com>

Thanks,
Alistair

> ---
>  hw/core/loader.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/core/loader.c b/hw/core/loader.c
> index 4593061445..def4766dbb 100644
> --- a/hw/core/loader.c
> +++ b/hw/core/loader.c
> @@ -899,7 +899,7 @@ int rom_add_file(const char *file, const char *fw_dir,
>          return -1;
>      }
>
> -    rom = g_malloc0(sizeof(*rom));
> +    rom = g_new0(Rom, 1);
>      rom->name = g_strdup(file);
>      rom->path = qemu_find_file(QEMU_FILE_TYPE_BIOS, rom->name);
>      rom->as = as;
> @@ -996,7 +996,7 @@ MemoryRegion *rom_add_blob(const char *name, const void *blob, size_t len,
>      Rom *rom;
>      MemoryRegion *mr = NULL;
>
> -    rom           = g_malloc0(sizeof(*rom));
> +    rom           = g_new0(Rom, 1);
>      rom->name     = g_strdup(name);
>      rom->as       = as;
>      rom->addr     = addr;
> @@ -1039,7 +1039,7 @@ int rom_add_elf_program(const char *name, void *data, size_t datasize,
>  {
>      Rom *rom;
>
> -    rom           = g_malloc0(sizeof(*rom));
> +    rom = g_new0(Rom, 1);
>      rom->name     = g_strdup(name);
>      rom->addr     = addr;
>      rom->datasize = datasize;
> --
> 2.14.2
>
>