From: Markus Armbruster <armbru@redhat.com>

Screwed up in commit da76ee7.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20171002134538.23332-2-armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
 hmp-commands-info.hx | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx
index 4f1ece93e5..574db7d24e 100644
--- a/hmp-commands-info.hx
+++ b/hmp-commands-info.hx
@@ -730,8 +730,8 @@ ETEXI
     },
 
 STEXI
-@item info rocker_ports @var{name}-ports
-@findex ocker-ports
+@item info rocker-ports @var{name}-ports
+@findex rocker-ports
 Show rocker ports.
 ETEXI
 
@@ -744,7 +744,7 @@ ETEXI
     },
 
 STEXI
-@item info rocker_of_dpa_flows @var{name} [@var{tbl_id}]
+@item info rocker-of-dpa-flows @var{name} [@var{tbl_id}]
 @findex rocker-of-dpa-flows
 Show rocker OF-DPA flow tables.
 ETEXI
-- 
2.13.6

On 05/10/2017 12:51, Dr. David Alan Gilbert (git) wrote:
> From: Markus Armbruster <armbru@redhat.com>
> 
> Screwed up in commit da76ee7.

Let me introduce you to these two aliases:

        whatis = "show -s --pretty='tformat:%h (\"%s\", %cd)' --date=short"
        pwhatis = "show -s --pretty='tformat:%h, \"%s\", %cd' --date=short"

$ git whatis da76ee7
da76ee76f7 ("hmp-commands-info: move info_cmds content out of monitor.c", 2015-09-16)

pwhatis is more appropriate if you are including the commit at the end
of a parenthetical remark, like

   ... (see commit message for 53ec73e, "block: Use bdrv_drain to
   replace uncessary bdrv_drain_all", 2015-07-07).

Paolo

> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Message-Id: <20171002134538.23332-2-armbru@redhat.com>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---

* Paolo Bonzini (pbonzini@redhat.com) wrote:
> On 05/10/2017 12:51, Dr. David Alan Gilbert (git) wrote:
> > From: Markus Armbruster <armbru@redhat.com>
> > 
> > Screwed up in commit da76ee7.
> 
> Let me introduce you to these two aliases:
> 
>         whatis = "show -s --pretty='tformat:%h (\"%s\", %cd)' --date=short"
>         pwhatis = "show -s --pretty='tformat:%h, \"%s\", %cd' --date=short"
> 
> $ git whatis da76ee7
> da76ee76f7 ("hmp-commands-info: move info_cmds content out of monitor.c", 2015-09-16)
> 
> pwhatis is more appropriate if you are including the commit at the end
> of a parenthetical remark, like
> 
>    ... (see commit message for 53ec73e, "block: Use bdrv_drain to
>    replace uncessary bdrv_drain_all", 2015-07-07).

Ah well, that was just Markus's message; personally I'd
uses a 
Fixes: da76ee7

then we've got a chance of automation.

Dave

> Paolo
> 
> > Signed-off-by: Markus Armbruster <armbru@redhat.com>
> > Message-Id: <20171002134538.23332-2-armbru@redhat.com>
> > Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> > Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> > Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> > ---
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

Paolo Bonzini <pbonzini@redhat.com> writes:

> On 05/10/2017 12:51, Dr. David Alan Gilbert (git) wrote:
>> From: Markus Armbruster <armbru@redhat.com>
>> 
>> Screwed up in commit da76ee7.
>
> Let me introduce you to these two aliases:
>
>         whatis = "show -s --pretty='tformat:%h (\"%s\", %cd)' --date=short"
>         pwhatis = "show -s --pretty='tformat:%h, \"%s\", %cd' --date=short"
>
> $ git whatis da76ee7
> da76ee76f7 ("hmp-commands-info: move info_cmds content out of monitor.c", 2015-09-16)
>
> pwhatis is more appropriate if you are including the commit at the end
> of a parenthetical remark, like
>
>    ... (see commit message for 53ec73e, "block: Use bdrv_drain to
>    replace uncessary bdrv_drain_all", 2015-07-07).

Heh, nice way to call out my laziness ;)  Thanks!