[Qemu-devel] [PATCH v1 01/12] HACK: use objdump disas

Richard Henderson posted 12 patches 8 years, 4 months ago
There is a newer version of this series
[Qemu-devel] [PATCH v1 01/12] HACK: use objdump disas
Posted by Richard Henderson 8 years, 4 months ago
---
 disas.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/disas.c b/disas.c
index d6a1eb9c8e..69069a85ca 100644
--- a/disas.c
+++ b/disas.c
@@ -231,7 +231,7 @@ void target_disas(FILE *out, CPUState *cpu, target_ulong code,
     s.info.disassembler_options = (char *)"any";
     s.info.print_insn = print_insn_ppc;
 #endif
-    if (s.info.print_insn == NULL) {
+    if (1 || s.info.print_insn == NULL) {
         s.info.print_insn = print_insn_od_target;
     }
 
-- 
2.13.6


Re: [Qemu-devel] [Qemu-arm] [PATCH v1 01/12] HACK: use objdump disas
Posted by Alex Bennée 8 years, 2 months ago
Richard Henderson <richard.henderson@linaro.org> writes:

> ---
>  disas.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/disas.c b/disas.c
> index d6a1eb9c8e..69069a85ca 100644
> --- a/disas.c
> +++ b/disas.c
> @@ -231,7 +231,7 @@ void target_disas(FILE *out, CPUState *cpu, target_ulong code,
>      s.info.disassembler_options = (char *)"any";
>      s.info.print_insn = print_insn_ppc;
>  #endif
> -    if (s.info.print_insn == NULL) {
> +    if (1 || s.info.print_insn == NULL) {
>          s.info.print_insn = print_insn_od_target;
>      }

Because? Is this being droppped now for capstone?

--
Alex Bennée

Re: [Qemu-devel] [Qemu-arm] [PATCH v1 01/12] HACK: use objdump disas
Posted by Richard Henderson 8 years, 2 months ago
On 11/13/2017 12:33 PM, Alex Bennée wrote:
>> -    if (s.info.print_insn == NULL) {
>> +    if (1 || s.info.print_insn == NULL) {
>>          s.info.print_insn = print_insn_od_target;
>>      }
> 
> Because? Is this being droppped now for capstone?

Heh.  Since you mention it, capstone can't handle ARMv8.x, x > 0 either.  This
was so that I could pass the data through binutils master, which does support v8.3.

Obviously it won't go in, but...


r~