[Qemu-devel] [PATCH v9 01/12] qapi: Fix grammar in x-multifd-page-count descriptions

Juan Quintela posted 12 patches 8 years, 4 months ago
There is a newer version of this series
[Qemu-devel] [PATCH v9 01/12] qapi: Fix grammar in x-multifd-page-count descriptions
Posted by Juan Quintela 8 years, 4 months ago
Reported-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 qapi/migration.json | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/qapi/migration.json b/qapi/migration.json
index f8b365e3f5..d94d6c0e46 100644
--- a/qapi/migration.json
+++ b/qapi/migration.json
@@ -471,7 +471,7 @@
 #                     number of sockets used for migration.  The
 #                     default value is 2 (since 2.11)
 #
-# @x-multifd-page-count: Number of pages sent together to a thread
+# @x-multifd-page-count: Number of pages sent together to a thread.
 #                        The default value is 16 (since 2.11)
 #
 # Since: 2.4
@@ -542,7 +542,7 @@
 #                     number of sockets used for migration.  The
 #                     default value is 2 (since 2.11)
 #
-# @x-multifd-page-count: Number of pages sent together to a thread
+# @x-multifd-page-count: Number of pages sent together to a thread.
 #                        The default value is 16 (since 2.11)
 #
 # Since: 2.4
@@ -638,7 +638,7 @@
 #                     number of sockets used for migration.
 #                     The default value is 2 (since 2.11)
 #
-# @x-multifd-page-count: Number of pages sent together to a thread
+# @x-multifd-page-count: Number of pages sent together to a thread.
 #                        The default value is 16 (since 2.11)
 #
 # Since: 2.4
-- 
2.13.5


Re: [Qemu-devel] [PATCH v9 01/12] qapi: Fix grammar in x-multifd-page-count descriptions
Posted by Dr. David Alan Gilbert 8 years, 3 months ago
* Juan Quintela (quintela@redhat.com) wrote:
> Reported-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Juan Quintela <quintela@redhat.com>

This should just go separately to trivial.

> ---
>  qapi/migration.json | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/qapi/migration.json b/qapi/migration.json
> index f8b365e3f5..d94d6c0e46 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -471,7 +471,7 @@
>  #                     number of sockets used for migration.  The
>  #                     default value is 2 (since 2.11)

I wonder if we need a '.' after the 2 and 16 in this set as well.
(Personally I'm not that fussy).

>  #
> -# @x-multifd-page-count: Number of pages sent together to a thread
> +# @x-multifd-page-count: Number of pages sent together to a thread.
>  #                        The default value is 16 (since 2.11)
>  #
>  # Since: 2.4
> @@ -542,7 +542,7 @@
>  #                     number of sockets used for migration.  The
>  #                     default value is 2 (since 2.11)
>  #
> -# @x-multifd-page-count: Number of pages sent together to a thread
> +# @x-multifd-page-count: Number of pages sent together to a thread.
>  #                        The default value is 16 (since 2.11)
>  #
>  # Since: 2.4
> @@ -638,7 +638,7 @@
>  #                     number of sockets used for migration.
>  #                     The default value is 2 (since 2.11)
>  #
> -# @x-multifd-page-count: Number of pages sent together to a thread
> +# @x-multifd-page-count: Number of pages sent together to a thread.
>  #                        The default value is 16 (since 2.11)
>  #

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

>  # Since: 2.4
> -- 
> 2.13.5
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK