1. Patchew
  2. QEMU
  3. View series

[Qemu-devel] [PATCH] egl: misc framebuffer helper improvements.

Gerd Hoffmann posted 1 patch 6 years, 6 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170927115031.12063-1-kraxel@redhat.com
Test checkpatch passed
Test docker passed
Test s390x passed
include/ui/egl-helpers.h |  5 +++--
ui/egl-headless.c        |  6 +++---
ui/egl-helpers.c         | 26 ++++++++++++++++++--------
ui/gtk-egl.c             |  4 ++--
ui/gtk-gl-area.c         |  4 ++--
ui/sdl2-gl.c             |  4 ++--
6 files changed, 30 insertions(+), 19 deletions(-)
[Qemu-devel] [PATCH] egl: misc framebuffer helper improvements.
Posted by Gerd Hoffmann 6 years, 6 months ago 
Rename the functions to to say "setup" instead of "create" because they
support being called multiple times on the same egl framebuffer.

Properly delete unused textures, update function interfaces to support
this.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 include/ui/egl-helpers.h |  5 +++--
 ui/egl-headless.c        |  6 +++---
 ui/egl-helpers.c         | 26 ++++++++++++++++++--------
 ui/gtk-egl.c             |  4 ++--
 ui/gtk-gl-area.c         |  4 ++--
 ui/sdl2-gl.c             |  4 ++--
 6 files changed, 30 insertions(+), 19 deletions(-)

diff --git a/include/ui/egl-helpers.h b/include/ui/egl-helpers.h
index be8908737c..81cb255de0 100644
--- a/include/ui/egl-helpers.h
+++ b/include/ui/egl-helpers.h
@@ -18,8 +18,9 @@ typedef struct egl_fb {
 
 void egl_fb_destroy(egl_fb *fb);
 void egl_fb_setup_default(egl_fb *fb, int width, int height);
-void egl_fb_create_for_tex(egl_fb *fb, int width, int height, GLuint texture);
-void egl_fb_create_new_tex(egl_fb *fb, int width, int height);
+void egl_fb_setup_for_tex(egl_fb *fb, int width, int height,
+                          GLuint texture, bool delete);
+void egl_fb_setup_new_tex(egl_fb *fb, int width, int height);
 void egl_fb_blit(egl_fb *dst, egl_fb *src, bool flip);
 void egl_fb_read(void *dst, egl_fb *src);
 
diff --git a/ui/egl-headless.c b/ui/egl-headless.c
index 809bfde99c..12ad64e995 100644
--- a/ui/egl-headless.c
+++ b/ui/egl-headless.c
@@ -54,14 +54,14 @@ static void egl_scanout_texture(DisplayChangeListener *dcl,
     edpy->y_0_top = backing_y_0_top;
 
     /* source framebuffer */
-    egl_fb_create_for_tex(&edpy->guest_fb,
-                          backing_width, backing_height, backing_id);
+    egl_fb_setup_for_tex(&edpy->guest_fb,
+                         backing_width, backing_height, backing_id, false);
 
     /* dest framebuffer */
     if (edpy->blit_fb.width  != backing_width ||
         edpy->blit_fb.height != backing_height) {
         egl_fb_destroy(&edpy->blit_fb);
-        egl_fb_create_new_tex(&edpy->blit_fb, backing_width, backing_height);
+        egl_fb_setup_new_tex(&edpy->blit_fb, backing_width, backing_height);
     }
 }
 
diff --git a/ui/egl-helpers.c b/ui/egl-helpers.c
index bb19a5eeca..cde9965dea 100644
--- a/ui/egl-helpers.c
+++ b/ui/egl-helpers.c
@@ -26,16 +26,23 @@ EGLConfig qemu_egl_config;
 
 /* ------------------------------------------------------------------ */
 
+static void egl_fb_delete_texture(egl_fb *fb)
+{
+    if (!fb->delete_texture) {
+        return;
+    }
+
+    glDeleteTextures(1, &fb->texture);
+    fb->delete_texture = false;
+}
+
 void egl_fb_destroy(egl_fb *fb)
 {
     if (!fb->framebuffer) {
         return;
     }
 
-    if (fb->delete_texture) {
-        glDeleteTextures(1, &fb->texture);
-        fb->delete_texture = false;
-    }
+    egl_fb_delete_texture(fb);
     glDeleteFramebuffers(1, &fb->framebuffer);
 
     fb->width = 0;
@@ -51,11 +58,15 @@ void egl_fb_setup_default(egl_fb *fb, int width, int height)
     fb->framebuffer = 0; /* default framebuffer */
 }
 
-void egl_fb_create_for_tex(egl_fb *fb, int width, int height, GLuint texture)
+void egl_fb_setup_for_tex(egl_fb *fb, int width, int height,
+                          GLuint texture, bool delete)
 {
+    egl_fb_delete_texture(fb);
+
     fb->width = width;
     fb->height = height;
     fb->texture = texture;
+    fb->delete_texture = delete;
     if (!fb->framebuffer) {
         glGenFramebuffers(1, &fb->framebuffer);
     }
@@ -65,7 +76,7 @@ void egl_fb_create_for_tex(egl_fb *fb, int width, int height, GLuint texture)
                               GL_TEXTURE_2D, fb->texture, 0);
 }
 
-void egl_fb_create_new_tex(egl_fb *fb, int width, int height)
+void egl_fb_setup_new_tex(egl_fb *fb, int width, int height)
 {
     GLuint texture;
 
@@ -74,8 +85,7 @@ void egl_fb_create_new_tex(egl_fb *fb, int width, int height)
     glTexImage2D(GL_TEXTURE_2D, 0, GL_RGB, width, height,
                  0, GL_BGRA, GL_UNSIGNED_BYTE, 0);
 
-    egl_fb_create_for_tex(fb, width, height, texture);
-    fb->delete_texture = true;
+    egl_fb_setup_for_tex(fb, width, height, texture, true);
 }
 
 void egl_fb_blit(egl_fb *dst, egl_fb *src, bool flip)
diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c
index 0d5cab2bc8..0f0d35e041 100644
--- a/ui/gtk-egl.c
+++ b/ui/gtk-egl.c
@@ -190,8 +190,8 @@ void gd_egl_scanout_texture(DisplayChangeListener *dcl,
                    vc->gfx.esurface, vc->gfx.ectx);
 
     gtk_egl_set_scanout_mode(vc, true);
-    egl_fb_create_for_tex(&vc->gfx.guest_fb, backing_width, backing_height,
-                          backing_id);
+    egl_fb_setup_for_tex(&vc->gfx.guest_fb, backing_width, backing_height,
+                         backing_id, false);
 }
 
 void gd_egl_scanout_flush(DisplayChangeListener *dcl,
diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c
index 18b298fc21..01ebf2c7de 100644
--- a/ui/gtk-gl-area.c
+++ b/ui/gtk-gl-area.c
@@ -185,8 +185,8 @@ void gd_gl_area_scanout_texture(DisplayChangeListener *dcl,
     }
 
     gtk_gl_area_set_scanout_mode(vc, true);
-    egl_fb_create_for_tex(&vc->gfx.guest_fb, backing_width, backing_height,
-                          backing_id);
+    egl_fb_setup_for_tex(&vc->gfx.guest_fb, backing_width, backing_height,
+                         backing_id, false);
 }
 
 void gd_gl_area_scanout_flush(DisplayChangeListener *dcl,
diff --git a/ui/sdl2-gl.c b/ui/sdl2-gl.c
index dcad3d0d26..9110491ee5 100644
--- a/ui/sdl2-gl.c
+++ b/ui/sdl2-gl.c
@@ -207,8 +207,8 @@ void sdl2_gl_scanout_texture(DisplayChangeListener *dcl,
     SDL_GL_MakeCurrent(scon->real_window, scon->winctx);
 
     sdl2_set_scanout_mode(scon, true);
-    egl_fb_create_for_tex(&scon->guest_fb, backing_width, backing_height,
-                          backing_id);
+    egl_fb_setup_for_tex(&scon->guest_fb, backing_width, backing_height,
+                         backing_id, false);
 }
 
 void sdl2_gl_scanout_flush(DisplayChangeListener *dcl,
-- 
2.9.3
Re: [Qemu-devel] [PATCH] egl: misc framebuffer helper improvements.
Posted by Philippe Mathieu-Daudé 6 years, 6 months ago 
On 09/27/2017 08:50 AM, Gerd Hoffmann wrote:
> Rename the functions to to say "setup" instead of "create" because they
> support being called multiple times on the same egl framebuffer.
> 
> Properly delete unused textures, update function interfaces to support
> this.
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>   include/ui/egl-helpers.h |  5 +++--
>   ui/egl-headless.c        |  6 +++---
>   ui/egl-helpers.c         | 26 ++++++++++++++++++--------
>   ui/gtk-egl.c             |  4 ++--
>   ui/gtk-gl-area.c         |  4 ++--
>   ui/sdl2-gl.c             |  4 ++--
>   6 files changed, 30 insertions(+), 19 deletions(-)
> 
> diff --git a/include/ui/egl-helpers.h b/include/ui/egl-helpers.h
> index be8908737c..81cb255de0 100644
> --- a/include/ui/egl-helpers.h
> +++ b/include/ui/egl-helpers.h
> @@ -18,8 +18,9 @@ typedef struct egl_fb {
>   
>   void egl_fb_destroy(egl_fb *fb);
>   void egl_fb_setup_default(egl_fb *fb, int width, int height);
> -void egl_fb_create_for_tex(egl_fb *fb, int width, int height, GLuint texture);
> -void egl_fb_create_new_tex(egl_fb *fb, int width, int height);
> +void egl_fb_setup_for_tex(egl_fb *fb, int width, int height,
> +                          GLuint texture, bool delete);
> +void egl_fb_setup_new_tex(egl_fb *fb, int width, int height);
>   void egl_fb_blit(egl_fb *dst, egl_fb *src, bool flip);
>   void egl_fb_read(void *dst, egl_fb *src);
>   
> diff --git a/ui/egl-headless.c b/ui/egl-headless.c
> index 809bfde99c..12ad64e995 100644
> --- a/ui/egl-headless.c
> +++ b/ui/egl-headless.c
> @@ -54,14 +54,14 @@ static void egl_scanout_texture(DisplayChangeListener *dcl,
>       edpy->y_0_top = backing_y_0_top;
>   
>       /* source framebuffer */
> -    egl_fb_create_for_tex(&edpy->guest_fb,
> -                          backing_width, backing_height, backing_id);
> +    egl_fb_setup_for_tex(&edpy->guest_fb,
> +                         backing_width, backing_height, backing_id, false);
>   
>       /* dest framebuffer */
>       if (edpy->blit_fb.width  != backing_width ||
>           edpy->blit_fb.height != backing_height) {
>           egl_fb_destroy(&edpy->blit_fb);
> -        egl_fb_create_new_tex(&edpy->blit_fb, backing_width, backing_height);
> +        egl_fb_setup_new_tex(&edpy->blit_fb, backing_width, backing_height);
>       }
>   }
>   
> diff --git a/ui/egl-helpers.c b/ui/egl-helpers.c
> index bb19a5eeca..cde9965dea 100644
> --- a/ui/egl-helpers.c
> +++ b/ui/egl-helpers.c
> @@ -26,16 +26,23 @@ EGLConfig qemu_egl_config;
>   
>   /* ------------------------------------------------------------------ */
>   
> +static void egl_fb_delete_texture(egl_fb *fb)
> +{
> +    if (!fb->delete_texture) {
> +        return;
> +    }
> +
> +    glDeleteTextures(1, &fb->texture);
> +    fb->delete_texture = false;
> +}
> +
>   void egl_fb_destroy(egl_fb *fb)
>   {
>       if (!fb->framebuffer) {
>           return;
>       }
>   
> -    if (fb->delete_texture) {
> -        glDeleteTextures(1, &fb->texture);
> -        fb->delete_texture = false;
> -    }
> +    egl_fb_delete_texture(fb);
>       glDeleteFramebuffers(1, &fb->framebuffer);
>   
>       fb->width = 0;
> @@ -51,11 +58,15 @@ void egl_fb_setup_default(egl_fb *fb, int width, int height)
>       fb->framebuffer = 0; /* default framebuffer */
>   }
>   
> -void egl_fb_create_for_tex(egl_fb *fb, int width, int height, GLuint texture)
> +void egl_fb_setup_for_tex(egl_fb *fb, int width, int height,
> +                          GLuint texture, bool delete)
>   {
> +    egl_fb_delete_texture(fb);
> +
>       fb->width = width;
>       fb->height = height;
>       fb->texture = texture;
> +    fb->delete_texture = delete;
>       if (!fb->framebuffer) {
>           glGenFramebuffers(1, &fb->framebuffer);
>       }
> @@ -65,7 +76,7 @@ void egl_fb_create_for_tex(egl_fb *fb, int width, int height, GLuint texture)
>                                 GL_TEXTURE_2D, fb->texture, 0);
>   }
>   
> -void egl_fb_create_new_tex(egl_fb *fb, int width, int height)
> +void egl_fb_setup_new_tex(egl_fb *fb, int width, int height)
>   {
>       GLuint texture;
>   
> @@ -74,8 +85,7 @@ void egl_fb_create_new_tex(egl_fb *fb, int width, int height)
>       glTexImage2D(GL_TEXTURE_2D, 0, GL_RGB, width, height,
>                    0, GL_BGRA, GL_UNSIGNED_BYTE, 0);
>   
> -    egl_fb_create_for_tex(fb, width, height, texture);
> -    fb->delete_texture = true;
> +    egl_fb_setup_for_tex(fb, width, height, texture, true);
>   }
>   
>   void egl_fb_blit(egl_fb *dst, egl_fb *src, bool flip)
> diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c
> index 0d5cab2bc8..0f0d35e041 100644
> --- a/ui/gtk-egl.c
> +++ b/ui/gtk-egl.c
> @@ -190,8 +190,8 @@ void gd_egl_scanout_texture(DisplayChangeListener *dcl,
>                      vc->gfx.esurface, vc->gfx.ectx);
>   
>       gtk_egl_set_scanout_mode(vc, true);
> -    egl_fb_create_for_tex(&vc->gfx.guest_fb, backing_width, backing_height,
> -                          backing_id);
> +    egl_fb_setup_for_tex(&vc->gfx.guest_fb, backing_width, backing_height,
> +                         backing_id, false);
>   }
>   
>   void gd_egl_scanout_flush(DisplayChangeListener *dcl,
> diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c
> index 18b298fc21..01ebf2c7de 100644
> --- a/ui/gtk-gl-area.c
> +++ b/ui/gtk-gl-area.c
> @@ -185,8 +185,8 @@ void gd_gl_area_scanout_texture(DisplayChangeListener *dcl,
>       }
>   
>       gtk_gl_area_set_scanout_mode(vc, true);
> -    egl_fb_create_for_tex(&vc->gfx.guest_fb, backing_width, backing_height,
> -                          backing_id);
> +    egl_fb_setup_for_tex(&vc->gfx.guest_fb, backing_width, backing_height,
> +                         backing_id, false);
>   }
>   
>   void gd_gl_area_scanout_flush(DisplayChangeListener *dcl,
> diff --git a/ui/sdl2-gl.c b/ui/sdl2-gl.c
> index dcad3d0d26..9110491ee5 100644
> --- a/ui/sdl2-gl.c
> +++ b/ui/sdl2-gl.c
> @@ -207,8 +207,8 @@ void sdl2_gl_scanout_texture(DisplayChangeListener *dcl,
>       SDL_GL_MakeCurrent(scon->real_window, scon->winctx);
>   
>       sdl2_set_scanout_mode(scon, true);
> -    egl_fb_create_for_tex(&scon->guest_fb, backing_width, backing_height,
> -                          backing_id);
> +    egl_fb_setup_for_tex(&scon->guest_fb, backing_width, backing_height,
> +                         backing_id, false);
>   }
>   
>   void sdl2_gl_scanout_flush(DisplayChangeListener *dcl,
>

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.