usb: Use angle brackets for cacard include directive

[Qemu-devel] [PATCH] usb: Use angle brackets for cacard include directive

Posted by Fam Zheng 6 years, 7 months ago

This is a library header, so angle brackets are more appropriate; also
move the line to before QEMU headers, as is recommended in HACKING.

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 hw/usb/ccid-card-passthru.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/usb/ccid-card-passthru.c b/hw/usb/ccid-card-passthru.c
index 45d96b03c6..117711862e 100644
--- a/hw/usb/ccid-card-passthru.c
+++ b/hw/usb/ccid-card-passthru.c
@@ -9,11 +9,11 @@
  */
 
 #include "qemu/osdep.h"
+#include <cacard/vscard_common.h>
 #include "chardev/char-fe.h"
 #include "qemu/error-report.h"
 #include "qemu/sockets.h"
 #include "ccid.h"
-#include "cacard/vscard_common.h"
 
 #define DPRINTF(card, lvl, fmt, ...)                    \
 do {                                                    \
-- 
2.13.5

Re: [Qemu-devel] [PATCH] usb: Use angle brackets for cacard include directive

Posted by Fam Zheng 6 years, 6 months ago

On Wed, 09/20 16:59, Fam Zheng wrote:
> This is a library header, so angle brackets are more appropriate; also
> move the line to before QEMU headers, as is recommended in HACKING.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  hw/usb/ccid-card-passthru.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/usb/ccid-card-passthru.c b/hw/usb/ccid-card-passthru.c
> index 45d96b03c6..117711862e 100644
> --- a/hw/usb/ccid-card-passthru.c
> +++ b/hw/usb/ccid-card-passthru.c
> @@ -9,11 +9,11 @@
>   */
>  
>  #include "qemu/osdep.h"
> +#include <cacard/vscard_common.h>
>  #include "chardev/char-fe.h"
>  #include "qemu/error-report.h"
>  #include "qemu/sockets.h"
>  #include "ccid.h"
> -#include "cacard/vscard_common.h"
>  
>  #define DPRINTF(card, lvl, fmt, ...)                    \
>  do {                                                    \
> -- 
> 2.13.5
> 
> 

Cc: qemu-trivial@nongnu.org

Re: [Qemu-devel] [PATCH] usb: Use angle brackets for cacard include directive

Posted by Gerd Hoffmann 6 years, 6 months ago

  Hi,

> Cc: qemu-trivial@nongnu.org

fyi: preparing usb request right now with this one included.

cheers,
  Gerd

Re: [Qemu-devel] [PATCH] usb: Use angle brackets for cacard include directive

Posted by Fam Zheng 6 years, 6 months ago

On Fri, 09/29 12:42, Gerd Hoffmann wrote:
>   Hi,
> 
> > Cc: qemu-trivial@nongnu.org
> 
> fyi: preparing usb request right now with this one included.

Cool, thanks!

Fam