hw/s390x/css.c | 171 +++++++++++++++++++++++++++++++++++++++++++++++-- hw/s390x/virtio-ccw.c | 156 +++++++++++++------------------------------- include/hw/s390x/css.h | 67 +++++++++++++++++++ 3 files changed, 280 insertions(+), 114 deletions(-)
Abstract -------- The objective of this series is introducing CCW IDA (indirect data access) support to our virtual channel subsystem implementation. Briefly CCW IDA can be thought of as a kind of a scatter gather support for a single CCW. If certain flags are set, the cda is to be interpreted as an address to a list which in turn holds further addresses designating the actual data. Thus the scheme which we are currently using for accessing CCW payload does not work in general case. Currently there is no immediate need for proper IDA handling (no use case), but since it IDA is a non-optional part of the architecture, the only way towards AR compliance is actually implementing IDA. Testing ------- On request the things meant for testing from v1 were factored out into a separate series (requested by Connie). Please look for the series 'tests for CCW IDA' (comming soon) or use the stuff form v1. Changelog --------- v1 --> v2 * factored out the stuff added only for testing * use g_assert instead of assert * fixed a lot's of typos * removed some TODOs addressed by another series of mine * refactored ccw_dstream_rw_ida (structured programming) * done some rewording of commit message #3 Halil Pasic (4): s390x/css: introduce css data stream s390x/css: use ccw data stream virtio-ccw: use ccw data stream s390x/css: support ccw IDA hw/s390x/css.c | 171 +++++++++++++++++++++++++++++++++++++++++++++++-- hw/s390x/virtio-ccw.c | 156 +++++++++++++------------------------------- include/hw/s390x/css.h | 67 +++++++++++++++++++ 3 files changed, 280 insertions(+), 114 deletions(-) -- 2.13.5
On Wed, 13 Sep 2017 13:50:25 +0200 Halil Pasic <pasic@linux.vnet.ibm.com> wrote: > Abstract > -------- > > The objective of this series is introducing CCW IDA (indirect data > access) support to our virtual channel subsystem implementation. Briefly > CCW IDA can be thought of as a kind of a scatter gather support for a > single CCW. If certain flags are set, the cda is to be interpreted as an > address to a list which in turn holds further addresses designating the > actual data. Thus the scheme which we are currently using for accessing > CCW payload does not work in general case. Currently there is no > immediate need for proper IDA handling (no use case), but since it IDA is > a non-optional part of the architecture, the only way towards AR > compliance is actually implementing IDA. > > Testing > ------- > > On request the things meant for testing from v1 were factored out > into a separate series (requested by Connie). Please look for > the series 'tests for CCW IDA' (comming soon) or use the stuff > form v1. Generally, looks good; currently testing it. Would not mind some R-bs :)
On 09/14/2017 11:15 AM, Cornelia Huck wrote: > On Wed, 13 Sep 2017 13:50:25 +0200 > Halil Pasic <pasic@linux.vnet.ibm.com> wrote: > >> Abstract >> -------- >> >> The objective of this series is introducing CCW IDA (indirect data >> access) support to our virtual channel subsystem implementation. Briefly >> CCW IDA can be thought of as a kind of a scatter gather support for a >> single CCW. If certain flags are set, the cda is to be interpreted as an >> address to a list which in turn holds further addresses designating the >> actual data. Thus the scheme which we are currently using for accessing >> CCW payload does not work in general case. Currently there is no >> immediate need for proper IDA handling (no use case), but since it IDA is >> a non-optional part of the architecture, the only way towards AR >> compliance is actually implementing IDA. >> >> Testing >> ------- >> >> On request the things meant for testing from v1 were factored out >> into a separate series (requested by Connie). Please look for >> the series 'tests for CCW IDA' (comming soon) or use the stuff >> form v1. > > Generally, looks good; currently testing it. > > Would not mind some R-bs :) > Many thanks for the quick review! Of course I consent to every change you have proposed to make (before applying). About the stale comments I've just sent out a patch. About the r-b's I think the guys in cc are the most likely candidates. Pierre should be back starting next week. Dong Jia I haven't seen in a while, but I don't know about anything. Of course I would happy if somebody less expected joins in. Thanks again! Halil
On Thu, 14 Sep 2017 13:02:51 +0200 Halil Pasic <pasic@linux.vnet.ibm.com> wrote: > About the r-b's I think the guys in cc are the most likely > candidates. Pierre should be back starting next week. Dong > Jia I haven't seen in a while, but I don't know about anything. Let's see what comes in, although I don't want to delay sending the next s390x pull request for too long. Probably next week or so. I'd be happy to record any tags prior to that. > Of course I would happy if somebody less expected joins in. Seconded :)
On Wed, 13 Sep 2017 13:50:25 +0200 Halil Pasic <pasic@linux.vnet.ibm.com> wrote: > Abstract > -------- > > The objective of this series is introducing CCW IDA (indirect data > access) support to our virtual channel subsystem implementation. Briefly > CCW IDA can be thought of as a kind of a scatter gather support for a > single CCW. If certain flags are set, the cda is to be interpreted as an > address to a list which in turn holds further addresses designating the > actual data. Thus the scheme which we are currently using for accessing > CCW payload does not work in general case. Currently there is no > immediate need for proper IDA handling (no use case), but since it IDA is > a non-optional part of the architecture, the only way towards AR > compliance is actually implementing IDA. Thanks, applied.
© 2016 - 2024 Red Hat, Inc.