[v4] Improve websock response / error handling

[Qemu-devel] [PATCH v4 0/3] Improve websock response / error handling

Daniel P. Berrange posted 3 patches 6 years, 7 months ago

Diff against v2 v3
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170912131847.27684-1-berrange@redhat.com

Test checkpatch passed

Test docker passed

Test s390x passed

io/channel-websock.c | 194 ++++++++++++++++++++++++++++++++++++++-------------
io/trace-events      |   2 +-
2 files changed, 145 insertions(+), 51 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v4 0/3] Improve websock response / error handling

Posted by Daniel P. Berrange 6 years, 7 months ago

A followup of:

 v1: https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg01176.html
 v2: https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg01974.html
 v3: https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg02108.html

Changed in v4:

  - Use time() instead of gettimeofday() to avoid data type
    cast problems on mingw

Changed in v3:

  - Use strftime instead of g_date_time_format

Changed in v2:

  - Drop redundant return statement
  - Drop redundant variable initialization
  - Assert that g_date_time_format is non-NULL

Daniel P. Berrange (3):
  io: send proper HTTP response for websocket errors
  io: include full error message in websocket handshake trace
  io: use case insensitive check for Connection & Upgrade websock
    headers

 io/channel-websock.c | 194 ++++++++++++++++++++++++++++++++++++++-------------
 io/trace-events      |   2 +-
 2 files changed, 145 insertions(+), 51 deletions(-)

-- 
2.13.5