Two recently added iotests are currently breaking 'check -luks',
fix the easy one and disable the hard one.

Daniel P. Berrange (2):
  iotests: rewrite 192 to use _launch_qemu to fix LUKS support
  iotests: blacklist 194 with the luks driver

 tests/qemu-iotests/192        | 23 ++++++++++++++++-------
 tests/qemu-iotests/194        |  1 +
 tests/qemu-iotests/iotests.py |  4 +++-
 3 files changed, 20 insertions(+), 8 deletions(-)

-- 
2.13.5

On 09/01/2017 05:54 AM, Daniel P. Berrange wrote:
> Two recently added iotests are currently breaking 'check -luks',
> fix the easy one and disable the hard one.
> 
> Daniel P. Berrange (2):
>   iotests: rewrite 192 to use _launch_qemu to fix LUKS support
>   iotests: blacklist 194 with the luks driver

Since both tests involve an NBD server, I can take this series through
my NBD queue.  Or, since both involve LUKS, you can push it in your next
crypto pull request.  Any preferences?

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

On Fri, Sep 01, 2017 at 09:26:30AM -0500, Eric Blake wrote:
> On 09/01/2017 05:54 AM, Daniel P. Berrange wrote:
> > Two recently added iotests are currently breaking 'check -luks',
> > fix the easy one and disable the hard one.
> > 
> > Daniel P. Berrange (2):
> >   iotests: rewrite 192 to use _launch_qemu to fix LUKS support
> >   iotests: blacklist 194 with the luks driver
> 
> Since both tests involve an NBD server, I can take this series through
> my NBD queue.  Or, since both involve LUKS, you can push it in your next
> crypto pull request.  Any preferences?

Best if either you or a block maintainer queue it i think

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

On 09/01/2017 09:33 AM, Daniel P. Berrange wrote:
> On Fri, Sep 01, 2017 at 09:26:30AM -0500, Eric Blake wrote:
>> On 09/01/2017 05:54 AM, Daniel P. Berrange wrote:
>>> Two recently added iotests are currently breaking 'check -luks',
>>> fix the easy one and disable the hard one.
>>>
>>> Daniel P. Berrange (2):
>>>   iotests: rewrite 192 to use _launch_qemu to fix LUKS support
>>>   iotests: blacklist 194 with the luks driver
>>
>> Since both tests involve an NBD server, I can take this series through
>> my NBD queue.  Or, since both involve LUKS, you can push it in your next
>> crypto pull request.  Any preferences?
> 
> Best if either you or a block maintainer queue it i think

Okay, on my NBD queue:
http://repo.or.cz/qemu/ericb.git/shortlog/refs/heads/nbd

I'll wait to see if other NBD patches land in the next few days, but
will send a pull request within a week.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

On Fri, 09/01 11:54, Daniel P. Berrange wrote:
> Two recently added iotests are currently breaking 'check -luks',
> fix the easy one and disable the hard one.

I can add -luks to the test-block series with this, thanks for the quick fix!

Tested-by: Fam Zheng <famz@redhat.com>