[Qemu-devel] [PATCH v2 9/9] AHCI: remove DPRINTF macro

John Snow posted 9 patches 8 years, 5 months ago
There is a newer version of this series
[Qemu-devel] [PATCH v2 9/9] AHCI: remove DPRINTF macro
Posted by John Snow 8 years, 5 months ago
Signed-off-by: John Snow <jsnow@redhat.com>
---
 hw/ide/ahci.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index 2e75f9b..57bb59d 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -34,17 +34,8 @@
 #include "hw/ide/pci.h"
 #include "hw/ide/ahci_internal.h"
 
-#define DEBUG_AHCI 0
 #include "trace.h"
 
-#define DPRINTF(port, fmt, ...) \
-do { \
-    if (DEBUG_AHCI) { \
-        fprintf(stderr, "ahci: %s: [%d] ", __func__, port); \
-        fprintf(stderr, fmt, ## __VA_ARGS__); \
-    } \
-} while (0)
-
 static void check_cmd(AHCIState *s, int port);
 static int handle_cmd(AHCIState *s, int port, uint8_t slot);
 static void ahci_reset_port(AHCIState *s, int port);
-- 
2.9.5


Re: [Qemu-devel] [PATCH v2 9/9] AHCI: remove DPRINTF macro
Posted by Philippe Mathieu-Daudé 8 years, 5 months ago
On 08/29/2017 05:49 PM, John Snow wrote:
> Signed-off-by: John Snow <jsnow@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>   hw/ide/ahci.c | 9 ---------
>   1 file changed, 9 deletions(-)
> 
> diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
> index 2e75f9b..57bb59d 100644
> --- a/hw/ide/ahci.c
> +++ b/hw/ide/ahci.c
> @@ -34,17 +34,8 @@
>   #include "hw/ide/pci.h"
>   #include "hw/ide/ahci_internal.h"
>   
> -#define DEBUG_AHCI 0
>   #include "trace.h"
>   
> -#define DPRINTF(port, fmt, ...) \
> -do { \
> -    if (DEBUG_AHCI) { \
> -        fprintf(stderr, "ahci: %s: [%d] ", __func__, port); \
> -        fprintf(stderr, fmt, ## __VA_ARGS__); \
> -    } \
> -} while (0)
> -
>   static void check_cmd(AHCIState *s, int port);
>   static int handle_cmd(AHCIState *s, int port, uint8_t slot);
>   static void ahci_reset_port(AHCIState *s, int port);
>