[v2] vhost-user-bridge reconnect regression

[Qemu-devel] [PATCH v2 0/2] vhost-user-bridge reconnect regression

Posted by Marc-André Lureau 8 years, 2 months ago

Hi,

libvhost-user doesn't support resuming with the same trick vubr had
since commit 523b018dde3b7650fe5401d0499b30cf2f117515. The following
two patches fix that regression.

Thanks

Marc-André Lureau (2):
  libvhost-user: support resuming vq->last_avail_idx based on used_idx
  vhost-user-bridge: fix resume regression (since 2.9)

 contrib/libvhost-user/libvhost-user.h |  7 +++++++
 contrib/libvhost-user/libvhost-user.c | 13 +++++++++++++
 tests/vhost-user-bridge.c             |  7 +++++++
 3 files changed, 27 insertions(+)

-- 
2.14.1.146.gd35faa819

Re: [Qemu-devel] [PATCH v2 0/2] vhost-user-bridge reconnect regression

Posted by Michael S. Tsirkin 8 years, 2 months ago

On Tue, Aug 29, 2017 at 05:27:49PM +0200, Marc-André Lureau wrote:
> Hi,
> 
> libvhost-user doesn't support resuming with the same trick vubr had
> since commit 523b018dde3b7650fe5401d0499b30cf2f117515. The following
> two patches fix that regression.


Thanks! Do we need this in 2.10? If not pls ping after 2.10 is out.

> Thanks
> 
> Marc-André Lureau (2):
>   libvhost-user: support resuming vq->last_avail_idx based on used_idx
>   vhost-user-bridge: fix resume regression (since 2.9)
> 
>  contrib/libvhost-user/libvhost-user.h |  7 +++++++
>  contrib/libvhost-user/libvhost-user.c | 13 +++++++++++++
>  tests/vhost-user-bridge.c             |  7 +++++++
>  3 files changed, 27 insertions(+)
> 
> -- 
> 2.14.1.146.gd35faa819

Re: [Qemu-devel] [PATCH v2 0/2] vhost-user-bridge reconnect regression

Posted by Marc-André Lureau 8 years, 2 months ago

Hi

On Tue, Aug 29, 2017 at 5:34 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> On Tue, Aug 29, 2017 at 05:27:49PM +0200, Marc-André Lureau wrote:
>> Hi,
>>
>> libvhost-user doesn't support resuming with the same trick vubr had
>> since commit 523b018dde3b7650fe5401d0499b30cf2f117515. The following
>> two patches fix that regression.
>
>
> Thanks! Do we need this in 2.10? If not pls ping after 2.10 is out.

I think it's not necessary since the regression appeared in 2.9
already, and it's a manual test.

I'll ping after 2.10

>
>> Thanks
>>
>> Marc-André Lureau (2):
>>   libvhost-user: support resuming vq->last_avail_idx based on used_idx
>>   vhost-user-bridge: fix resume regression (since 2.9)
>>
>>  contrib/libvhost-user/libvhost-user.h |  7 +++++++
>>  contrib/libvhost-user/libvhost-user.c | 13 +++++++++++++
>>  tests/vhost-user-bridge.c             |  7 +++++++
>>  3 files changed, 27 insertions(+)
>>
>> --
>> 2.14.1.146.gd35faa819
>



-- 
Marc-André Lureau

Re: [Qemu-devel] [Qemu-stable] [PATCH v2 0/2] vhost-user-bridge reconnect regression

Posted by Michael Roth 8 years, 1 month ago

Quoting Marc-André Lureau (2017-08-29 10:57:01)
> Hi
> 
> On Tue, Aug 29, 2017 at 5:34 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> > On Tue, Aug 29, 2017 at 05:27:49PM +0200, Marc-André Lureau wrote:
> >> Hi,
> >>
> >> libvhost-user doesn't support resuming with the same trick vubr had
> >> since commit 523b018dde3b7650fe5401d0499b30cf2f117515. The following
> >> two patches fix that regression.
> >
> >
> > Thanks! Do we need this in 2.10? If not pls ping after 2.10 is out.
> 
> I think it's not necessary since the regression appeared in 2.9
> already, and it's a manual test.
> 
> I'll ping after 2.10

FYI I'm looking to get v2.10.1 out this month, freeze will likely be set for
Sep. 25th if you're looking to get this in.

> 
> >
> >> Thanks
> >>
> >> Marc-André Lureau (2):
> >>   libvhost-user: support resuming vq->last_avail_idx based on used_idx
> >>   vhost-user-bridge: fix resume regression (since 2.9)
> >>
> >>  contrib/libvhost-user/libvhost-user.h |  7 +++++++
> >>  contrib/libvhost-user/libvhost-user.c | 13 +++++++++++++
> >>  tests/vhost-user-bridge.c             |  7 +++++++
> >>  3 files changed, 27 insertions(+)
> >>
> >> --
> >> 2.14.1.146.gd35faa819
> >
> 
> 
> 
> -- 
> Marc-André Lureau
>