[v2] nbd-client: enter read_reply_co during init to avoid crash

[Qemu-devel] [PATCH v2 0/3] nbd-client: enter read_reply_co during init to avoid crash

Stefan Hajnoczi posted 3 patches 6 years, 8 months ago

Diff against v1
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170829122745.14309-1-stefanha@redhat.com

Test FreeBSD passed

Test checkpatch passed

Test docker passed

Test s390x passed

block/nbd-client.c                       |  25 ++----
tests/qemu-iotests/083                   | 138 ++++++++++++++++++-----------
tests/qemu-iotests/083.out               | 145 +++++++++++++++++++++++++++----
tests/qemu-iotests/common.filter         |   4 +-
tests/qemu-iotests/nbd-fault-injector.py |   4 +
5 files changed, 228 insertions(+), 88 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v2 0/3] nbd-client: enter read_reply_co during init to avoid crash

Posted by Stefan Hajnoczi 6 years, 8 months ago

v2:
 * Rewrote Patch 1 following Paolo's suggestion [Paolo]

See Patch 1 for the segfault fix.  Patches 2 & 3 add qemu-iotests coverage.

This is a rare crash that we'll probably only see in testing.  It only seems to
happen with UNIX domain sockets.

Stefan Hajnoczi (3):
  nbd-client: avoid read_reply_co entry if send failed
  qemu-iotests: improve nbd-fault-injector.py startup protocol
  qemu-iotests: test NBD over UNIX domain sockets in 083

 block/nbd-client.c                       |  25 ++----
 tests/qemu-iotests/083                   | 138 ++++++++++++++++++-----------
 tests/qemu-iotests/083.out               | 145 +++++++++++++++++++++++++++----
 tests/qemu-iotests/common.filter         |   4 +-
 tests/qemu-iotests/nbd-fault-injector.py |   4 +
 5 files changed, 228 insertions(+), 88 deletions(-)

-- 
2.13.5

Re: [Qemu-devel] [PATCH v2 0/3] nbd-client: enter read_reply_co during init to avoid crash

Posted by Eric Blake 6 years, 8 months ago

On 08/29/2017 07:27 AM, Stefan Hajnoczi wrote:
> v2:
>  * Rewrote Patch 1 following Paolo's suggestion [Paolo]
> 
> See Patch 1 for the segfault fix.  Patches 2 & 3 add qemu-iotests coverage.
> 
> This is a rare crash that we'll probably only see in testing.  It only seems to
> happen with UNIX domain sockets.
> 
> Stefan Hajnoczi (3):
>   nbd-client: avoid read_reply_co entry if send failed
>   qemu-iotests: improve nbd-fault-injector.py startup protocol
>   qemu-iotests: test NBD over UNIX domain sockets in 083

Thanks; I'm including this series in my NBD tree, and will send a pull
request once 2.11 opens up.

> 
>  block/nbd-client.c                       |  25 ++----
>  tests/qemu-iotests/083                   | 138 ++++++++++++++++++-----------
>  tests/qemu-iotests/083.out               | 145 +++++++++++++++++++++++++++----
>  tests/qemu-iotests/common.filter         |   4 +-
>  tests/qemu-iotests/nbd-fault-injector.py |   4 +
>  5 files changed, 228 insertions(+), 88 deletions(-)
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org