1. Patchew
  2. QEMU
  3. View series

[Qemu-devel] [PULL 0/1] slirp updates

Samuel Thibault posted 1 patch 8 years, 2 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170827230506.12683-1-samuel.thibault@ens-lyon.org
Test FreeBSD passed
Test checkpatch passed
Test docker passed
Test s390x passed
There is a newer version of this series
[Qemu-devel] [PULL 0/1] slirp updates
Posted by Samuel Thibault 8 years, 2 months ago 
warning: redirection vers https://people.debian.org/~sthibault/qemu.git/
The following changes since commit 04d74e07b4542aad5aa4ad03951b38b767f5314a:

  slirp: fix clearing ifq_so from pending packets (2017-08-26 01:04:12 +0200)

are available in the git repository at:

  http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault

for you to fetch changes up to 04d74e07b4542aad5aa4ad03951b38b767f5314a:

  slirp: fix clearing ifq_so from pending packets (2017-08-26 01:04:12 +0200)

----------------------------------------------------------------
slirp updates

----------------------------------------------------------------
Re: [Qemu-devel] [PULL 0/1] slirp updates
Posted by Peter Maydell 8 years, 2 months ago 
On 28 August 2017 at 00:05, Samuel Thibault
<samuel.thibault@ens-lyon.org> wrote:
> warning: redirection vers https://people.debian.org/~sthibault/qemu.git/
> The following changes since commit 04d74e07b4542aad5aa4ad03951b38b767f5314a:
>
>   slirp: fix clearing ifq_so from pending packets (2017-08-26 01:04:12 +0200)
>
> are available in the git repository at:
>
>   http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault
>
> for you to fetch changes up to 04d74e07b4542aad5aa4ad03951b38b767f5314a:
>
>   slirp: fix clearing ifq_so from pending packets (2017-08-26 01:04:12 +0200)
>
> ----------------------------------------------------------------
> slirp updates
>
> ----------------------------------------------------------------

Is this pull request intended to be for 2.10 (in which
case it needs justification) or for 2.11 (in which case
it's a bit early) ?

thanks
-- PMM
Re: [Qemu-devel] [PULL 0/1] slirp updates
Posted by Samuel Thibault 8 years, 2 months ago 
Peter Maydell, on mar. 29 août 2017 10:20:31 +0100, wrote:
> On 28 August 2017 at 00:05, Samuel Thibault
> <samuel.thibault@ens-lyon.org> wrote:
> > warning: redirection vers https://people.debian.org/~sthibault/qemu.git/
> > The following changes since commit 04d74e07b4542aad5aa4ad03951b38b767f5314a:
> >
> >   slirp: fix clearing ifq_so from pending packets (2017-08-26 01:04:12 +0200)
> >
> > are available in the git repository at:
> >
> >   http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault
> >
> > for you to fetch changes up to 04d74e07b4542aad5aa4ad03951b38b767f5314a:
> >
> >   slirp: fix clearing ifq_so from pending packets (2017-08-26 01:04:12 +0200)
> >
> > ----------------------------------------------------------------
> > slirp updates
> >
> > ----------------------------------------------------------------
> 
> Is this pull request intended to be for 2.10 (in which
> case it needs justification) or for 2.11 (in which case
> it's a bit early) ?

It is for 2.10. It fixes at least a DOS: userland can at least crash
qemu with specially-crafted packets.

Samuel
Re: [Qemu-devel] [PULL 0/1] slirp updates
Posted by Peter Maydell 8 years, 2 months ago 
On 29 August 2017 at 10:22, Samuel Thibault <samuel.thibault@gnu.org> wrote:
> Peter Maydell, on mar. 29 août 2017 10:20:31 +0100, wrote:
>> On 28 August 2017 at 00:05, Samuel Thibault
>> <samuel.thibault@ens-lyon.org> wrote:
>> > warning: redirection vers https://people.debian.org/~sthibault/qemu.git/
>> > The following changes since commit 04d74e07b4542aad5aa4ad03951b38b767f5314a:
>> >
>> >   slirp: fix clearing ifq_so from pending packets (2017-08-26 01:04:12 +0200)
>> >
>> > are available in the git repository at:
>> >
>> >   http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault
>> >
>> > for you to fetch changes up to 04d74e07b4542aad5aa4ad03951b38b767f5314a:
>> >
>> >   slirp: fix clearing ifq_so from pending packets (2017-08-26 01:04:12 +0200)
>> >
>> > ----------------------------------------------------------------
>> > slirp updates
>> >
>> > ----------------------------------------------------------------
>>
>> Is this pull request intended to be for 2.10 (in which
>> case it needs justification) or for 2.11 (in which case
>> it's a bit early) ?
>
> It is for 2.10. It fixes at least a DOS: userland can at least crash
> qemu with specially-crafted packets.

It's really really hard to justify putting this in now.
If it had come in last Wednesday it would have been
easy to put into rc4. If it had come in next Thursday
we'd have shrugged and said "ok, needs to go into next
stable release". Right now it's a choice of "treat it
as if it had arrived in two days time" (ie don't put it
in 2.10) or delay the release by yet another rc cycle.

thanks
-- PMM
Re: [Qemu-devel] [PULL 0/1] slirp updates
Posted by Samuel Thibault 8 years, 2 months ago 
Peter Maydell, on mar. 29 août 2017 16:31:03 +0100, wrote:
> On 29 August 2017 at 10:22, Samuel Thibault <samuel.thibault@gnu.org> wrote:
> > Peter Maydell, on mar. 29 août 2017 10:20:31 +0100, wrote:
> >> On 28 August 2017 at 00:05, Samuel Thibault
> >> <samuel.thibault@ens-lyon.org> wrote:
> >> > warning: redirection vers https://people.debian.org/~sthibault/qemu.git/
> >> > The following changes since commit 04d74e07b4542aad5aa4ad03951b38b767f5314a:
> >> >
> >> >   slirp: fix clearing ifq_so from pending packets (2017-08-26 01:04:12 +0200)
> >> >
> >> > are available in the git repository at:
> >> >
> >> >   http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault
> >> >
> >> > for you to fetch changes up to 04d74e07b4542aad5aa4ad03951b38b767f5314a:
> >> >
> >> >   slirp: fix clearing ifq_so from pending packets (2017-08-26 01:04:12 +0200)
> >> >
> >> > ----------------------------------------------------------------
> >> > slirp updates
> >> >
> >> > ----------------------------------------------------------------
> >>
> >> Is this pull request intended to be for 2.10 (in which
> >> case it needs justification) or for 2.11 (in which case
> >> it's a bit early) ?
> >
> > It is for 2.10. It fixes at least a DOS: userland can at least crash
> > qemu with specially-crafted packets.
> 
> It's really really hard to justify putting this in now.

Alright, it's up to the release managers to decide anyway.

Samuel
Re: [Qemu-devel] [PULL 0/1] slirp updates
Posted by Peter Maydell 8 years, 2 months ago 
On 28 August 2017 at 00:05, Samuel Thibault
<samuel.thibault@ens-lyon.org> wrote:
> warning: redirection vers https://people.debian.org/~sthibault/qemu.git/
> The following changes since commit 04d74e07b4542aad5aa4ad03951b38b767f5314a:
>
>   slirp: fix clearing ifq_so from pending packets (2017-08-26 01:04:12 +0200)
>
> are available in the git repository at:
>
>   http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault
>
> for you to fetch changes up to 04d74e07b4542aad5aa4ad03951b38b767f5314a:
>
>   slirp: fix clearing ifq_so from pending packets (2017-08-26 01:04:12 +0200)
>
> ----------------------------------------------------------------
> slirp updates
>
> ----------------------------------------------------------------

Applied to master, thanks (I cherry-picked the patch so I
could add the cc:stable note).

-- PMM

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.