[v2] postcopy+vhost-user/shared ram

[Qemu-devel] [RFC v2 02/32] vhub: Only process received packets on started queues

Posted by Dr. David Alan Gilbert (git) 8 years, 5 months ago

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

Only process received packets if the queue has been started.

Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
 tests/vhost-user-bridge.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/vhost-user-bridge.c b/tests/vhost-user-bridge.c
index 1e5b5ca3da..324abee53d 100644
--- a/tests/vhost-user-bridge.c
+++ b/tests/vhost-user-bridge.c
@@ -277,6 +277,7 @@ vubr_backend_recv_cb(int sock, void *ctx)
     DPRINT("    hdrlen = %d\n", hdrlen);
 
     if (!vu_queue_enabled(dev, vq) ||
+        !vu_queue_started(dev, vq) ||
         !vu_queue_avail_bytes(dev, vq, hdrlen, 0)) {
         DPRINT("Got UDP packet, but no available descriptors on RX virtq.\n");
         return;
-- 
2.13.5

Re: [Qemu-devel] [RFC v2 02/32] vhub: Only process received packets on started queues

Posted by Marc-André Lureau 8 years, 5 months ago

On Thu, Aug 24, 2017 at 9:27 PM, Dr. David Alan Gilbert (git)
<dgilbert@redhat.com> wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Only process received packets if the queue has been started.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
>  tests/vhost-user-bridge.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tests/vhost-user-bridge.c b/tests/vhost-user-bridge.c
> index 1e5b5ca3da..324abee53d 100644
> --- a/tests/vhost-user-bridge.c
> +++ b/tests/vhost-user-bridge.c
> @@ -277,6 +277,7 @@ vubr_backend_recv_cb(int sock, void *ctx)
>      DPRINT("    hdrlen = %d\n", hdrlen);
>
>      if (!vu_queue_enabled(dev, vq) ||
> +        !vu_queue_started(dev, vq) ||
>          !vu_queue_avail_bytes(dev, vq, hdrlen, 0)) {
>          DPRINT("Got UDP packet, but no available descriptors on RX virtq.\n");
>          return;

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>



-- 
Marc-André Lureau