[Qemu-devel] [PATCH 0/2] qxl: add support for chunked cursors.

Gerd Hoffmann posted 2 patches 6 years, 7 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170824081305.8445-1-kraxel@redhat.com
Test FreeBSD passed
Test checkpatch failed
Test docker passed
Test s390x passed
There is a newer version of this series
hw/display/qxl-render.c | 42 ++++++++++++++++++++++++++----------------
1 file changed, 26 insertions(+), 16 deletions(-)
[Qemu-devel] [PATCH 0/2] qxl: add support for chunked cursors.
Posted by Gerd Hoffmann 6 years, 7 months ago
This series adds support for unpacking qxl chunks, and uses it to
support chunked cursor images.  Windows guest drivers seem to use
that when in HiDPI mode.

Also drop (broken) support for mono cursors.

Gerd Hoffmann (2):
  qxl: drop mono cursor support
  qxl: add support for chunked cursors.

 hw/display/qxl-render.c | 42 ++++++++++++++++++++++++++----------------
 1 file changed, 26 insertions(+), 16 deletions(-)

-- 
2.9.3


Re: [Qemu-devel] [PATCH 0/2] qxl: add support for chunked cursors.
Posted by no-reply@patchew.org 6 years, 7 months ago
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20170824081305.8445-1-kraxel@redhat.com
Subject: [Qemu-devel] [PATCH 0/2] qxl: add support for chunked cursors.

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
008bbacb9b qxl: add support for chunked cursors.
1b9a2e39e8 qxl: drop mono cursor support

=== OUTPUT BEGIN ===
Checking PATCH 1/2: qxl: drop mono cursor support...
Checking PATCH 2/2: qxl: add support for chunked cursors....
ERROR: braces {} are necessary for all arms of this statement
#29: FILE: hw/display/qxl-render.c:218:
+        if (offset == size)
[...]

ERROR: braces {} are necessary for all arms of this statement
#32: FILE: hw/display/qxl-render.c:221:
+        if (!chunk)
[...]

total: 2 errors, 0 warnings, 51 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org