[v3] target/s390x: cleanup cpu.h

[Qemu-devel] [PATCH v3 for-2.11 03/18] target/s390x: simplify ri_allowed()

Posted by David Hildenbrand 8 years, 5 months ago

Only used in KVM and there is no reason why it shouldn't be allowed for
tcg - it is simply not available.

Signed-off-by: David Hildenbrand <david@redhat.com>
---
 hw/s390x/s390-virtio-ccw.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
index 1c7af39..3a674f5 100644
--- a/hw/s390x/s390-virtio-ccw.c
+++ b/hw/s390x/s390-virtio-ccw.c
@@ -276,9 +276,6 @@ static S390CcwMachineClass *get_machine_class(void)
 
 bool ri_allowed(void)
 {
-    if (!kvm_enabled()) {
-        return false;
-    }
     /* for "none" machine this results in true */
     return get_machine_class()->ri_allowed;
 }
-- 
2.9.4

Re: [Qemu-devel] [PATCH v3 for-2.11 03/18] target/s390x: simplify ri_allowed()

Posted by Thomas Huth 8 years, 5 months ago

On 18.08.2017 13:43, David Hildenbrand wrote:
> Only used in KVM and there is no reason why it shouldn't be allowed for
> tcg - it is simply not available.
> 
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
>  hw/s390x/s390-virtio-ccw.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
> index 1c7af39..3a674f5 100644
> --- a/hw/s390x/s390-virtio-ccw.c
> +++ b/hw/s390x/s390-virtio-ccw.c
> @@ -276,9 +276,6 @@ static S390CcwMachineClass *get_machine_class(void)
>  
>  bool ri_allowed(void)
>  {
> -    if (!kvm_enabled()) {
> -        return false;
> -    }
>      /* for "none" machine this results in true */
>      return get_machine_class()->ri_allowed;
>  }
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>