v2:
 * Don't emit event ID mapping records in simpletrace.stp [Daniel Berrange]

The SystemTap flight recorder mode no longer works with simpletrace.stp because
the event ID mapping records are emitted the first time an event fires.
Chances are, the event ID mapping record will not be in ring buffer when the
users wants to print the trace.

This series solves the issue by using the trace-events-all global event
ordering for event IDs for simpletrace.stp.

Stefan Hajnoczi (2):
  trace: use static event ID mapping in simpletrace.stp
  simpletrace: fix flight recorder --no-header option

 scripts/simpletrace.py                       | 24 +++++++++++++++------
 scripts/tracetool/format/simpletrace_stap.py | 31 ++--------------------------
 2 files changed, 20 insertions(+), 35 deletions(-)

-- 
2.13.4

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20170815084430.7128-1-stefanha@redhat.com
Subject: [Qemu-devel] [PATCH for-2.10 v2 0/2] trace: fix simpletrace.stp flight recorder mode
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20170815084430.7128-1-stefanha@redhat.com -> patchew/20170815084430.7128-1-stefanha@redhat.com
Switched to a new branch 'test'
7d6a4eae8d simpletrace: fix flight recorder --no-header option
b371ed247d trace: use static event ID mapping in simpletrace.stp

=== OUTPUT BEGIN ===
Checking PATCH 1/2: trace: use static event ID mapping in simpletrace.stp...
Checking PATCH 2/2: simpletrace: fix flight recorder --no-header option...
ERROR: line over 90 characters
#40: FILE: scripts/simpletrace.py:101:
+    """Deserialize trace records from a file, yielding record tuples (event_num, timestamp, pid, arg1, ..., arg6).

total: 1 errors, 0 warnings, 46 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org

On Tue, Aug 15, 2017 at 01:59:50AM -0700, no-reply@patchew.org wrote:
> Checking PATCH 2/2: simpletrace: fix flight recorder --no-header option...
> ERROR: line over 90 characters
> #40: FILE: scripts/simpletrace.py:101:
> +    """Deserialize trace records from a file, yielding record tuples (event_num, timestamp, pid, arg1, ..., arg6).

This line was not modified, so it wasn't introduced by this patch
series.  I think the reason it's a single line is because Python
docstrings must start with a single line.

Stefan

On Tue, Aug 15, 2017 at 09:44:28AM +0100, Stefan Hajnoczi wrote:
> v2:
>  * Don't emit event ID mapping records in simpletrace.stp [Daniel Berrange]
> 
> The SystemTap flight recorder mode no longer works with simpletrace.stp because
> the event ID mapping records are emitted the first time an event fires.
> Chances are, the event ID mapping record will not be in ring buffer when the
> users wants to print the trace.
> 
> This series solves the issue by using the trace-events-all global event
> ordering for event IDs for simpletrace.stp.
> 
> Stefan Hajnoczi (2):
>   trace: use static event ID mapping in simpletrace.stp
>   simpletrace: fix flight recorder --no-header option
> 
>  scripts/simpletrace.py                       | 24 +++++++++++++++------
>  scripts/tracetool/format/simpletrace_stap.py | 31 ++--------------------------
>  2 files changed, 20 insertions(+), 35 deletions(-)
> 
> -- 
> 2.13.4
> 
> 

Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing

Stefan