[v1] qmp-shell non-interactive mode, delete scripts/qmp/qmp

[Qemu-devel] [PATCH for-2.11 0/5] qmp-shell non-interactive mode, delete scripts/qmp/qmp

Posted by Eduardo Habkost 6 years, 8 months ago

This series adds the ability to run QMP commands
non-interactively to qmp-shell, and deletes scripts/qmp/qmp.

Eduardo Habkost (5):
  qmp-shell: Use argparse module
  qmp-shell: Pass split cmdargs to __build_cmd()
  qmp-shell: execute_cmdargs() method
  qmp-shell: Accept QMP command as argument
  Remove scripts/qmp/qmp

 scripts/qmp/qmp       | 126 --------------------------------------------------
 scripts/qmp/qmp-shell |  90 ++++++++++++++++--------------------
 2 files changed, 40 insertions(+), 176 deletions(-)
 delete mode 100755 scripts/qmp/qmp

-- 
2.9.4

Re: [Qemu-devel] [PATCH for-2.11 0/5] qmp-shell non-interactive mode, delete scripts/qmp/qmp

Posted by John Snow 6 years, 8 months ago


On 08/04/2017 05:36 PM, Eduardo Habkost wrote:
> This series adds the ability to run QMP commands
> non-interactively to qmp-shell, and deletes scripts/qmp/qmp.
> 
> Eduardo Habkost (5):
>   qmp-shell: Use argparse module
>   qmp-shell: Pass split cmdargs to __build_cmd()
>   qmp-shell: execute_cmdargs() method
>   qmp-shell: Accept QMP command as argument
>   Remove scripts/qmp/qmp
> 
>  scripts/qmp/qmp       | 126 --------------------------------------------------
>  scripts/qmp/qmp-shell |  90 ++++++++++++++++--------------------
>  2 files changed, 40 insertions(+), 176 deletions(-)
>  delete mode 100755 scripts/qmp/qmp
> 

Assuming there are no reasons to keep the old script around (I certainly
never used it) this appears to be fine. May as well fortify one really
good QMP tool instead of a dozen little half baked ones.

Tested-by: John Snow <jsnow@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>

Re: [Qemu-devel] [PATCH for-2.11 0/5] qmp-shell non-interactive mode, delete scripts/qmp/qmp

Posted by Fam Zheng 6 years, 8 months ago

On Fri, 08/04 18:36, Eduardo Habkost wrote:
> This series adds the ability to run QMP commands
> non-interactively to qmp-shell, and deletes scripts/qmp/qmp.

Hmm, not so simple:

$ git grep 'import qmp'
scripts/qemu.py:import qmp.qmp
scripts/qmp/qemu-ga-client:import qmp
scripts/qmp/qmp-shell:import qmp
scripts/qtest.py:import qmp.qmp
tests/migration/guestperf/engine.py:import qmp.qmp

Fam

Re: [Qemu-devel] [PATCH for-2.11 0/5] qmp-shell non-interactive mode, delete scripts/qmp/qmp

Posted by Eduardo Habkost 6 years, 8 months ago

On Sat, Aug 05, 2017 at 10:56:20PM +0800, Fam Zheng wrote:
> On Fri, 08/04 18:36, Eduardo Habkost wrote:
> > This series adds the ability to run QMP commands
> > non-interactively to qmp-shell, and deletes scripts/qmp/qmp.
> 
> Hmm, not so simple:
> 
> $ git grep 'import qmp'
> scripts/qemu.py:import qmp.qmp
> scripts/qmp/qemu-ga-client:import qmp
> scripts/qmp/qmp-shell:import qmp
> scripts/qtest.py:import qmp.qmp
> tests/migration/guestperf/engine.py:import qmp.qmp

I'm deleting scripts/qmp/qmp, not scripts/qmp/qmp.py.

-- 
Eduardo

Re: [Qemu-devel] [PATCH for-2.11 0/5] qmp-shell non-interactive mode, delete scripts/qmp/qmp

Posted by Fam Zheng 6 years, 8 months ago

On Sat, 08/05 16:11, Eduardo Habkost wrote:
> On Sat, Aug 05, 2017 at 10:56:20PM +0800, Fam Zheng wrote:
> > On Fri, 08/04 18:36, Eduardo Habkost wrote:
> > > This series adds the ability to run QMP commands
> > > non-interactively to qmp-shell, and deletes scripts/qmp/qmp.
> > 
> > Hmm, not so simple:
> > 
> > $ git grep 'import qmp'
> > scripts/qemu.py:import qmp.qmp
> > scripts/qmp/qemu-ga-client:import qmp
> > scripts/qmp/qmp-shell:import qmp
> > scripts/qtest.py:import qmp.qmp
> > tests/migration/guestperf/engine.py:import qmp.qmp
> 
> I'm deleting scripts/qmp/qmp, not scripts/qmp/qmp.py.

Yeah, OK, I was confused.

Fam