[Qemu-devel] [PATCH for 2.11] vga/migration: Update memory map in post_load

Dr. David Alan Gilbert (git) posted 1 patch 6 years, 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170804113329.13609-1-dgilbert@redhat.com
Test FreeBSD passed
Test checkpatch passed
Test docker passed
Test s390x passed
hw/display/vga.c | 1 +
1 file changed, 1 insertion(+)
[Qemu-devel] [PATCH for 2.11] vga/migration: Update memory map in post_load
Posted by Dr. David Alan Gilbert (git) 6 years, 8 months ago
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

After migration the chain4 alias mapping added by 80763888 (in 2011)
might be missing, since there's no call to vga_update_memory_access
in the post_load after the registers are updated.  Add it back.

Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
 hw/display/vga.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/display/vga.c b/hw/display/vga.c
index 63421f9ee8..5d3848a37e 100644
--- a/hw/display/vga.c
+++ b/hw/display/vga.c
@@ -2044,6 +2044,7 @@ static int vga_common_post_load(void *opaque, int version_id)
     /* force refresh */
     s->graphic_mode = -1;
     vbe_update_vgaregs(s);
+    vga_update_memory_access(s);
     return 0;
 }
 
-- 
2.13.3


Re: [Qemu-devel] [PATCH for 2.11] vga/migration: Update memory map in post_load
Posted by Juan Quintela 6 years, 8 months ago
"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> After migration the chain4 alias mapping added by 80763888 (in 2011)
> might be missing, since there's no call to vga_update_memory_access
> in the post_load after the registers are updated.  Add it back.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>

Interesting looking at vga_update_memory_access() from 80763888 and what
is currently there O:-)