[Qemu-devel] [PULL 0/9] Tracing patches

Stefan Hajnoczi posted 9 patches 6 years, 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170801131618.27332-1-stefanha@redhat.com
Test FreeBSD passed
Test checkpatch failed
Test docker passed
Test s390x passed
There is a newer version of this series
docs/devel/tracing.txt                       |   2 +-
Makefile.target                              |   9 +-
trace/control.h                              |  18 ++-
hw/usb/hcd-ohci.c                            |  13 +-
monitor.c                                    |   9 +-
net/colo-compare.c                           |  11 +-
net/filter-rewriter.c                        |   4 +-
CODING_STYLE                                 |  35 ++++++
accel/tcg/trace-events                       |   2 +-
audio/trace-events                           |   4 +-
block/trace-events                           |  28 ++---
hw/audio/trace-events                        |   4 +-
hw/char/trace-events                         |  12 +-
hw/display/trace-events                      |  14 +--
hw/dma/trace-events                          |  20 +--
hw/i386/xen/trace-events                     |  26 ++--
hw/input/trace-events                        |   6 +-
hw/intc/trace-events                         | 176 +++++++++++++--------------
hw/isa/trace-events                          |   4 +-
hw/misc/trace-events                         |  78 ++++++------
hw/net/trace-events                          |  52 ++++----
hw/nvram/trace-events                        |   2 +-
hw/pci/trace-events                          |   4 +-
hw/ppc/trace-events                          |  64 +++++-----
hw/s390x/trace-events                        |  20 +--
hw/scsi/trace-events                         | 118 +++++++++---------
hw/sd/trace-events                           |   4 +-
hw/timer/trace-events                        |  20 +--
hw/usb/trace-events                          |  56 ++++-----
hw/vfio/trace-events                         |  44 +++----
hw/virtio/trace-events                       |   6 +-
hw/xen/trace-events                          |   8 +-
linux-user/trace-events                      |  10 +-
migration/trace-events                       |  36 +++---
nbd/trace-events                             |  18 +--
net/trace-events                             |   4 +-
scripts/checkpatch.pl                        |  19 +++
scripts/tracetool/__init__.py                |   1 +
scripts/tracetool/backend/__init__.py        |   3 +
scripts/tracetool/backend/dtrace.py          |  12 ++
scripts/tracetool/backend/ftrace.py          |   5 +
scripts/tracetool/backend/log.py             |   5 +
scripts/tracetool/backend/simple.py          |   5 +
scripts/tracetool/backend/syslog.py          |   5 +
scripts/tracetool/backend/ust.py             |  10 ++
scripts/tracetool/format/h.py                |  10 ++
scripts/tracetool/format/simpletrace_stap.py |  29 +++--
target/arm/trace-events                      |  10 +-
target/s390x/trace-events                    |   2 +-
target/sparc/trace-events                    |  30 ++---
trace-events                                 |  20 +--
51 files changed, 622 insertions(+), 485 deletions(-)
[Qemu-devel] [PULL 0/9] Tracing patches
Posted by Stefan Hajnoczi 6 years, 8 months ago
The following changes since commit 5619c179057e24195ff19c8fe6d6a6cbcb16ed28:

  Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20170731' into staging (2017-07-31 14:45:42 +0100)

are available in the git repository at:

  git://github.com/stefanha/qemu.git tags/tracing-pull-request

for you to fetch changes up to bd6952a391b6f2083d6597386f457f30044e32a3:

  monitor: Reduce handle_qmp_command() tracing overhead (2017-08-01 12:13:07 +0100)

----------------------------------------------------------------
Pull request

Fixes for inconsistencies in the trace event format strings, broken
trace_event_get_state() usage, and handle_qmp_command() fix.

----------------------------------------------------------------

Daniel P. Berrange (2):
  trace: ensure .stp files are rebuilt if trace tool source changes
  trace: ensure unique function / variable names per .stp file

Denis V. Lunev (1):
  monitor: Reduce handle_qmp_command() tracing overhead

Stefan Hajnoczi (2):
  trace: add TRACE_<event>_BACKEND_DSTATE()
  trace: add trace_event_get_state_backends()

Vladimir Sementsov-Ogievskiy (4):
  coding_style: add point about 0x in trace-events
  trace-events: fix code style: %# -> 0x%
  checkpatch: check trace-events code style
  trace-events: fix code style: print 0x before hex numbers

 docs/devel/tracing.txt                       |   2 +-
 Makefile.target                              |   9 +-
 trace/control.h                              |  18 ++-
 hw/usb/hcd-ohci.c                            |  13 +-
 monitor.c                                    |   9 +-
 net/colo-compare.c                           |  11 +-
 net/filter-rewriter.c                        |   4 +-
 CODING_STYLE                                 |  35 ++++++
 accel/tcg/trace-events                       |   2 +-
 audio/trace-events                           |   4 +-
 block/trace-events                           |  28 ++---
 hw/audio/trace-events                        |   4 +-
 hw/char/trace-events                         |  12 +-
 hw/display/trace-events                      |  14 +--
 hw/dma/trace-events                          |  20 +--
 hw/i386/xen/trace-events                     |  26 ++--
 hw/input/trace-events                        |   6 +-
 hw/intc/trace-events                         | 176 +++++++++++++--------------
 hw/isa/trace-events                          |   4 +-
 hw/misc/trace-events                         |  78 ++++++------
 hw/net/trace-events                          |  52 ++++----
 hw/nvram/trace-events                        |   2 +-
 hw/pci/trace-events                          |   4 +-
 hw/ppc/trace-events                          |  64 +++++-----
 hw/s390x/trace-events                        |  20 +--
 hw/scsi/trace-events                         | 118 +++++++++---------
 hw/sd/trace-events                           |   4 +-
 hw/timer/trace-events                        |  20 +--
 hw/usb/trace-events                          |  56 ++++-----
 hw/vfio/trace-events                         |  44 +++----
 hw/virtio/trace-events                       |   6 +-
 hw/xen/trace-events                          |   8 +-
 linux-user/trace-events                      |  10 +-
 migration/trace-events                       |  36 +++---
 nbd/trace-events                             |  18 +--
 net/trace-events                             |   4 +-
 scripts/checkpatch.pl                        |  19 +++
 scripts/tracetool/__init__.py                |   1 +
 scripts/tracetool/backend/__init__.py        |   3 +
 scripts/tracetool/backend/dtrace.py          |  12 ++
 scripts/tracetool/backend/ftrace.py          |   5 +
 scripts/tracetool/backend/log.py             |   5 +
 scripts/tracetool/backend/simple.py          |   5 +
 scripts/tracetool/backend/syslog.py          |   5 +
 scripts/tracetool/backend/ust.py             |  10 ++
 scripts/tracetool/format/h.py                |  10 ++
 scripts/tracetool/format/simpletrace_stap.py |  29 +++--
 target/arm/trace-events                      |  10 +-
 target/s390x/trace-events                    |   2 +-
 target/sparc/trace-events                    |  30 ++---
 trace-events                                 |  20 +--
 51 files changed, 622 insertions(+), 485 deletions(-)

-- 
2.13.3


Re: [Qemu-devel] [PULL 0/9] Tracing patches
Posted by no-reply@patchew.org 6 years, 8 months ago
Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PULL 0/9] Tracing patches
Message-id: 20170801131618.27332-1-stefanha@redhat.com
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
ea1ac22b6f monitor: Reduce handle_qmp_command() tracing overhead
310790af52 trace-events: fix code style: print 0x before hex numbers
f401de6d78 checkpatch: check trace-events code style
5338cd3bca trace-events: fix code style: %# -> 0x%
78b7ef9c66 coding_style: add point about 0x in trace-events
e13fc57ae9 trace: add trace_event_get_state_backends()
abc647bba6 trace: add TRACE_<event>_BACKEND_DSTATE()
1dd27d433d trace: ensure unique function / variable names per .stp file
dc8a17bea0 trace: ensure .stp files are rebuilt if trace tool source changes

=== OUTPUT BEGIN ===
Checking PATCH 1/9: trace: ensure .stp files are rebuilt if trace tool source changes...
Checking PATCH 2/9: trace: ensure unique function / variable names per .stp file...
Checking PATCH 3/9: trace: add TRACE_<event>_BACKEND_DSTATE()...
Checking PATCH 4/9: trace: add trace_event_get_state_backends()...
Checking PATCH 5/9: coding_style: add point about 0x in trace-events...
Checking PATCH 6/9: trace-events: fix code style: %# -> 0x%...
Checking PATCH 7/9: checkpatch: check trace-events code style...
WARNING: line over 80 characters
#28: FILE: scripts/checkpatch.pl:1343:
+				ERROR("Don't use '#' flag of printf format ('%#') in " .

ERROR: line over 90 characters
#29: FILE: scripts/checkpatch.pl:1344:
+				      "trace-events, use '0x' prefix instead\n" . $herecurr);

ERROR: line over 90 characters
#32: FILE: scripts/checkpatch.pl:1347:
+					qr/%[-+ *.0-9]*([hljztL]|ll|hh)?(x|X|"\s*PRI[xX][^"]*"?)/;

ERROR: line over 90 characters
#34: FILE: scripts/checkpatch.pl:1349:
+				# don't consider groups splitted by [.:/ ], like 2A.20:12ab

WARNING: line over 80 characters
#35: FILE: scripts/checkpatch.pl:1350:
+				my $tmpline = $rawline =~ s/($hex[.:\/ ])+$hex//gr;

WARNING: line over 80 characters
#38: FILE: scripts/checkpatch.pl:1353:
+					ERROR("Hex numbers must be prefixed with '0x'\n" .

total: 3 errors, 3 warnings, 25 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 8/9: trace-events: fix code style: print 0x before hex numbers...
Checking PATCH 9/9: monitor: Reduce handle_qmp_command() tracing overhead...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
Re: [Qemu-devel] [PULL 0/9] Tracing patches
Posted by Peter Maydell 6 years, 8 months ago
On 1 August 2017 at 14:16, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> The following changes since commit 5619c179057e24195ff19c8fe6d6a6cbcb16ed28:
>
>   Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20170731' into staging (2017-07-31 14:45:42 +0100)
>
> are available in the git repository at:
>
>   git://github.com/stefanha/qemu.git tags/tracing-pull-request
>
> for you to fetch changes up to bd6952a391b6f2083d6597386f457f30044e32a3:
>
>   monitor: Reduce handle_qmp_command() tracing overhead (2017-08-01 12:13:07 +0100)
>
> ----------------------------------------------------------------
> Pull request
>
> Fixes for inconsistencies in the trace event format strings, broken
> trace_event_get_state() usage, and handle_qmp_command() fix.
>
> ----------------------------------------------------------------

Applied, thanks.

-- PMM